Skip to content

Warn on invalid fields in the [book] section of book.toml #2637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

szabgab
Copy link
Contributor

@szabgab szabgab commented Apr 3, 2025

A step for #1595.

We might need to revise this if de decide to remove the multilingual field as described in #2636

@rustbot rustbot added the S-waiting-on-review Status: waiting on a review label Apr 3, 2025
@ehuss
Copy link
Contributor

ehuss commented Apr 8, 2025

Is it possible to implement this with serde_ignored?

@szabgab
Copy link
Contributor Author

szabgab commented Apr 9, 2025

I'll give it a try, though I thought this whole warning thing is a temporary solution to give the users the opportunity to fix their configuration before the strict checking is turned on.

szabgab added 2 commits April 9, 2025 10:25
A step for rust-lang#1595.

We might need to revise this if de decide to remove the `multilingual`
field as described in rust-lang#2636
@szabgab szabgab force-pushed the warn-on-invalid-fields-in-book-section branch from 7c87a81 to 1e581c3 Compare April 9, 2025 07:32
@szabgab
Copy link
Contributor Author

szabgab commented Apr 9, 2025

I looked at serde_ignored and it is not clear to me how to combine it with the custom code we have to handle the legacy format.
I'd prefer you integrate this change as it is.

Then, if you agree, I can send a PR to handle #2653

Then, once that's integrated, I'll convert the whole thing to use serde_ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: waiting on a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants