TreeBorrows: split Tree::perform_protector_release_access from Tree::perform_access
#4741
+71
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thank you for contributing to Miri! A reviewer will take a look at your PR, typically within a week or two. |
RalfJung
reviewed
Dec 6, 2025
| access_range_and_kind: Option<(AllocRange, AccessKind, diagnostics::AccessCause)>, | ||
| access_range: AllocRange, | ||
| access_kind: AccessKind, | ||
| access_cause: AccessCause, |
Member
There was a problem hiding this comment.
access_cause is also just used for diagnostics I assume?
| } | ||
| interp_ok(()) | ||
| } | ||
| /// this is the special access that is applied on protector release: |
Member
There was a problem hiding this comment.
Suggested change
| /// this is the special access that is applied on protector release: | |
| /// This is the special access that is applied on protector release: |
| /// - and it will be a read except if the location is `Unique`, i.e. has been written to, | ||
| /// in which case it will be a write. | ||
| /// - otherwise identical to `Tree::perform_access` | ||
| pub fn perform_protector_release_access( |
Member
There was a problem hiding this comment.
I think we more typically call this "protector end access", so
Suggested change
| pub fn perform_protector_release_access( | |
| pub fn perform_protector_end_access( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Tree::perform_accessfunction currently is used for both normal accesses and protector release accesses.However, both of these are handled by different branches and don't share any code, so this splits them into two separate functions.