remove the safe keyword from a c-variadic foreign function.
#1838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Calling a c-variadic function is never safe: passing an unexpected number of arguments, or arguments of an unexpected type, is UB.
ehuss
force-pushed
the
c-variadic-remove-safe-keyword
branch
from
d23cd92 to
3c50306
Compare
traviscross
approved these changes
Jun 3, 2025
ehuss
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling a c-variadic function is never safe: passing an unexpected number of arguments, or arguments of an unexpected type, is UB.
As requested in rust-lang/rust#141733 (comment), cc @ehuss