type-layout: rewrite #[repr(C)] struct layout algorithm#2243
Open
DanielEScherzer wants to merge 1 commit into
Open
type-layout: rewrite #[repr(C)] struct layout algorithm#2243DanielEScherzer wants to merge 1 commit into
#[repr(C)] struct layout algorithm#2243DanielEScherzer wants to merge 1 commit into
Conversation
rustbot
added
the
S-waiting-on-review
DanielEScherzer
force-pushed
the
type-layout-algo
branch
6 times, most recently
from
d49cb73 to
98e21c5
Compare
This comment was marked as resolved.
This comment was marked as resolved.
rustbot
removed
the
S-waiting-on-review
Make the code actual compile by defining types, not using a variable named `struct`, adding `mut` where needed, etc. Properly handle the `max()` alignment call returning `Option<usize>` rather than `usize` by using 1 for the alignment if there are no fields. Add comments with the parts of the algorithm that are represented by the statements.
DanielEScherzer
force-pushed
the
type-layout-algo
branch
from
98e21c5 to
e002983
Compare
rustbot
added
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the code actual compile by defining types, not using a variable named
struct, addingmutwhere needed, etc.Properly handle the
max()alignment call returningOption<usize>rather thanusizeby using 1 for the alignment if there are no fields.Add comments with the parts of the algorithm that are represented by the statements.