fix: Correct span info for mir::Operand #19247
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
Right now the question is whether I should go the extra mile and make |
alibektas
changed the title
ChayimFriedman2
requested changes
Feb 28, 2025
| @@ -18,7 +18,22 @@ pub(crate) fn moved_out_of_ref(ctx: &DiagnosticsContext<'_>, d: &hir::MovedOutOf | |||
| mod tests { | |||
| use crate::tests::check_diagnostics; | |||
|
|
|||
| // FIXME: spans are broken | |||
| #[test] | |||
| fn abc() { | |||
There was a problem hiding this comment.
That... doesn't seem like the most descriptive name.
There was a problem hiding this comment.
Don't worry, it happens to me too that I put a test before the changes and don't bother to make its name meaningful, I understand you can forget to do that after :)
|
I think it'd be better if we wouldn't make this optional when there is no reason. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19172