Fix ide-assists raw_string suffix fail #19622
Conversation
rustbot
added
the
S-waiting-on-review
A4-Tacks
changed the title
| let range = token.syntax().text_range(); | ||
| let suffix = string_suffix(token.text()).unwrap_or_default(); | ||
| let range = TextRange::new(range.start(), range.end() - TextSize::of(suffix)); |
There was a problem hiding this comment.
Can we add this stuff as a method on IsString? text_range_with_quotes or something like that
There was a problem hiding this comment.
Actually instead of string_suffix we can make use of the IsString::quote_offsets function here
There was a problem hiding this comment.
What about char? Is there anything similar
There was a problem hiding this comment.
No there isn't, we should probably implement IsString for Char as well though (and then consider renaming the trait). I guess the RAW_PREFIX stuff doesn't make sense on it but that's not too much of an issue
There was a problem hiding this comment.
It seems that IsString::quote_offsets is not just extracting suffixes, but extracting quotation marks, which can be difficult to handle for #
There was a problem hiding this comment.
string_suffix(r###"r##"x"##i32"###) -> "i32"
QuoteOffsets::new(r###"r##"x"##i32"###) -> range "r##\"", range "\"##i32", and range "x"
There was a problem hiding this comment.
Ah okay, well 'lets merge as is then
|
Thanks! |
Fixes #19621
Fixes #19625