Prepare to split clippy_lints
#14684
Conversation
…ed files in `clippy_dev`
* rename test files inside directories and ui-toml tests * rename tests prefixed with the lint's name * better module path renaming when renaming the lint's module * partially delete lint files when uplifting * rename ui_test error markers
rustbot
added
the
S-waiting-on-review
|
Thanks for assigning me to those PRs and requesting my review! However, I can't keep up with my reviews. I suggest Alex as the main reviewer, maybe with the help of Samuel. I fully trust you that you'll improve our tooling here! If you really want my review, just keep me assigned and I'll see what I can do this weekend. Otherwise, feel free to re-assign those PRs to Alex and/or Samuel. (applies to all clippy_dev PRs currently open, just commenting once here) |
|
I only assigned you to this one since splitting will (maybe) affect the sync in an annoying way. edit: Just rerolled the others. |
Jarcho
added
the
S-blocked
| } | ||
| } | ||
|
|
||
| fn crate_root_path(self) -> &'static str { |
There was a problem hiding this comment.
NIT: Maybe a better name crate_lib_path or even more explicit crate_lib_rs_path.
No strong opinion here though.
There was a problem hiding this comment.
I'll leave this for when I end up having to rebase. Hopefully I don't forget.
Based on #14633
The end goal here is to split
clippy_lintsinto several independent crates and have the driver call out to each of them to register lints.clippy_lintstakes way too long to compile right now.r? @flip1995
changelog: none