Skip to content

Rework module_inception #14753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Rework module_inception #14753

wants to merge 1 commit into from
+120 −67

Conversation

Jarcho
Copy link
Contributor

@Jarcho Jarcho commented May 8, 2025

  • Don't check for repetition if the previous module crosses a body boundary.
  • Don't take a snippet of the entire item.
  • Check each item's visibility once.
  • Use is_from_proc_macro before linting

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented May 8, 2025

r? @Manishearth

rustbot has assigned @Manishearth.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 8, 2025
@Jarcho Jarcho force-pushed the mod_inception branch 2 times, most recently from cfeac47 to fa4b49b Compare May 8, 2025 07:35
Manishearth
Manishearth reviewed May 8, 2025
View reviewed changes
Copy link
Member

@Manishearth Manishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on vacation soon, will redirect review

clippy_lints/src/item_name_repetitions.rs Outdated
name: Symbol,
name_camel: String,
is_public: bool,
in_body_count: u32,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: docs on what this is

@Manishearth
Copy link
Member

r? clippy

@rustbot rustbot assigned y21 and unassigned Manishearth May 8, 2025
@rustbot

This comment has been minimized.

Sign in to view
y21
y21 approved these changes Jun 1, 2025
View reviewed changes
Copy link
Member

@y21 y21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. r=me with the dogfood warning fixed

@Jarcho
Rework module_inception
b62beeb 
* Don't check for repetition if the previous module crosses a body boundary.
* Don't take a snippet of the entire item.
* Check each item's visibility once.
* Use `is_from_proc_macro` before linting
@rustbot
Copy link
Collaborator

rustbot commented Aug 17, 2025

☔ The latest upstream changes (possibly #14896) made this pull request unmergeable. Please resolve the merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth Manishearth left review comments

@y21 y21 y21 approved these changes

Assignees

@y21 y21

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Jarcho @rustbot @Manishearth @y21