while_let_loop: Include let assignment in suggestion
#14756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is shorter, and also avoids overloading the `peel_blocks()` from `clippy_utils` with different semantics.
rustbot
added
the
S-waiting-on-review
Jarcho
reviewed
May 15, 2025
tests/ui/crashes/ice-360.stderr
Outdated
| help: try | ||
| | | ||
| LL ~ while let Some(ele) = iter.next() { | ||
| LL + let _ = ele; |
There was a problem hiding this comment.
Should probably also ignore these as they're no-ops (doesn't even read from ele).
Placeholders are still given for the content of the whole block. However, if the result of the original `if let` or `match` expression was assigned, the assignment is reflected in the suggestion. No-op assignments (`let x = x;`) are skipped though, unless they contain an explicit type which might help the compiler (`let x: u32 = x;` is kept).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Placeholders are still given for the content of the whole block. However, if the result of the original
if letormatchexpression was assigned, the assignment is reflected in the suggestion.No-op assignments (
let x = x;) are skipped though, unless they contain an explicit type which might help the compiler (let x: u32 = x;is kept).Closes #362
changelog: [
while_let_loop]: includeletassignment in suggestion