needless_borrow
: do not contradict dangerous_implicit_autorefs
#14810
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust 1.88 introduces the
dangerous_implicit_autorefs
lint which warns about using implicit autorefs on a place obtained from a raw pointer, as this may create aliasing issues.Prevent
clippy::needless_borrow
from triggering in this case, by disabling the lint when taking a reference on a raw pointer dereference. There might be a better way for doing this in the long run with a finer way of distinguish the problematic cases, but this will prevent Clippy from contradicting the compiler in the meantime.Fixes #14743
changelog: [
needless_borrow
]: do not contradict the compiler'sdangerous_implicit_autorefs
lint even though the refererences are not mandatory@rustbot label +beta-nominated
Summary Notes
Generated by triagebot, see help for how to add more