Skip to content

comparison_chain: do not lint on 2 blocks expression #14811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2025
Merged

comparison_chain: do not lint on 2 blocks expression #14811

merged 1 commit into from
May 16, 2025
+19 −40

Conversation

manoj23
Copy link
Contributor

@manoj23 manoj23 commented May 15, 2025

Clippy should not lint 2 blocks expression for comparison_chain.

Fixes #4725

changelog: [comparison_chain]: do not lint 2 blocks expression

@rustbot
Copy link
Collaborator

rustbot commented May 15, 2025

r? @blyxyas

rustbot has assigned @blyxyas.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 15, 2025
@rustbot

This comment has been minimized.

Sign in to view
@manoj23
comparison_chain: do not lint on 2 blocks expression
34c6ba7 
Clippy should not lint 2 blocks expression for comparison_chain.
@manoj23
Copy link
Contributor Author

manoj23 commented May 15, 2025

r? @llogiq

@rustbot rustbot assigned llogiq and unassigned blyxyas May 15, 2025
@manoj23
Copy link
Contributor Author

manoj23 commented May 15, 2025

cc @czoia

@llogiq
Copy link
Contributor

llogiq commented May 16, 2025

Thank you. If memory serves, comparison_chain is one of the more allowed lints we have, so reducing its churn is definitely a plus.

@llogiq llogiq added this pull request to the merge queue May 16, 2025
Merged via the queue into rust-lang:master with commit 95d7eda May 16, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@llogiq llogiq

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

should comparison_chain only trigger for "if x > y {} else if x <y {} else {}" ?
4 participants
@manoj23 @rustbot @llogiq @blyxyas