Skip to content

WIP: Introduce coerce_any_ref_to_any #14812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Ralith
Copy link

@Ralith Ralith commented May 15, 2025

This PR introduces a lint which detects when &Box<dyn Any> is coerced to &dyn Any, which is usually a mistake where the intent was to directly pass the dyn Any inside the box without coercion.

cc @llogiq

Remaining work:

  • Documentation
  • Generalize from Box to any implementer of Deref<Target=dyn Any>

@rustbot
Copy link
Collaborator

rustbot commented May 15, 2025

r? @dswij

rustbot has assigned @dswij.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 15, 2025
@matthiasbeyer
Copy link

r? llogiq

@rustbot rustbot assigned llogiq and unassigned dswij May 15, 2025
@llogiq
Copy link
Contributor

llogiq commented May 16, 2025

This looks good for a start. Let's add the documentation and replace the "default lint description", and then I can start the Final Comment Period for this lint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants