Fix tuple_array_conversions FP when binded vars are used before conversion
#16197
+61
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Collaborator
|
No changes for 3551aeb |
gauravagerwala
added a commit
to gauravagerwala/rust-clippy
that referenced
this pull request
Dec 7, 2025
…P when binded vars are used before conversion
Jarcho
requested changes
Dec 8, 2025
Contributor
There was a problem hiding this comment.
This only fixes one of the problems in the linked issue. The lint is still emitted on:
let [a, b] = foo();
let tup = (b, a);This can't be changed since it's changing the order. This can be a different PR, but the issue can't be closed without it.
rustbot
added
S-waiting-on-author
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
rustbot
added
S-waiting-on-review
Jarcho
reviewed
Dec 9, 2025
Jarcho
approved these changes
Dec 9, 2025
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16192
changelog: [
tuple_array_conversions] fix FP when binded vars are used before conversion