Skip to content

Conversation

@profetia
Copy link
Member

@profetia profetia commented Jan 3, 2026

Closes #16340
Continuation of #16296

More fixes for handling macros

changelog: [string_from_utf8_as_bytes] fix wrongly unmangled macros
changelog: [redundant_pattern_matching] fix wrongly unmangled macros
changelog: [unnecessary_fold] fix wrongly unmangled macros
changelog: [match_as_ref] fix wrongly unmangled macros
changelog: [match_bool] fix wrongly unmangled macros
changelog: [match_ok_err] fix wrongly unmangled macros
changelog: [for_kv_map] fix wrongly unmangled macros
changelog: [question_mark] fix wrongly unmangled macros
changelog: [iter_kv_map] fix wrongly unmangled macros
changelog: [mutex_atomic] fix wrongly unmangled macros

Maybe we should create an internal lint for this?

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jan 3, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 3, 2026

r? @Jarcho

rustbot has assigned @Jarcho.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot

This comment has been minimized.

Copy link
Contributor

@Jarcho Jarcho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to redundant_pattern_match look suspicious after a quick look. I haven't done a full check to see what should be done instead yet.

The others look fine.

View changes since this review

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Jan 6, 2026
@rustbot

This comment has been minimized.

@profetia profetia requested a review from Jarcho January 6, 2026 18:20
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Jan 6, 2026
@rustbot

This comment has been minimized.

@rustbot

This comment has been minimized.

@rustbot
Copy link
Collaborator

rustbot commented Jan 7, 2026

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Copy link
Contributor

@Jarcho Jarcho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jarcho Jarcho added this pull request to the merge queue Jan 8, 2026
Merged via the queue into rust-lang:master with commit 9302f1b Jan 8, 2026
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Malformed suggestion for clippy::iter_kv_map when using vec! in map

3 participants