-
Notifications
You must be signed in to change notification settings - Fork 1.9k
More fixes for handling of macros #16337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
122bfdf to
aecee6b
Compare
3fca721 to
9268b9a
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes to redundant_pattern_match look suspicious after a quick look. I haven't done a full check to see what should be done instead yet.
The others look fine.
9268b9a to
75a66b6
Compare
This comment has been minimized.
This comment has been minimized.
75a66b6 to
5f4d513
Compare
This comment has been minimized.
This comment has been minimized.
5f4d513 to
cb100be
Compare
This comment has been minimized.
This comment has been minimized.
cb100be to
8c129e4
Compare
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
Closes #16340
Continuation of #16296
More fixes for handling macros
changelog: [
string_from_utf8_as_bytes] fix wrongly unmangled macroschangelog: [
redundant_pattern_matching] fix wrongly unmangled macroschangelog: [
unnecessary_fold] fix wrongly unmangled macroschangelog: [
match_as_ref] fix wrongly unmangled macroschangelog: [
match_bool] fix wrongly unmangled macroschangelog: [
match_ok_err] fix wrongly unmangled macroschangelog: [
for_kv_map] fix wrongly unmangled macroschangelog: [
question_mark] fix wrongly unmangled macroschangelog: [
iter_kv_map] fix wrongly unmangled macroschangelog: [
mutex_atomic] fix wrongly unmangled macrosMaybe we should create an internal lint for this?