Skip to content

Add documentation for triagebot [canonicalize-issue-links] handler #825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2025

Conversation

Urgau
Copy link
Member

@Urgau Urgau commented Apr 7, 2025

@rustbot
Copy link
Collaborator

rustbot commented Apr 7, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 7, 2025
github-merge-queue bot pushed a commit to rust-lang/rust-clippy that referenced this pull request Apr 7, 2025
This PR enables to the canonicalization of issue links in triagebot.

Documentation pending at
rust-lang/rust-forge#825

changelog: add `[canonicalize-issue-links]` in `triagebot.toml`
@Urgau
Copy link
Member Author

Urgau commented Apr 9, 2025

cc @Kobzol

@Kobzol Kobzol merged commit e57535e into rust-lang:master Apr 9, 2025
1 check passed
@RalfJung
Copy link
Member

RalfJung commented Apr 9, 2025

This is great, thanks!

We may want to enable this in the main repo as well, or else pulling main repo commits over to Miri/clippy will reference the wrong issues there. They likely don't exist, so nothing gets closed incorrectly, but the links are still broken.

Also FWIW, bors-generated merge commits are a major source of such non-canonical links; I doubt this bot can do anything about that though.

@Kobzol
Copy link
Contributor

Kobzol commented Apr 9, 2025

New bors puts the whole repo name into the merge commit issue link. The problem is that the "Auto merge of #12345" message has been used for a lot of years and there is a bunch of tooling that depends on it and parses the format 😅 So we'll also need to change that.

@Urgau
Copy link
Member Author

Urgau commented Apr 10, 2025

We may want to enable this in the main repo as well, or else pulling main repo commits over to Miri/clippy will reference the wrong issues there. They likely don't exist, so nothing gets closed incorrectly, but the links are still broken.

I didn't think of the other way around, but it makes sense issue links are a problem in both ways.

I'm currently deploying the feature on a few repos and will let it bake before enabling it on our main repo, but sure that I will do after making sure it works well enough and doesn't cause problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants