automate the launch of a new cfp with the cfp command #309

nikomatsakis · 2025-05-21T21:12:30Z

This PR creates a cfp command for automating some of the manual steps to preparing for 2025h2.

The code itself was generated with the use of Cline. I've tested it but I admit I didn't read it all that closely. I noticed some parts were not written as I'd likely do them but... it works.

Rendered

(authored with AI assistance)

lqd · 2025-05-21T21:19:37Z

Ah interesting, I didn’t fix the TOML correctly in #307 then.

nikomatsakis · 2025-05-21T22:56:21Z

.ai/architecture.md

+
+Many of the tasks in `src/admin` are automated via a utility called `cargo rpg`.
+
+The sources for `cargo rpg` as well as the plugin for the mdbook processor are found in crates located in the `crates` directory. The `crates/README.md` summarizes the role of each crate.


I'm not sure if this file did anything actually.

Then maybe we can remove it?

nikomatsakis · 2025-05-21T22:56:50Z

Ah interesting, I didn’t fix the TOML correctly in #307 then.

Apparently not. But our AI overlords found the problem.

nikomatsakis · 2025-05-21T22:58:06Z

crates/rust-project-goals-cli/src/cfp.rs

+    let capitalized_timeframe = format!("{}H{}", &timeframe[0..4], &timeframe[5..]);
+    let new_section = format!(
+        "\n## Next goal period ({})\n\n\
+         The next goal period will be {}, running from {} 1 to {} 30. \


Suggested change

The next goal period will be {}, running from {} 1 to {} 30. \

The next goal period will be {}, running from the start of {} to the end of {}. \

It's probably not always a 30 day month...?

lqd · 2025-05-22T07:46:08Z

crates/rust-project-goals-cli/src/cfp.rs

+        // Found an existing section for this specific timeframe
+        // Find the end of this section (next section or end of file)
+        if let Some(next_section_pos) = content[this_period_match.end()..].find("\n## ") {
+            let end_pos = this_period_match.start() + next_section_pos + this_period_match.end() - this_period_match.start();


this also looks weird

Hmm, yeah, let me test out that scenario. Maybe I can ask it to generate some unit tests for this code.

nikomatsakis · 2025-05-22T19:11:06Z

@lqd ok, it has some unit tets now

lqd

The tests were helpful in that I could try to focus on them, rather than on the (somewhat peculiar) code itself.

To be clear, I don't really mind landing this as is (with at least the test fixes) -- mostly because it can be cleaned up later, and it seems to work as we expect.

Did you also mean to add the 2025h2 content in this PR as well? 8e4d600

lqd · 2025-05-23T08:16:20Z

crates/rust-project-goals-cli/src/cfp.rs

+        let result = process_readme_content(content, "2026h1", "2026h1");
+
+        assert!(result.contains("## Next goal period (2026H1)"));
+        assert!(result.contains("running from January 1 to June 30"));


Evidently we don't run these tests on CI. Some of them mention "January 1" but you've since changed to "the start of January".

Suggested change

assert!(result.contains("running from January 1 to June 30"));

assert!(result.contains("running from the start of January to the end of June"));

and a few other times below.

lqd · 2025-05-23T08:19:23Z

crates/rust-project-goals-cli/src/cfp.rs

+        let content = "# Summary\n\n[Introduction](./README.md)\n\n# ⏳ 2025H1 goal process\n\n- [Overview](./2025h1/README.md)\n";
+        let result = process_summary_content(content, "2026h1", "2026h1");
+
+        assert!(result.contains("# ⏳ 2025H1 goal process"));


No big deal but I was slightly confused by this, and incorrectly thought it updated the existing section. Maybe adding an assertion that it does not is enough.

assert!(result.contains("- [Overview](./2025h1/README.md)"));

lqd · 2025-05-23T08:24:37Z

crates/rust-project-goals-cli/src/cfp.rs

+    pub fn process_template_content(content: &str, timeframe: &str, lowercase_timeframe: &str) -> String {
+        // Remove note sections (starting with '> **NOTE:**' and continuing until a non-'>' line)
+        // But preserve other content starting with '>'
+        let lines: Vec<&str> = content.lines().collect();


An example of things we can fix later. The loop should use the iterator directly.

lqd · 2025-05-23T08:28:27Z

crates/rust-project-goals-cli/src/cfp.rs

+        let mut new_content = content.to_string();
+
+        // Create the new section content with capitalized H
+        let capitalized_timeframe = format!("{}H{}", &timeframe[0..4], &timeframe[5..]);


Another example of things we can fix later. This is already semantically the timeframe parameter, especially when we pass the lowercase version as well.

lqd · 2025-05-23T08:30:22Z

crates/rust-project-goals-cli/src/cfp.rs

+        let _year = &timeframe[0..4];
+        let half = &timeframe[4..].to_lowercase();


Another one for the _year. And there's lowercase_timeframe for the half.

lqd · 2025-05-23T08:33:28Z

crates/rust-project-goals-cli/src/cfp.rs

+            // Found an existing "Next goal period" section
+            // Find the end of this section (next section or end of file)
+            if let Some(next_section_pos) = content[next_period_match.end()..].find("\n## ") {
+                let end_pos = next_period_match.start() + next_section_pos + next_period_match.end() - next_period_match.start();


here as well

lqd · 2025-05-23T08:46:58Z

crates/rust-project-goals-cli/src/cfp.rs

+
+        // Join and process placeholders
+        cleaned_lines.join("\n")
+            .replace("YYYYHN", timeframe)


(This is a note for the things we can fix that is discussed elsewhere: to me this is correct, but this function assumes timeframe is uppercase while the others do not)

lqd · 2025-05-23T08:47:43Z

crates/rust-project-goals-cli/src/cfp.rs

+        println!("Dry run mode - no changes will be made");
+    }
+    // Validate the timeframe format
+    validate_timeframe(timeframe)?;


By ensuring/making timeframe the uppercase version of the goal period, the conversion can be removed from the 3 functions that do it, and make the 1 function assuming it's already the case, correct.

lqd · 2025-05-23T08:49:33Z

crates/rust-project-goals-cli/src/cfp.rs

+    fn test_process_summary_content_no_existing_section() {
+        // Test adding a new section when no timeframe sections exist
+        let content = "# Summary\n\n[Introduction](./README.md)\n";
+        let result = process_summary_content(content, "2026h1", "2026h1");


To me this, and in the other tests that follow, should be

Suggested change

let result = process_summary_content(content, "2026h1", "2026h1");

let result = process_summary_content(content, "2026H1", "2026h1");

like the first test did.

lqd · 2025-05-23T08:51:59Z

.ai/architecture.md

+
+Many of the tasks in `src/admin` are automated via a utility called `cargo rpg`.
+
+The sources for `cargo rpg` as well as the plugin for the mdbook processor are found in crates located in the `crates` directory. The `crates/README.md` summarizes the role of each crate.


Then maybe we can remove it?

Niko Matsakis added 3 commits May 21, 2025 14:20

experiment with .ai files

5b4a710

fix toml

f1a5642

create a cfp command

51b989a

(authored with AI assistance)

Niko Matsakis added 2 commits May 21, 2025 21:33

update the title of the rfc

2d49be6

create a 2025H2 RFC

8e4d600

nikomatsakis commented May 21, 2025

View reviewed changes

lqd reviewed May 22, 2025

View reviewed changes

lqd mentioned this pull request May 22, 2025

Fix mdbook build error preventing deploys #307

Open

Niko Matsakis added 3 commits May 22, 2025 19:04

author unit tests and fix a bug that was found

8879b3c

say 'start of' to 'end of'

2443714

additional test

4308c37

lqd reviewed May 23, 2025

View reviewed changes


		Many of the tasks in `src/admin` are automated via a utility called `cargo rpg`.

		The sources for `cargo rpg` as well as the plugin for the mdbook processor are found in crates located in the `crates` directory. The `crates/README.md` summarizes the role of each crate.

	The next goal period will be {}, running from {} 1 to {} 30. \
	The next goal period will be {}, running from the start of {} to the end of {}. \

	assert!(result.contains("running from January 1 to June 30"));
	assert!(result.contains("running from the start of January to the end of June"));

		let _year = &timeframe[0..4];
		let half = &timeframe[4..].to_lowercase();

	let result = process_summary_content(content, "2026h1", "2026h1");
	let result = process_summary_content(content, "2026H1", "2026h1");

automate the launch of a new cfp with the cfp command #309

Are you sure you want to change the base?

automate the launch of a new cfp with the cfp command #309

Uh oh!

Conversation

nikomatsakis commented May 21, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lqd commented May 21, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nikomatsakis commented May 21, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lqd May 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nikomatsakis commented May 22, 2025

Uh oh!

lqd left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lqd May 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nikomatsakis commented May 21, 2025 •

edited by rustbot

Loading

lqd May 22, 2025 •

edited

Loading

lqd left a comment •

edited

Loading

lqd May 23, 2025 •

edited

Loading