Actually normalize twice in mir validator typechecker #101436
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 96d4137. The outer normalization is needed because it hasn't erased late bound lifetimes yet which is required for some normalizations.
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
|
Hm, @Nilstrieb, I thought I mentioned I was going to put up a different version of this where we correctly normalize before erasing late-bound regions in |
|
oh i got confused by the double negation of the message, haha well i can close it then |
|
Whoops, sorry. I apologize if you wasted time on this. Still working on a minimization, but all of the examples of this ICE are incredibly complicated. |
|
no problem, I didn't have anything better to do anyways :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #100121, I removed the double normalization in the mir validator. It turns out that this outer normalization is still needed because the inner normalization erases all regions - even late bound ones that may be required for normalization sometimes.
This still needs an MCVE as a test.
Hopefully fixes #101344
r? @compiler-errors