Rollup of 5 pull requests #102358
Closed
Rollup of 5 pull requests #102358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LLVM 15 added `Optional::has_value`, and LLVM `main` (16) has deprecated `hasValue`. However, its `explicit operator bool` does the same thing, and was added long ago, so we can use that across our full LLVM range of compatibility.
In rust-lang#101230, the internal diagnostic migration lints - `diagnostic_outside_of_impl` and `untranslatable_diagnostic` - were modified so that they wouldn't trigger on functions annotated with `#[rustc_lint_diagnostics]`. However, this change has to make it into the bootstrap compiler before the `#[allow]` annotations that it aims to remove can be removed, which is possible now that rust-lang#102051 has landed. Signed-off-by: David Wood <[email protected]>
…s, r=joshtriplett Stabilize `#![feature(mixed_integer_ops)]` Tracked and FCP completed in rust-lang#87840. `@rustbot` label +T-libs-api +S-waiting-on-review +relnotes r? rust-lang/t-libs-api
…=TaKO8Ki Stabilize bench_black_box This PR stabilize `feature(bench_black_box)`. ```rust pub fn black_box<T>(dummy: T) -> T; ``` The FCP was completed in rust-lang#64102. `@rustbot` label +T-libs-api -T-libs
…w-ptr, r=davidtwco Structured suggestion for missing `mut`/`const` in raw pointer Fixes rust-lang#102261
Avoid LLVM-deprecated `Optional::hasValue` LLVM 15 added `Optional::has_value`, and LLVM `main` (16) has deprecated `hasValue`. However, its `explicit operator bool` does the same thing, and was added long ago, so we can use that across our full LLVM range of compatibility.
…mp-allow-lint, r=lcnr session: remove now-unnecessary lint `#[allow]`s In rust-lang#101230, the internal diagnostic migration lints - `diagnostic_outside_of_impl` and `untranslatable_diagnostic` - were modified so that they wouldn't trigger on functions annotated with `#[rustc_lint_diagnostics]`. However, this change has to make it into the bootstrap compiler before the `#[allow]` annotations that it aims to remove can be removed, which is possible now that rust-lang#102051 has landed.
rustbot
added
T-compiler
|
@bors r+ rollup=never p=5 |
bors
added
the
S-waiting-on-bors
|
⌛ Testing commit 6c983f6 with merge 724d9fa129bf7b3e179cf1ef3d7c12c4a6b8d04f... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
cuviper
reviewed
Sep 27, 2022
| @@ -7,8 +7,6 @@ | |||
| // error-pattern: AddressSanitizer: stack-buffer-overflow | |||
| // error-pattern: 'xs' (line 15) <== Memory access at offset | |||
There was a problem hiding this comment.
Two lines were removed:
Suggested change
| // error-pattern: 'xs' (line 15) <== Memory access at offset | |
| // error-pattern: 'xs' (line 13) <== Memory access at offset |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
#![feature(mixed_integer_ops)]#101555 (Stabilize#![feature(mixed_integer_ops)])mut/constin raw pointer #102284 (Structured suggestion for missingmut/constin raw pointer)Optional::hasValue#102337 (Avoid LLVM-deprecatedOptional::hasValue)#[allow]s #102356 (session: remove now-unnecessary lint#[allow]s)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup