update overflow handling in the new trait solver #114287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
☔ The latest upstream changes (presumably #114294) made this pull request unmergeable. Please resolve the merge conflicts. |
lcnr
force-pushed
the
overflow
branch
2 times, most recently
from
130923f to
35ea173
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
lcnr
commented
Aug 1, 2023
lcnr
commented
Aug 1, 2023
lcnr
commented
Aug 1, 2023
lcnr
commented
Aug 1, 2023
lcnr
commented
Aug 3, 2023
| // FIXME(-Ztrait-solver=next): THis currently results in unstable query results: | ||
| // `normalizes-to(opaque, opaque)` changes from `Maybe(Ambiguous)` to `Maybe(Overflow)` | ||
| // once the hidden type of the opaque is already defined to be itself. | ||
|
|
There was a problem hiding this comment.
I looked at this for a bit and I think that we should look into preventing opaques in their defining scope to opaques in their defining scope. Not exactly sure how this should work though. Feels like a complex issue so I've avoided it for now.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
we previously had incorrect universes in the query response.
lcnr
force-pushed
the
overflow
branch
3 times, most recently
from
57f0ce2 to
897ab17
Compare
This comment has been minimized.
This comment has been minimized.
|
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
This was referenced Aug 4, 2023
compiler-errors
approved these changes
Aug 4, 2023
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 5, 2023
…mpiler-errors Rollup of 5 pull requests Successful merges: - rust-lang#114287 (update overflow handling in the new trait solver) - rust-lang#114475 (Migrate GUI colors test to original CSS color format) - rust-lang#114482 (Fix ui-fulldeps missing the `internal_features` lint on stage 0) - rust-lang#114490 (Fix a typo in the error reporting for sealed traits.) - rust-lang#114491 (Rename issue rust-lang#114423 test files to include context) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements https://hackmd.io/QY0dfEOgSNWwU4oiGnVRLw?view. I want to clean up this doc and add it to the rustc-dev-guide, but I think this PR is ready for merge as is, even without the dev-guide entry.
r? @compiler-errors