Record impl args in the proof tree#124718
Merged
bors merged 1 commit intorust-lang:masterfrom May 4, 2024
Merged
Conversation
Collaborator
|
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
rustbot
added
S-waiting-on-review
compiler-errors
commented
May 4, 2024
| --> $DIR/point-at-failing-nested.rs:22:17 | ||
| | | ||
| LL | needs_foo::<()>(); | ||
| | ^^ the trait `Bar` is not implemented for `()`, which is required by `(): Foo` |
Contributor
Author
There was a problem hiding this comment.
This used to say:
the trait
Sizedis not implemented for()
which is obviously incorrect, but due to ?0: Sized being a nested goal.
This wouldve been fixed by #124690, but then we wouldn't be reporting a nested goal as the failure cause at all.
Contributor
|
r=me after CI |
Contributor
Author
|
@bors r=lcnr rollup |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 4, 2024
…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#124501 (add support to override lldb binary path for ./x test) - rust-lang#124573 (add a reference link to the comment of the "cc" and "cmake".) - rust-lang#124663 (Enable reusing CI Docker cache when running CI images locally) - rust-lang#124690 (Only consider ambiguous goals when finding best obligation for ambiguities) - rust-lang#124713 (Update Cargo specific diagnostics in check-cfg) - rust-lang#124717 (Implement `do_not_recommend` in the new solver) - rust-lang#124718 (Record impl args in the proof tree) - rust-lang#124720 (interpret: Drop: always evaluate place) - rust-lang#124721 (library/std: Fix build for NetBSD targets with 32-bit `c_long`) - rust-lang#124723 (Use correct Hermit links in The `rustc` Book) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 4, 2024
Rollup merge of rust-lang#124718 - compiler-errors:record-impl-args, r=lcnr Record impl args in the proof tree Weren't recording these since they went through a different infcx method r? lcnr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Weren't recording these since they went through a different infcx method
r? lcnr