[IGNORE] Tidy up dump-ice-to-disk and make assertion failures dump ICE messages#128960
Closed
jieyouxu wants to merge 1 commit intorust-lang:masterfrom
Closed
[IGNORE] Tidy up dump-ice-to-disk and make assertion failures dump ICE messages#128960jieyouxu wants to merge 1 commit intorust-lang:masterfrom
dump-ice-to-disk and make assertion failures dump ICE messages#128960jieyouxu wants to merge 1 commit intorust-lang:masterfrom
Conversation
rustbot
added
A-run-make
Member
Author
|
... bors must be really confused by the draft PR that I'm running to test separately... |
jieyouxu
changed the title
dump-ice-to-disk and make assertion failures dump ICE messagesdump-ice-to-disk and make assertion failures dump ICE messages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same PR as #128916 but the other one was cursed.
For the future traveler: if you did a
git blameand found this PR that last modifieddump-ice-to-diskbecause the test failed in a completely unrelated PR, then I'm afraid our ICE dump regressed.A bit of clean up to the
dump-ice-to-disktest.tests/run-make/dump-ice-to-diskis flakey on i686-mingw #128911 for flakiness.rustc-ice*.txtdumps, run each test instance in a separate temp directory.RUSTC_ICEunavailable in one of the-Zmetrics-dirtest case to not have interference from environment.tests/run-make/dump-ice-to-diskis flakey on i686-mingw #128911).Contains a fix by @saethlin in #128909, should wait until that is merged then rebase on top.
r? @compiler-errors (since you reviewed #128916)