Rollup of 7 pull requests #129615

matthiaskrgr · 2024-08-26T15:25:35Z

Successful merges:

Add f16 and f128 to tests/ui/consts/const-float-bits-conv.rs #129190 (Add f16 and f128 to tests/ui/consts/const-float-bits-conv.rs)
Add implementations for unbounded_shl/unbounded_shr #129377 (Add implementations for unbounded_shl/unbounded_shr)
link to Future::poll from the Poll docs #129539 (link to Future::poll from the Poll docs)
pal/hermit: correctly round up microseconds in Thread::sleep #129588 (pal/hermit: correctly round up microseconds in Thread::sleep)
Remove cfg(test) from library/core #129592 (Remove cfg(test) from library/core)
mv build_reduced_graph_for_external_crate_res into Resolver #129597 (mv build_reduced_graph_for_external_crate_res into Resolver)
Tie impl_trait_overcaptures lint to Rust 2024 #129600 (Tie impl_trait_overcaptures lint to Rust 2024)

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

…ting

…nded_shr`/`unbounded_shl`

…c_allow_const_fn_unstable`

The most important thing about Poll is that Future::poll returns it, but previously the docs didn't emphasize this.

Signed-off-by: Martin Kröning <[email protected]>

The `impl_trait_overcaptures` lint is part of the migration to Rust 2024 and the Lifetime Capture Rules 2024. Now that we've stabilized precise capturing (RFC 3617), let's tie this lint to the `rust_2024_compatibility` lint group.

Add f16 and f128 to tests/ui/consts/const-float-bits-conv.rs Fixes rust-lang#129163 try-job: x86_64-msvc try-job: x86_64-mingw try-job: i686-msvc try-job: i686-mingw

… r=scottmcm Add implementations for `unbounded_shl`/`unbounded_shr` Tracking Issue: rust-lang#129375 This implements `unbounded_shl` and `unbounded_shr` under the feature gate `unbounded_shifts`

link to Future::poll from the Poll docs The most important thing about Poll is that Future::poll returns it, but previously the docs didn't emphasize this.

…ubilee pal/hermit: correctly round up microseconds in `Thread::sleep` This fixes the Hermit-related part of rust-lang#129212 and thus the whole issue, since ESP-IDF is already fixed, as far as I understand. Fixes rust-lang#129212 r? `@workingjubilee` CC: `@stlankes`

Remove cfg(test) from library/core The diff here is very small with the ignore whitespace option. `core` doesn't/can't have unit tests. All of its tests are just modules under `tests/`, so it has no use for `cfg(test)`, because the entire contents of `library/core/src` are only ever compiled with that cfg off, and the entire contents of `library/core/tests` are only ever compiled with that cfg on. You can tell this is what's happening because we had `#[cfg(test)]` on a module declaration that has no source file. I also deleted the extra `mod tests {` layer of nesting; there's no need to mention again in the module path that this is a module of tests. This exposes a name collision between the `u128` module of tests and `core::u128`. Fixed that by using `<u128>::MAX` like is done in the `check!` macro, which is what avoids this name ambiguity for the other types.

mv `build_reduced_graph_for_external_crate_res` into Resolver `build_reduced_graph_for_external_crate_res` is only related to `Resolver`, so move it there. r? `@petrochenkov`

…captures-to-rust-2024, r=compiler-errors Tie `impl_trait_overcaptures` lint to Rust 2024 The `impl_trait_overcaptures` lint is part of the migration to Rust 2024 and the Lifetime Capture Rules 2024. Now that we've stabilized precise capturing (RFC 3617), let's tie this lint to the `rust_2024_compatibility` lint group. Tracking: - rust-lang#117587 r? `@compiler-errors`

matthiaskrgr · 2024-08-26T15:26:04Z

@bors r+ rollup=never p=7

bors · 2024-08-26T15:26:07Z

📌 Commit 114e60f has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2024-08-26T16:50:03Z

⌛ Testing commit 114e60f with merge 0fccd9d...

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#129190 (Add f16 and f128 to tests/ui/consts/const-float-bits-conv.rs) - rust-lang#129377 (Add implementations for `unbounded_shl`/`unbounded_shr`) - rust-lang#129539 (link to Future::poll from the Poll docs) - rust-lang#129588 (pal/hermit: correctly round up microseconds in `Thread::sleep`) - rust-lang#129592 (Remove cfg(test) from library/core) - rust-lang#129597 (mv `build_reduced_graph_for_external_crate_res` into Resolver) - rust-lang#129600 (Tie `impl_trait_overcaptures` lint to Rust 2024) r? `@ghost` `@rustbot` modify labels: rollup

rust-log-analyzer · 2024-08-26T18:26:36Z

The job x86_64-msvc-ext failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[RUSTC-TIMING] miri test:false 4.729
error: failed to remove file `C:\a\rust\rust\build\x86_64-pc-windows-msvc\stage1-tools\x86_64-pc-windows-msvc\release\miri.exe`

Caused by:
  Access is denied. (os error 5)
Command has failed. Rerun with -v to see more details.
  local time: Mon, Aug 26, 2024  6:26:20 PM
  network time: Mon, 26 Aug 2024 18:26:21 GMT
##[error]Process completed with exit code 1.
Post job cleanup.

bors · 2024-08-26T18:27:12Z

💔 Test failed - checks-actions

matthiaskrgr · 2024-08-26T18:31:01Z

@bors retry

bors · 2024-08-26T20:04:38Z

⌛ Testing commit 114e60f with merge 515395a...

bors · 2024-08-26T22:37:53Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 515395a to master...

rust-timer · 2024-08-26T22:39:52Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#129190	Add f16 and f128 to tests/ui/consts/const-float-bits-conv.rs	`011e2d152feeaefcd1e9dfd457d1f0ac0b5a51fb` (link)
#129377	Add implementations for `unbounded_shl`/`unbounded_shr`	`c7c44bbd8a5922fa8049f9904ef007278c902756` (link)
#129539	link to Future::poll from the Poll docs	`3922fce21dfc1be32862fe22646d1c917d37ede2` (link)
#129588	pal/hermit: correctly round up microseconds in `Thread::sle…	`f3812bd43e7d253543347f05ec279ce64222a177` (link)
#129592	Remove cfg(test) from library/core	`73636f51b9cb2681fe24c3808631fa4f5b2e4e78` (link)
#129597	mv `build_reduced_graph_for_external_crate_res` into Resolv…	`37a43e743d0c501b52f564218736354bcd459a04` (link)
#129600	Tie `impl_trait_overcaptures` lint to Rust 2024	`50831b433805987131f095b27b9443714d044b8c` (link)

previous master: 22572d0994

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2024-08-26T23:52:38Z

Finished benchmarking commit (515395a): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -2.2%, secondary 1.6%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	5.3%	[5.3%, 5.3%]	1
Improvements ✅ (primary)	-2.2%	[-2.2%, -2.2%]	1
Improvements ✅ (secondary)	-2.0%	[-2.0%, -2.0%]	1
All ❌✅ (primary)	-2.2%	[-2.2%, -2.2%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 752.172s -> 749.753s (-0.32%)
Artifact size: 338.71 MiB -> 338.77 MiB (0.02%)

rezwanahmedsami and others added 23 commits August 18, 2024 01:11

Add f16 and f128 to tests/ui/consts/const-float-bits-conv.rs

803cbaf

Added #[cfg(target_arch = x86_64)] to f16 and f128

9f39427

feat(core): Add implementations for unbounded_shl/unbounded_shr

9b5a004

Manually format functions and use rhs instead of v from my CE tes…

c89bae0

…ting

chore: Also format the control flow

38b5a2a

chore: x fmt and hopefully fix the tidy issue

79cbb87

fix(core): Add #![feature(unbounded_shifts)] to doctests for `unbou…

9907f61

…nded_shr`/`unbounded_shl`

chore: x fmt

27b63b8

fix(core): Use correct operations/values in unbounded_shr doctests

2cf48ea

feat(core): Make unbounded_shl{l,r} unstably const and remove `rust…

f4dc783

…c_allow_const_fn_unstable`

link to Future::poll from the Poll docs

3153b7d

The most important thing about Poll is that Future::poll returns it, but previously the docs didn't emphasize this.

pal/hermit: correctly round up microseconds in Thread::sleep

687c8a1

Signed-off-by: Martin Kröning <[email protected]>

pal/hermit: saturate usleep microseconds at u64::MAX

edeefc5

Signed-off-by: Martin Kröning <[email protected]>

Remove cfg(test) from library/core

4f3ef2a

mv build_reduced_graph_for_external_crate_res into Resolver

c31b9fa

Tie impl_trait_overcaptures lint to Rust 2024

6982785

The `impl_trait_overcaptures` lint is part of the migration to Rust 2024 and the Lifetime Capture Rules 2024. Now that we've stabilized precise capturing (RFC 3617), let's tie this lint to the `rust_2024_compatibility` lint group.

Rollup merge of rust-lang#129190 - rezwanahmedsami:master, r=tgross35

dedfb35

Add f16 and f128 to tests/ui/consts/const-float-bits-conv.rs Fixes rust-lang#129163 try-job: x86_64-msvc try-job: x86_64-mingw try-job: i686-msvc try-job: i686-mingw

Rollup merge of rust-lang#129377 - chorman0773:unbounded-shifts-impl,…

68aff29

… r=scottmcm Add implementations for `unbounded_shl`/`unbounded_shr` Tracking Issue: rust-lang#129375 This implements `unbounded_shl` and `unbounded_shr` under the feature gate `unbounded_shifts`

Rollup merge of rust-lang#129539 - oconnor663:poll_link, r=tgross35

b1c9064

link to Future::poll from the Poll docs The most important thing about Poll is that Future::poll returns it, but previously the docs didn't emphasize this.

Rollup merge of rust-lang#129597 - bvanjoi:resolve, r=petrochenkov

1d58ac0

mv `build_reduced_graph_for_external_crate_res` into Resolver `build_reduced_graph_for_external_crate_res` is only related to `Resolver`, so move it there. r? `@petrochenkov`

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 26, 2024

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 26, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 26, 2024

bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 26, 2024

bors merged commit 515395a into rust-lang:master Aug 26, 2024
7 checks passed

rustbot added this to the 1.82.0 milestone Aug 26, 2024

matthiaskrgr deleted the rollup-lw733x7 branch September 1, 2024 17:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 7 pull requests #129615

Rollup of 7 pull requests #129615

Uh oh!

matthiaskrgr commented Aug 26, 2024

Uh oh!

matthiaskrgr commented Aug 26, 2024

Uh oh!

bors commented Aug 26, 2024

Uh oh!

bors commented Aug 26, 2024

Uh oh!

rust-log-analyzer commented Aug 26, 2024

Uh oh!

bors commented Aug 26, 2024

Uh oh!

matthiaskrgr commented Aug 26, 2024

Uh oh!

bors commented Aug 26, 2024

Uh oh!

bors commented Aug 26, 2024

Uh oh!

Uh oh!

rust-timer commented Aug 26, 2024

Uh oh!

rust-timer commented Aug 26, 2024

Uh oh!

Uh oh!

Rollup of 7 pull requests #129615

Rollup of 7 pull requests #129615

Uh oh!

Conversation

matthiaskrgr commented Aug 26, 2024

Uh oh!

matthiaskrgr commented Aug 26, 2024

Uh oh!

bors commented Aug 26, 2024

Uh oh!

bors commented Aug 26, 2024

Uh oh!

rust-log-analyzer commented Aug 26, 2024

Uh oh!

bors commented Aug 26, 2024

Uh oh!

matthiaskrgr commented Aug 26, 2024

Uh oh!

bors commented Aug 26, 2024

Uh oh!

bors commented Aug 26, 2024

Uh oh!

Uh oh!

rust-timer commented Aug 26, 2024

Uh oh!

rust-timer commented Aug 26, 2024

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Uh oh!