triagebot: automatically add more rustdoc related labels by lolbinarycat · Pull Request #133312 · rust-lang/rust

lolbinarycat · 2024-11-21T22:03:15Z

apiraino · 2024-11-22T08:53:32Z

cc'ing @rust-lang/rustdoc

GuillaumeGomez · 2024-11-22T09:15:41Z

triagebot.toml

    "src/tools/jsondoclint",
 ]

+[autolabel."T-rustdoc-frontend"]


Shouldn't there be trigger_files here too?

I think this is fine because it will transitively trigger due to the A-* labels themselves getting triggered on files. I.e. this T-rustdoc-frontend label triggers on A-rustdoc-search but A-rustdoc-search triggers on a set of paths.

... or so I hope triagebot does (transitive trigger files)...

I think it's not great to rely on transitive triggers, especially when we remove a "parent". Then children won't trigger it anymore and we'll only discover it anymore. Would be nice if we could say that a label depends on another directly.

Yeah, probably safer to duplicate the relevant path filters here. Also btw, you can just edit this PR locally to add the path filters you want :)

I know but since I'm not the owner here, I'll wait for them to update. If they don't want to, I can always send a follow-up.

My biggest concern is that T-rustdoc and T-rustdoc-frontend are mutually exclusive, and the paths that would trigger the frontend label are in dirs that trigger the T-rustdoc label.

i'm not sure if the longer path would take precedent, or if it would depend on hashmap ordering, or what

I thought they would all be triggered...

oh, that's an option i hadn't considered, adding both T-rustdoc and T-rustdoc-frontend, even though they're supposed to be mutually exclusive...

hmm... i suppose it's unlikely to be anything destructive, so if it does cause an issue, it should be pretty easy to fix...

after reading through the relevant code, it appears that all autolabel rules apply simultaneously, so it would indeed add both. I'll add the trigger_files

GuillaumeGomez · 2024-11-22T09:16:10Z

Since it's something impacting the whole team, let's cc them too.

cc @rust-lang/rustdoc

jieyouxu · 2024-11-22T10:07:06Z

r? @GuillaumeGomez (this affects rustdoc)

fmease · 2024-11-22T10:13:35Z

No objections

aDotInTheVoid · 2024-11-22T10:39:09Z

No objections from me, thanks!

GuillaumeGomez · 2024-11-22T10:39:58Z

Ok. Just waiting for an answer to my question then I'll approve it. Thanks everyone!

lolbinarycat · 2024-11-24T19:17:09Z

after reading through the source code to ensure it wouldn't produce undesired behavior, i added a trigger_files list for T-rustdoc-frontend.

bors · 2025-02-07T17:00:54Z

☔ The latest upstream changes (presumably #136684) made this pull request unmergeable. Please resolve the merge conflicts.

lolbinarycat · 2025-02-08T21:49:19Z

@GuillaumeGomez has your question been answered? will you merge this after rebase?

GuillaumeGomez · 2025-02-10T09:28:00Z

Yes, seems good to me.

lolbinarycat · 2025-02-13T19:00:01Z

@GuillaumeGomez rebased

GuillaumeGomez · 2025-02-14T12:50:25Z

Thanks!

Let's give it a try then.

@bors r+ rollup

bors · 2025-02-14T12:50:28Z

📌 Commit cc74ed0 has been approved by GuillaumeGomez

It is now in the queue for this repository.

…els, r=GuillaumeGomez triagebot: automatically add more rustdoc related labels [inspired by zulip discussion](https://rust-lang.zulipchat.com/#narrow/channel/242269-t-release.2Ftriage/topic/auto-adding.20team.20labels.20based.20on.20certain.20other.20labels)

Rollup of 11 pull requests Successful merges: - rust-lang#133312 (triagebot: automatically add more rustdoc related labels) - rust-lang#134016 (Stabilize `const_is_char_boundary` and `const_str_split_at`.) - rust-lang#135813 (CI: split i686-mingw job to three free runners) - rust-lang#136879 (Add safe new() to NotAllOnes) - rust-lang#136971 (Add a new check-pass UI test for returning `impl Fn(T) -> impl Trait`) - rust-lang#136983 (Prepare standard library for Rust 2024 migration) - rust-lang#137002 (Fix early lint check desc in query) - rust-lang#137006 (borrowck diagnostics cleanup: remove an unused and a barely-used field) - rust-lang#137026 (Stabilize (and const-stabilize) `integer_sign_cast`) - rust-lang#137028 (mir_build: Clarify some code for lowering `hir::PatExpr` to THIR) - rust-lang#137032 (Decode metadata buffer in one go) r? `@ghost` `@rustbot` modify labels: rollup

…kingjubilee Rollup of 10 pull requests Successful merges: - rust-lang#133312 (triagebot: automatically add more rustdoc related labels) - rust-lang#134016 (Stabilize `const_is_char_boundary` and `const_str_split_at`.) - rust-lang#136971 (Add a new check-pass UI test for returning `impl Fn(T) -> impl Trait`) - rust-lang#136983 (Prepare standard library for Rust 2024 migration) - rust-lang#137002 (Fix early lint check desc in query) - rust-lang#137006 (borrowck diagnostics cleanup: remove an unused and a barely-used field) - rust-lang#137032 (Decode metadata buffer in one go) - rust-lang#137035 (Normalize closure instance before eagerly monomorphizing it) - rust-lang#137037 (add x86-sse2 (32bit) ABI that requires SSE2 target feature) - rust-lang#137038 (llvm: Tolerate captures in tests) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#133312 - lolbinarycat:triagebot-rustdoc-labels, r=GuillaumeGomez triagebot: automatically add more rustdoc related labels [inspired by zulip discussion](https://rust-lang.zulipchat.com/#narrow/channel/242269-t-release.2Ftriage/topic/auto-adding.20team.20labels.20based.20on.20certain.20other.20labels)

rustbot assigned Mark-Simulacrum Nov 21, 2024

This comment was marked as off-topic.

Sign in to view

rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 21, 2024

This comment was marked as off-topic.

Sign in to view

GuillaumeGomez reviewed Nov 22, 2024

View reviewed changes

rustbot assigned GuillaumeGomez and unassigned Mark-Simulacrum Nov 22, 2024

jieyouxu added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Nov 22, 2024

triagebot: automatically add more rustdoc related labels

cc74ed0

lolbinarycat force-pushed the triagebot-rustdoc-labels branch from 7052ca5 to cc74ed0 Compare February 13, 2025 18:17

GuillaumeGomez approved these changes Feb 14, 2025

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 14, 2025

jhpratt mentioned this pull request Feb 14, 2025

Rollup of 11 pull requests #137040

Closed

workingjubilee mentioned this pull request Feb 14, 2025

Rollup of 10 pull requests #137046

Merged

bors merged commit 17ad8b5 into rust-lang:master Feb 15, 2025
6 checks passed

rustbot added this to the 1.86.0 milestone Feb 15, 2025

lolbinarycat mentioned this pull request Feb 15, 2025

triagebot autolabel: document interaction between trigger_* and exclude_labels rust-lang/rust-forge#809

Open

Uh oh!

Conversation

lolbinarycat commented Nov 21, 2024

Uh oh!

This comment was marked as off-topic.

This comment was marked as off-topic.

apiraino commented Nov 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

GuillaumeGomez Nov 22, 2024

Choose a reason for hiding this comment

Uh oh!

jieyouxu Nov 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

GuillaumeGomez Nov 22, 2024

Choose a reason for hiding this comment

Uh oh!

jieyouxu Nov 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

GuillaumeGomez Nov 22, 2024

Choose a reason for hiding this comment

Uh oh!

lolbinarycat Nov 22, 2024

Choose a reason for hiding this comment

Uh oh!

GuillaumeGomez Nov 22, 2024

Choose a reason for hiding this comment

Uh oh!

lolbinarycat Nov 24, 2024

Choose a reason for hiding this comment

Uh oh!

lolbinarycat Nov 24, 2024

Choose a reason for hiding this comment

Uh oh!

GuillaumeGomez commented Nov 22, 2024

Uh oh!

jieyouxu commented Nov 22, 2024

Uh oh!

fmease commented Nov 22, 2024

Uh oh!

aDotInTheVoid commented Nov 22, 2024

Uh oh!

GuillaumeGomez commented Nov 22, 2024

Uh oh!

lolbinarycat commented Nov 24, 2024

Uh oh!

bors commented Feb 7, 2025

Uh oh!

lolbinarycat commented Feb 8, 2025

Uh oh!

GuillaumeGomez commented Feb 10, 2025

Uh oh!

lolbinarycat commented Feb 13, 2025

Uh oh!

GuillaumeGomez commented Feb 14, 2025

Uh oh!

bors commented Feb 14, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

apiraino commented Nov 22, 2024 •

edited

Loading

jieyouxu Nov 22, 2024 •

edited

Loading

jieyouxu Nov 22, 2024 •

edited

Loading