Rollup of 11 pull requests

[TaKO8Ki]

Successful merges:

• privacy: Visit types and traits in impls in type privacy lints #138317 (privacy: Visit types and traits in impls in type privacy lints)
• Keyword tweaks #138385 (Keyword tweaks)
• resolve: Avoid some unstable iteration 2 #138580 (resolve: Avoid some unstable iteration 2)
• Reintroduce remote-test support in run-make tests #138652 (Reintroduce remote-test support in run-make tests)
• Make default_codegen_backend serializable #138701 (Make default_codegen_backend serializable)
• [rustdoc] Remove duplicated loop when computing doc cfgs #138755 ([rustdoc] Remove duplicated loop when computing doc cfgs)
• Slightly reword triagebot ping message for relnotes-interest-group #138829 (Slightly reword triagebot ping message for relnotes-interest-group)
• resolve: Avoid remaining unstable iteration #138837 (resolve: Avoid remaining unstable iteration)
• Fix/tweak some tests in new solver #138838 (Fix/tweak some tests in new solver)
• Ignore doctests only in specified targets #138877 (Ignore doctests only in specified targets)
• Add a helper for building an owner id in ast lowering #138895 (Add a helper for building an owner id in ast lowering)

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

[TaKO8Ki]

@bors r+ rollup=never p=5

[bors]

📌 Commit 39a2b4b has been approved by TaKO8Ki

It is now in the queue for this repository.

[rust-log-analyzer]

The job x86_64-gnu-llvm-18 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

#19 exporting to docker image format
#19 sending tarball 19.7s done
#19 DONE 24.8s
##[endgroup]
Setting extra environment values for docker:  --env ENABLE_GCC_CODEGEN=1 --env GCC_EXEC_PREFIX=/usr/lib/gcc/
[CI_JOB_NAME=x86_64-gnu-llvm-18]
[CI_JOB_NAME=x86_64-gnu-llvm-18]
debug: `DISABLE_CI_RUSTC_IF_INCOMPATIBLE` configured.
---
sccache: Listening on address 127.0.0.1:4226
##[group]Configure the build
configure: processing command line
configure: 
configure: build.configure-args := ['--build=x86_64-unknown-linux-gnu', '--llvm-root=/usr/lib/llvm-18', '--enable-llvm-link-shared', '--set', 'rust.randomize-layout=true', '--set', 'rust.thin-lto-import-instr-limit=10', '--set', 'build.print-step-timings', '--enable-verbose-tests', '--set', 'build.metrics', '--enable-verbose-configure', '--enable-sccache', '--disable-manage-submodules', '--enable-locked-deps', '--enable-cargo-native-static', '--set', 'rust.codegen-units-std=1', '--set', 'dist.compression-profile=balanced', '--dist-compression-formats=xz', '--set', 'rust.lld=false', '--disable-dist-src', '--release-channel=nightly', '--enable-debug-assertions', '--enable-overflow-checks', '--enable-llvm-assertions', '--set', 'rust.verify-llvm-ir', '--set', 'rust.codegen-backends=llvm,cranelift,gcc', '--set', 'llvm.static-libstdcpp', '--enable-new-symbol-mangling']
configure: build.build          := x86_64-unknown-linux-gnu
configure: target.x86_64-unknown-linux-gnu.llvm-config := /usr/lib/llvm-18/bin/llvm-config
configure: llvm.link-shared     := True
configure: rust.randomize-layout := True
configure: rust.thin-lto-import-instr-limit := 10

[TaKO8Ki]

The error doesn't seem to be related to the pull request. @bors retry

[compiler-errors]

2025-03-24T23:07:15.5191676Z �[0m�[1m�[38;5;9merror�[0m�[0m�[1m: unused `ControlFlow` that must be used�[0m
2025-03-24T23:07:15.5193199Z �[0m    �[0m�[0m�[1m�[38;5;12m--> �[0m�[0mcompiler/rustc_privacy/src/lib.rs:1409:13�[0m
2025-03-24T23:07:15.5196168Z �[0m     �[0m�[0m�[1m�[38;5;12m|�[0m
2025-03-24T23:07:15.5197018Z �[0m�[1m�[38;5;12m1409�[0m�[0m �[0m�[0m�[1m�[38;5;12m|�[0m�[0m �[0m�[0m            self.visit_trait(trait_ref.instantiate_identity());�[0m
2025-03-24T23:07:15.5198562Z �[0m     �[0m�[0m�[1m�[38;5;12m|�[0m�[0m             �[0m�[0m�[1m�[38;5;9m^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^�[0m
2025-03-24T23:07:15.5199172Z �[0m     �[0m�[0m�[1m�[38;5;12m|�[0m
2025-03-24T23:07:15.5199862Z �[0m     �[0m�[0m�[1m�[38;5;12m= �[0m�[0m�[1mnote�[0m�[0m: `-D unused-must-use` implied by `-D warnings`�[0m
2025-03-24T23:07:15.5200777Z �[0m     �[0m�[0m�[1m�[38;5;12m= �[0m�[0m�[1mhelp�[0m�[0m: to override `-D warnings` add `#[allow(unused_must_use)]`�[0m
2025-03-24T23:07:15.5201639Z �[0m�[1m�[38;5;14mhelp�[0m�[0m: use `let _ = ...` to ignore the resulting value�[0m
2025-03-24T23:07:15.5202216Z �[0m     �[0m�[0m�[1m�[38;5;12m|�[0m
2025-03-24T23:07:15.5203060Z �[0m�[1m�[38;5;12m1409�[0m�[0m �[0m�[0m�[1m�[38;5;12m| �[0m�[0m            �[0m�[0m�[38;5;10mlet _ = �[0m�[0mself.visit_trait(trait_ref.instantiate_identity());�[0m
2025-03-24T23:07:15.5203908Z �[0m     �[0m�[0m�[1m�[38;5;12m|�[0m�[0m             �[0m�[0m�[38;5;10m+++++++�[0m

This is a legitimate failure. Please read the full logs, sometimes you need to scroll all the way to the bottom to find the failure.

@bors r-

[TaKO8Ki]

@compiler-errors Oops I was reading it at the same time.