increment depth of nested obligations #139022

lcnr · 2025-03-27T15:28:05Z

properly fixes the root cause of #109268. While we didn't get hangs here before, I ended up encountering its root cause again with #138785.

r? types

lcnr · 2025-03-27T15:28:15Z

@bors try @rust-timer queue

increment depth of nested obligations properly fixes the root cause of rust-lang#109268. While we didn't get hangs here before, I ended up encountering its root cause again with rust-lang#138785. r? types

bors · 2025-03-27T15:29:27Z

⌛ Trying commit d45d9ae with merge d8a5ee0...

bors · 2025-03-27T17:35:25Z

☀️ Try build successful - checks-actions
Build commit: d8a5ee0 (d8a5ee01b913730aca7ab44c72c8f2722c0533ff)

compiler-errors · 2025-03-27T18:07:53Z

Let's crater this too? Just in case.

@craterbot check

craterbot · 2025-03-27T18:08:08Z

👌 Experiment pr-139022 created and queued.
🤖 Automatically detected try build d8a5ee0
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

rust-timer · 2025-03-27T18:52:18Z

Finished benchmarking commit (d8a5ee0): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (primary -0.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.5%	[-0.5%, -0.5%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.5%	[-0.5%, -0.5%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 779.46s -> 778.399s (-0.14%)
Artifact size: 365.95 MiB -> 365.94 MiB (-0.00%)

craterbot · 2025-03-27T22:12:32Z

🚧 Experiment pr-139022 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2025-03-28T20:06:02Z

🎉 Experiment pr-139022 is completed!
📊 3 regressed and 9 fixed (604742 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

lcnr · 2025-03-31T12:27:39Z

https://github.com/WillPapper/zkvm-uuid-generation ICEs while compiling with previous nighties. This already ICEs on nightly, so this PR does not seem to cause any regressions.

The failing project is relying on jolt a nightly only crate and may depend on feature(generic_const_exprs) somewhere 😅 unsure about that. Going to just entirely ignore it for now.

@rustbot ready

compiler/rustc_trait_selection/src/traits/fulfill.rs

lcnr · 2025-03-31T17:52:01Z

removed all update depth calls except

when adding nested obligations in fulfill (using the depth of the parent obligation)
evaluating nested obligations in evaluate (using the depth of a parent Trait obligation)
recursing into nested obligations of Projection goals in evaluate
- these can recur without ever going through a Trait obligation, so we need to handle them separately

We still rely on WF providing the correct depth for its nested obligations as wf can also diverge without ever going through a Trait obligation.

oli-obk · 2025-03-31T18:52:42Z

r=me after rebase

lcnr · 2025-03-31T21:58:41Z

@bors r=oli-obk rollup

bors · 2025-03-31T21:58:44Z

📌 Commit 654b7b5 has been approved by oli-obk

It is now in the queue for this repository.

increment depth of nested obligations properly fixes the root cause of rust-lang#109268. While we didn't get hangs here before, I ended up encountering its root cause again with rust-lang#138785. r? types

Rollup of 12 pull requests Successful merges: - rust-lang#110406 (rustdoc-json: Add test for #[automatically_derived] attribute) - rust-lang#137738 (Make slice iterator constructors unstably const) - rust-lang#138492 (remove `feature(inline_const_pat)`) - rust-lang#138928 (Fix UWP reparse point check) - rust-lang#138950 (replace extra_filename with strict version hash in metrics file names) - rust-lang#139002 (Add release notes for 1.86.0) - rust-lang#139022 (increment depth of nested obligations) - rust-lang#139060 (replace commit placeholder in vendor status with actual commit) - rust-lang#139102 (coverage: Avoid splitting spans during span extraction/refinement) - rust-lang#139129 (Add tests for slice bounds check optimization) - rust-lang#139188 (PassWrapper: adapt for llvm/llvm-project@94122d58fc77079a291a3d008914…) - rust-lang#139193 (Feed HIR for by-move coroutine body def, since the inliner tries to read its attrs) r? `@ghost` `@rustbot` modify labels: rollup

increment depth of nested obligations properly fixes the root cause of rust-lang#109268. While we didn't get hangs here before, I ended up encountering its root cause again with rust-lang#138785. r? types

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#110406 (rustdoc-json: Add test for #[automatically_derived] attribute) - rust-lang#138790 (Note potential but private items in show_candidates) - rust-lang#138950 (replace extra_filename with strict version hash in metrics file names) - rust-lang#139002 (Add release notes for 1.86.0) - rust-lang#139022 (increment depth of nested obligations) - rust-lang#139129 (Add tests for slice bounds check optimization) - rust-lang#139188 (PassWrapper: adapt for llvm/llvm-project@94122d58fc77079a291a3d008914…) - rust-lang#139193 (Feed HIR for by-move coroutine body def, since the inliner tries to read its attrs) - rust-lang#139202 (Improve docs of ValTreeKind) r? `@ghost` `@rustbot` modify labels: rollup

…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#110406 (rustdoc-json: Add test for #[automatically_derived] attribute) - rust-lang#138790 (Note potential but private items in show_candidates) - rust-lang#139002 (Add release notes for 1.86.0) - rust-lang#139022 (increment depth of nested obligations) - rust-lang#139129 (Add tests for slice bounds check optimization) - rust-lang#139188 (PassWrapper: adapt for llvm/llvm-project@94122d58fc77079a291a3d008914…) - rust-lang#139193 (Feed HIR for by-move coroutine body def, since the inliner tries to read its attrs) - rust-lang#139202 (Improve docs of ValTreeKind) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#139022 - lcnr:incr-obligation-depth, r=oli-obk increment depth of nested obligations properly fixes the root cause of rust-lang#109268. While we didn't get hangs here before, I ended up encountering its root cause again with rust-lang#138785. r? types

rustbot assigned oli-obk Mar 27, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 27, 2025

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 27, 2025

This comment has been minimized.

Sign in to view

craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Mar 27, 2025

craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Mar 28, 2025

oli-obk requested changes Mar 31, 2025

View reviewed changes

compiler/rustc_trait_selection/src/traits/fulfill.rs Outdated Show resolved Hide resolved

compiler/rustc_trait_selection/src/traits/fulfill.rs Show resolved Hide resolved

compiler/rustc_trait_selection/src/traits/fulfill.rs Show resolved Hide resolved

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 31, 2025

lcnr force-pushed the incr-obligation-depth branch from d45d9ae to 2de1c49 Compare March 31, 2025 17:49

lcnr mentioned this pull request Mar 31, 2025

add TypingMode::Borrowck #138785

Merged

increment depth of nested obligations

654b7b5

lcnr force-pushed the incr-obligation-depth branch from 2de1c49 to 654b7b5 Compare March 31, 2025 21:58

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 31, 2025

Zalathar mentioned this pull request Apr 1, 2025

Rollup of 16 pull requests #139203

Closed

Zalathar mentioned this pull request Apr 1, 2025

Rollup of 12 pull requests #139204

Closed

matthiaskrgr mentioned this pull request Apr 1, 2025

Rollup of 9 pull requests #139216

Closed

matthiaskrgr mentioned this pull request Apr 1, 2025

Rollup of 8 pull requests #139220

Merged

bors merged commit 000d018 into rust-lang:master Apr 2, 2025
6 checks passed

rustbot added this to the 1.88.0 milestone Apr 2, 2025

lcnr deleted the incr-obligation-depth branch April 2, 2025 09:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

increment depth of nested obligations #139022

increment depth of nested obligations #139022

lcnr commented Mar 27, 2025

lcnr commented Mar 27, 2025

This comment has been minimized.

bors commented Mar 27, 2025

bors commented Mar 27, 2025

This comment has been minimized.

compiler-errors commented Mar 27, 2025

craterbot commented Mar 27, 2025

rust-timer commented Mar 27, 2025

craterbot commented Mar 27, 2025

craterbot commented Mar 28, 2025

lcnr commented Mar 31, 2025 •

edited

Loading

lcnr commented Mar 31, 2025 •

edited

Loading

oli-obk commented Mar 31, 2025

lcnr commented Mar 31, 2025

bors commented Mar 31, 2025

increment depth of nested obligations #139022

increment depth of nested obligations #139022

Conversation

lcnr commented Mar 27, 2025

lcnr commented Mar 27, 2025

This comment has been minimized.

bors commented Mar 27, 2025

bors commented Mar 27, 2025

This comment has been minimized.

compiler-errors commented Mar 27, 2025

craterbot commented Mar 27, 2025

rust-timer commented Mar 27, 2025

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

craterbot commented Mar 27, 2025

craterbot commented Mar 28, 2025

lcnr commented Mar 31, 2025 • edited Loading

lcnr commented Mar 31, 2025 • edited Loading

oli-obk commented Mar 31, 2025

lcnr commented Mar 31, 2025

bors commented Mar 31, 2025

lcnr commented Mar 31, 2025 •

edited

Loading

lcnr commented Mar 31, 2025 •

edited

Loading