-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make target maintainers more easily pingable #139028
base: master
Are you sure you want to change the base?
Conversation
Wow, amazing, thanks a lot. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are some inconsistencies I found:
Patch applying suggested changes
diff --git a/src/doc/rustc/src/platform-support/aix.md b/src/doc/rustc/src/platform-support/aix.md
index 73c1a3359c8..3002a5c4b2c 100644
--- a/src/doc/rustc/src/platform-support/aix.md
+++ b/src/doc/rustc/src/platform-support/aix.md
@@ -6,7 +6,8 @@ Rust for AIX operating system, currently only 64-bit PowerPC is supported.
## Target maintainers
-[@daltenty](https://github.com/daltenty) [@gilamn5tr](https://github.com/gilamn5tr)
+[@daltenty](https://github.com/daltenty)
+[@gilamn5tr](https://github.com/gilamn5tr)
## Requirements
diff --git a/src/doc/rustc/src/platform-support/armv7-sony-vita-newlibeabihf.md b/src/doc/rustc/src/platform-support/armv7-sony-vita-newlibeabihf.md
index 9f362a536e0..814f301d8b2 100644
--- a/src/doc/rustc/src/platform-support/armv7-sony-vita-newlibeabihf.md
+++ b/src/doc/rustc/src/platform-support/armv7-sony-vita-newlibeabihf.md
@@ -11,7 +11,7 @@ from nor used with any official Sony SDK.
[@nikarh](https://github.com/nikarh)
[@pheki](https://github.com/pheki)
-[@ZetaNumbers](https://github.com/ZetaNumbers)
+[@zetanumbers](https://github.com/zetanumbers)
## Requirements
diff --git a/src/doc/rustc/src/platform-support/armv7r-none-eabi.md b/src/doc/rustc/src/platform-support/armv7r-none-eabi.md
index 6336b016ad6..88b2689dcf0 100644
--- a/src/doc/rustc/src/platform-support/armv7r-none-eabi.md
+++ b/src/doc/rustc/src/platform-support/armv7r-none-eabi.md
@@ -16,7 +16,7 @@ See [`arm-none-eabi`](arm-none-eabi.md) for information applicable to all
## Target maintainers
-[Chris Copeland](https://github.com/chrisnc), `[email protected]`
+[@chrisnc](https://github.com/chrisnc)
## Requirements
diff --git a/src/doc/rustc/src/platform-support/armv8r-none-eabihf.md b/src/doc/rustc/src/platform-support/armv8r-none-eabihf.md
index ad8991a2370..569d8802ebe 100644
--- a/src/doc/rustc/src/platform-support/armv8r-none-eabihf.md
+++ b/src/doc/rustc/src/platform-support/armv8r-none-eabihf.md
@@ -16,7 +16,7 @@ See [`arm-none-eabi`](arm-none-eabi.md) for information applicable to all
## Target maintainers
-[Chris Copeland](https://github.com/chrisnc), `[email protected]`
+[@chrisnc](https://github.com/chrisnc)
## Requirements
diff --git a/src/doc/rustc/src/platform-support/avr-none.md b/src/doc/rustc/src/platform-support/avr-none.md
index c2cab4641ca..5218f19adf3 100644
--- a/src/doc/rustc/src/platform-support/avr-none.md
+++ b/src/doc/rustc/src/platform-support/avr-none.md
@@ -6,7 +6,7 @@ Series of microcontrollers from Atmel: ATmega8, ATmega328p etc.
## Target maintainers
-[Patryk Wychowaniec](https://github.com/Patryk27)
+[@Patryk27](https://github.com/Patryk27)
## Requirements
diff --git a/src/doc/rustc/src/platform-support/fuchsia.md b/src/doc/rustc/src/platform-support/fuchsia.md
index 254900895ae..c7ff0a04d43 100644
--- a/src/doc/rustc/src/platform-support/fuchsia.md
+++ b/src/doc/rustc/src/platform-support/fuchsia.md
@@ -7,7 +7,8 @@ updatable, and performant.
## Target maintainers
-[@erickt](https://github.com/erickt) [@Nashenas88](https://github.com/Nashenas88)
+[@erickt](https://github.com/erickt)
+[@Nashenas88](https://github.com/Nashenas88)
[`fuchsia.toml`]: https://github.com/rust-lang/team/blob/master/teams/fuchsia.toml
diff --git a/src/doc/rustc/src/platform-support/hexagon-unknown-linux-musl.md b/src/doc/rustc/src/platform-support/hexagon-unknown-linux-musl.md
index 9c8e2b9bc3d..be6e17883f4 100644
--- a/src/doc/rustc/src/platform-support/hexagon-unknown-linux-musl.md
+++ b/src/doc/rustc/src/platform-support/hexagon-unknown-linux-musl.md
@@ -11,7 +11,7 @@ DSP architecture.
## Target maintainers
-[Brian Cain](https://github.com/androm3da)
+[@androm3da](https://github.com/androm3da)
## Requirements
The target is cross-compiled. This target supports `std`. By default, code
diff --git a/src/doc/rustc/src/platform-support/hexagon-unknown-none-elf.md b/src/doc/rustc/src/platform-support/hexagon-unknown-none-elf.md
index 07072a7678d..b07b0bb08d6 100644
--- a/src/doc/rustc/src/platform-support/hexagon-unknown-none-elf.md
+++ b/src/doc/rustc/src/platform-support/hexagon-unknown-none-elf.md
@@ -10,7 +10,7 @@ Rust for baremetal Hexagon DSPs.
## Target maintainers
-[Brian Cain](https://github.com/androm3da)
+[@androm3da](https://github.com/androm3da)
## Requirements
diff --git a/src/doc/rustc/src/platform-support/loongarch-linux.md b/src/doc/rustc/src/platform-support/loongarch-linux.md
index ef812c50b1a..817d3a89230 100644
--- a/src/doc/rustc/src/platform-support/loongarch-linux.md
+++ b/src/doc/rustc/src/platform-support/loongarch-linux.md
@@ -22,10 +22,10 @@ Reference material:
## Target maintainers
-- [heiher](https://github.com/heiher)
-- [xiangzhai](https://github.com/xiangzhai)
-- [zhaixiaojuan](https://github.com/zhaixiaojuan)
-- [xen0n](https://github.com/xen0n)
+[@heiher](https://github.com/heiher)
+[@xiangzhai](https://github.com/xiangzhai)
+[@zhaixiaojuan](https://github.com/zhaixiaojuan)
+[@xen0n](https://github.com/xen0n)
## Requirements
diff --git a/src/doc/rustc/src/platform-support/loongarch-none.md b/src/doc/rustc/src/platform-support/loongarch-none.md
index 34b29988526..a2bd6e5734c 100644
--- a/src/doc/rustc/src/platform-support/loongarch-none.md
+++ b/src/doc/rustc/src/platform-support/loongarch-none.md
@@ -11,8 +11,8 @@ Freestanding/bare-metal LoongArch64 binaries in ELF format: firmware, kernels, e
## Target maintainers
-- [heiher](https://github.com/heiher)
-- [xen0n](https://github.com/xen0n)
+[@heiher](https://github.com/heiher)
+[@xen0n](https://github.com/xen0n)
## Requirements
diff --git a/src/doc/rustc/src/platform-support/mips-release-6.md b/src/doc/rustc/src/platform-support/mips-release-6.md
index ce8e8a11d39..77f495751c1 100644
--- a/src/doc/rustc/src/platform-support/mips-release-6.md
+++ b/src/doc/rustc/src/platform-support/mips-release-6.md
@@ -16,10 +16,10 @@ The target name follow this format: `<machine>-<vendor>-<os><abi_suffix>`, where
## Target Maintainers
-[Xuan Chen](https://github.com/chenx97)
-[Walter Ji](https://github.com/709924470)
-[Xinhui Yang](https://github.com/Cyanoxygen)
-[Lain Yang](https://github.com/Fearyncess)
+[@chenx97](https://github.com/chenx97)
+[@709924470](https://github.com/709924470)
+[@Cyanoxygen](https://github.com/Cyanoxygen)
+[@Fearyncess](https://github.com/Fearyncess)
## Requirements
diff --git a/src/doc/rustc/src/platform-support/mips64-openwrt-linux-musl.md b/src/doc/rustc/src/platform-support/mips64-openwrt-linux-musl.md
index 95d2770a169..2ad33c9e20d 100644
--- a/src/doc/rustc/src/platform-support/mips64-openwrt-linux-musl.md
+++ b/src/doc/rustc/src/platform-support/mips64-openwrt-linux-musl.md
@@ -3,7 +3,7 @@
## Target maintainers
-[Itus-Shield](https://github.com/Itus-Shield)
+[@Itus-Shield](https://github.com/Itus-Shield)
## Requirements
This target is cross-compiled. There is no support for `std`. There is no
diff --git a/src/doc/rustc/src/platform-support/x86_64-pc-cygwin.md b/src/doc/rustc/src/platform-support/x86_64-pc-cygwin.md
index 27a77aba9ee..60aaa371bbc 100644
--- a/src/doc/rustc/src/platform-support/x86_64-pc-cygwin.md
+++ b/src/doc/rustc/src/platform-support/x86_64-pc-cygwin.md
@@ -10,7 +10,7 @@ Cygwin is only intended as an emulation layer for Unix-only programs which do no
## Target maintainers
-[Berrysoft](https://github.com/Berrysoft)
+[@Berrysoft](https://github.com/Berrysoft)
## Requirements
diff --git a/src/doc/rustc/src/platform-support/x86_64-unknown-linux-none.md b/src/doc/rustc/src/platform-support/x86_64-unknown-linux-none.md
index 0e4d81a0887..ec16c181fe1 100644
--- a/src/doc/rustc/src/platform-support/x86_64-unknown-linux-none.md
+++ b/src/doc/rustc/src/platform-support/x86_64-unknown-linux-none.md
@@ -6,7 +6,7 @@ Freestanding x86-64 linux binary with no dependency on libc.
## Target maintainers
-[morr0ne](https://github.com/morr0ne/)
+[@morr0ne](https://github.com/morr0ne)
## Requirements
Personally, I like the list format better, but I agree with the reasoning of wanting to format it easier for pasting into |
It looks like all the usernames are current. I've pasted all the usernames, unlinked with One username |
thanks for the patch, I've applied it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! I made some suggestions, but none of them are mandatory.
I'm open to the idea of adding ,
so it looks a bit better in the markdown, but r=me with or without that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@erickt @Nashenas88 FYI, we're inlining the list of maintainers here to make this target consistent with the others, and to make maintainers easily pingable. Please keep that in mind when updating the maintainer list in the future.
☔ The latest upstream changes (presumably #139229) made this pull request unmergeable. Please resolve the merge conflicts. |
Put them all on the same line with just their GitHub handles to make it very easy to copy and paste (with ctrl-shift-v!!!) the names. We have no use for email, so I removed all the emails, we don't care about people's full names either. Co-authored-by: Thalia Archibald <[email protected]>
rebased, added review feeedback, did a self-review and cleaned up a bit more stuff. |
@bors r+ rollup |
Make target maintainers more easily pingable Put them all on the same line with just their GitHub handles to make it very easy to copy and paste (with ctrl-shift-v!!!) the names. We have no use for email, so I removed all the emails, we don't care about people's full names either. This is a pretty big PR with lots of changes. I may have gotten one or two wrong, who knows. I went over it fairly aggressively, removing all information I deemed unnecessary. > [!Caution] > When copying these usernames, use **ctrl-shift-v** to avoid pasting them as links r? RalfJung you indirectly asked for this :) (anyone is welcome to review)
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#138546 (Add integer to string formatting tests) - rust-lang#138950 (replace extra_filename with strict version hash in metrics file names) - rust-lang#139028 (Make target maintainers more easily pingable) - rust-lang#139274 (Rustdoc: typecheck settings.js) - rust-lang#139275 (Update the minimum external LLVM to 19) - rust-lang#139328 (Fix 2024 edition doctest panic output) Failed merges: - rust-lang#138947 (Refactor Apple version handling in the compiler) r? `@ghost` `@rustbot` modify labels: rollup
Make target maintainers more easily pingable Put them all on the same line with just their GitHub handles to make it very easy to copy and paste (with ctrl-shift-v!!!) the names. We have no use for email, so I removed all the emails, we don't care about people's full names either. This is a pretty big PR with lots of changes. I may have gotten one or two wrong, who knows. I went over it fairly aggressively, removing all information I deemed unnecessary. > [!Caution] > When copying these usernames, use **ctrl-shift-v** to avoid pasting them as links r? RalfJung you indirectly asked for this :) (anyone is welcome to review)
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#138546 (Add integer to string formatting tests) - rust-lang#138950 (replace extra_filename with strict version hash in metrics file names) - rust-lang#139028 (Make target maintainers more easily pingable) - rust-lang#139274 (Rustdoc: typecheck settings.js) - rust-lang#139328 (Fix 2024 edition doctest panic output) r? `@ghost` `@rustbot` modify labels: rollup
☔ The latest upstream changes (presumably #137869) made this pull request unmergeable. Please resolve the merge conflicts. |
@bors p=1 (somewhat conflict-prone) |
Put them all on the same line with just their GitHub handles to make it very easy to copy and paste (with ctrl-shift-v!!!) the names.
We have no use for email, so I removed all the emails, we don't care about people's full names either.
This is a pretty big PR with lots of changes. I may have gotten one or two wrong, who knows. I went over it fairly aggressively, removing all information I deemed unnecessary.
Caution
When copying these usernames, use ctrl-shift-v to avoid pasting them as links
r? RalfJung you indirectly asked for this :) (anyone is welcome to review)