Misc query tweaks

[compiler-errors]

Remove some redundant work around cache_on_disk and ensure_ok, since Result<(), ErrorGuaranteed> queries don't need to cache or recompute their "value" if they are only used for their result.

[compiler-errors]

@bors try @rust-timer queue

[bors]

⌛ Trying commit d641708 with merge a292a40...

[bors]

💔 Test failed - checks-actions

[compiler-errors]

@bors try @rust-timer queue

[bors]

⌛ Trying commit 3524e6a with merge a701cc8...

[bors]

☀️ Try build successful - checks-actions
Build commit: a701cc8 (a701cc861787ef7f6b3d2d7b14146d8b1d6fc3e2)

[rust-timer]

Finished benchmarking commit (a701cc8): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.5%	[-1.4%, -0.2%]	89
Improvements ✅ (secondary)	-0.9%	[-2.2%, -0.1%]	15
All ❌✅ (primary)	-0.5%	[-1.4%, -0.2%]	89

Max RSS (memory usage)

Results (primary 0.5%, secondary -0.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.3%	[0.5%, 4.0%]	2
Regressions ❌ (secondary)	0.8%	[0.8%, 0.8%]	1
Improvements ✅ (primary)	-1.3%	[-1.4%, -1.1%]	2
Improvements ✅ (secondary)	-1.2%	[-1.2%, -1.2%]	1
All ❌✅ (primary)	0.5%	[-1.4%, 4.0%]	4

Cycles

Results (primary -2.4%, secondary -1.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.3%	[2.3%, 2.3%]	1
Improvements ✅ (primary)	-2.4%	[-3.3%, -1.3%]	7
Improvements ✅ (secondary)	-3.1%	[-3.2%, -3.0%]	3
All ❌✅ (primary)	-2.4%	[-3.3%, -1.3%]	7

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 774.398s -> 776.139s (0.22%)
Artifact size: 365.94 MiB -> 365.93 MiB (-0.00%)

[rustbot]

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

Some changes occurred to constck

cc @fee1-dead

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

[compiler-errors]

r? @lqd or someone else, should be a pretty straightforward review

[oli-obk]

r? @oli-obk

@bors r+

[bors]

📌 Commit 3524e6a has been approved by oli-obk

It is now in the queue for this repository.

[lqd]

oli was too fast but if inquiring minds need to know, it lgtm as well :)

[bors]

⌛ Testing commit 3524e6a with merge 3658060...

[bors]

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 3658060 to master...

[github-actions]

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing d5b4c2e (parent) -> 3658060 (this PR)

Test differences

Show 86 test diffs

Additionally, 86 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Job duration changes

1. x86_64-apple-1: 8673.9s -> 10808.2s (24.6%)
2. aarch64-apple: 3639.6s -> 4279.7s (17.6%)
3. dist-x86_64-apple: 8432.7s -> 9907.1s (17.5%)
4. dist-s390x-linux: 5322.9s -> 5578.0s (4.8%)
5. aarch64-gnu: 9631.2s -> 9956.4s (3.4%)
6. dist-arm-linux: 5361.4s -> 5526.2s (3.1%)
7. x86_64-gnu-tools: 5932.6s -> 6112.9s (3.0%)
8. x86_64-mingw-2: 6908.6s -> 7105.3s (2.8%)
9. i686-mingw-3: 8065.0s -> 8291.0s (2.8%)
10. dist-powerpc64-linux: 5348.3s -> 5496.2s (2.8%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

[rust-timer]

Finished benchmarking commit (3658060): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.6%	[-1.4%, -0.2%]	71
Improvements ✅ (secondary)	-1.3%	[-2.2%, -0.6%]	9
All ❌✅ (primary)	-0.6%	[-1.4%, -0.2%]	71

Max RSS (memory usage)

Results (primary -0.4%, secondary 0.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.4%	[0.7%, 2.1%]	2
Regressions ❌ (secondary)	0.8%	[0.8%, 0.8%]	1
Improvements ✅ (primary)	-1.3%	[-1.5%, -1.1%]	4
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.4%	[-1.5%, 2.1%]	6

Cycles

Results (primary -2.1%, secondary 2.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.8%	[1.5%, 3.9%]	19
Improvements ✅ (primary)	-2.1%	[-2.7%, -1.3%]	5
Improvements ✅ (secondary)	-2.4%	[-2.5%, -2.2%]	2
All ❌✅ (primary)	-2.1%	[-2.7%, -1.3%]	5

Binary size

Results (primary -0.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.0%	[-0.0%, -0.0%]	4
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.0%	[-0.0%, -0.0%]	4

Bootstrap: 777.539s -> 778.368s (0.11%)
Artifact size: 365.91 MiB -> 365.91 MiB (0.00%)