Skip to content

Add a dep kind for use of the anon node with zero dependencies #139237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2025

Conversation

Zoxc
Copy link
Contributor

@Zoxc Zoxc commented Apr 2, 2025

This adds a dep kind for use of the anon node with zero dependencies instead of making use of the null node. I don't think this matters, but it is nicer than random null nodes in the dep graph.

@rustbot
Copy link
Collaborator

rustbot commented Apr 2, 2025

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 2, 2025
@jieyouxu
Copy link
Member

jieyouxu commented Apr 2, 2025

r? compiler

@rustbot rustbot assigned oli-obk and unassigned jieyouxu Apr 2, 2025
@compiler-errors
Copy link
Member

r? compiler-errors @bors r+

@bors
Copy link
Collaborator

bors commented Apr 2, 2025

📌 Commit 927ad16 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 2, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 2, 2025
…errors

Add a dep kind for use of the anon node with zero dependencies

This adds a dep kind for use of the anon node with zero dependencies instead of making use of the null node. I don't think this matters, but it is nicer than random null nodes in the dep graph.
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 2, 2025
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#138992 (literal pattern lowering: use the pattern's type instead of the literal's in `const_to_pat`)
 - rust-lang#139211 (interpret: add a version of run_for_validation for &self)
 - rust-lang#139235 (`AstValidator` tweaks)
 - rust-lang#139237 (Add a dep kind for use of the anon node with zero dependencies)
 - rust-lang#139260 (Add dianqk to codegen reviewers)
 - rust-lang#139264 (Fix two incorrect turbofish suggestions)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 3c5ee8d into rust-lang:master Apr 2, 2025
6 checks passed
@rustbot rustbot added this to the 1.88.0 milestone Apr 2, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 2, 2025
Rollup merge of rust-lang#139237 - Zoxc:anon-0-deps-kind, r=compiler-errors

Add a dep kind for use of the anon node with zero dependencies

This adds a dep kind for use of the anon node with zero dependencies instead of making use of the null node. I don't think this matters, but it is nicer than random null nodes in the dep graph.
@Zoxc Zoxc deleted the anon-0-deps-kind branch April 3, 2025 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants