Skip to content

Folder experiment: Monomorphize region resolver #139287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2025

Conversation

compiler-errors
Copy link
Member

NOTE: This is one of a series of perf experiments that I've come up with while sick in bed. I'm assigning them to lqd b/c you're a good reviewer and you'll hopefully be awake when these experiments finish, lol.

r? lqd

This is actually two tweaks to the RegionFolder, monomorphizing its callback and accounting for flags to avoid folding unnecessarily.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 2, 2025
@compiler-errors
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 2, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 2, 2025
… r=<try>

Folder experiment: Monomorphize region resolver

**NOTE:** This is one of a series of perf experiments that I've come up with while sick in bed. I'm assigning them to lqd b/c you're a good reviewer and you'll hopefully be awake when these experiments finish, lol.

r? lqd

This is actually two tweaks to the `RegionFolder`, monomorphizing its callback and accounting for flags to avoid folding unnecessarily.
@bors
Copy link
Collaborator

bors commented Apr 2, 2025

⌛ Trying commit 60b742d with merge 0ebb652...

@bors
Copy link
Collaborator

bors commented Apr 3, 2025

☀️ Try build successful - checks-actions
Build commit: 0ebb652 (0ebb652806a0269fb6ebfd6e57d7b8d025530124)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (0ebb652): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.3% [-0.8%, -0.2%] 45
Improvements ✅
(secondary)
-0.7% [-1.7%, -0.2%] 29
All ❌✅ (primary) -0.3% [-0.8%, -0.2%] 45

Max RSS (memory usage)

Results (primary 1.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.3% [1.3%, 1.3%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 1.3% [1.3%, 1.3%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 777.539s -> 779.926s (0.31%)
Artifact size: 365.91 MiB -> 366.17 MiB (0.07%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 3, 2025
@compiler-errors compiler-errors marked this pull request as ready for review April 3, 2025 10:30
@lqd
Copy link
Member

lqd commented Apr 3, 2025

This is Chef's kiss, but don't work while sick! Take care of yourself bestie.

Maybe it'd be interesting in the future to have a TypeFlags constructor that contains all the region-related variants to slightly simplify the check is here.

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 3, 2025

📌 Commit 60b742d has been approved by lqd

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 3, 2025
@Zalathar
Copy link
Contributor

Zalathar commented Apr 4, 2025

Scheduling: If the rollup #139344 fails, move on to this never PR instead of an iffy PR.

@bors p=1

@bors
Copy link
Collaborator

bors commented Apr 4, 2025

⌛ Testing commit 60b742d with merge f174fd7...

@bors
Copy link
Collaborator

bors commented Apr 4, 2025

☀️ Test successful - checks-actions
Approved by: lqd
Pushing f174fd7 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 4, 2025
@bors bors merged commit f174fd7 into rust-lang:master Apr 4, 2025
7 checks passed
@rustbot rustbot added this to the 1.88.0 milestone Apr 4, 2025
Copy link

github-actions bot commented Apr 4, 2025

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 9e14530 (parent) -> f174fd7 (this PR)

Test differences

No test diffs found

Job duration changes

  1. dist-x86_64-musl: 7286.6s -> 7816.0s (7.3%)
  2. dist-x86_64-freebsd: 4696.3s -> 4982.6s (6.1%)
  3. i686-mingw-1: 7155.6s -> 7500.5s (4.8%)
  4. x86_64-gnu-llvm-18-3: 6637.5s -> 6932.3s (4.4%)
  5. x86_64-gnu-stable: 6577.5s -> 6864.2s (4.4%)
  6. i686-gnu-nopt-1: 8287.3s -> 8644.6s (4.3%)
  7. dist-i686-msvc: 7169.5s -> 7459.2s (4.0%)
  8. x86_64-mingw-2: 6774.2s -> 7045.9s (4.0%)
  9. dist-riscv64-linux: 5028.3s -> 5194.0s (3.3%)
  10. dist-various-2: 3347.2s -> 3454.6s (3.2%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (f174fd7): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.3% [-0.7%, -0.2%] 34
Improvements ✅
(secondary)
-0.9% [-1.6%, -0.2%] 19
All ❌✅ (primary) -0.3% [-0.7%, -0.2%] 34

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 773.774s -> 778.988s (0.67%)
Artifact size: 365.73 MiB -> 365.99 MiB (0.07%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants