Folder experiment: Account for TypeFlags in OpportunisticRegionResolver #139288
Conversation
rustbot
added
S-waiting-on-review
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
rustbot
added
the
S-waiting-on-perf
compiler-errors
changed the title
… r=<try> Folder experiment: Account for TypeFlags in OpportunisticRegionResolver **NOTE:** This is one of a series of perf experiments that I've come up with while sick in bed. I'm assigning them to lqd b/c you're a good reviewer and you'll hopefully be awake when these experiments finish, lol. r? lqd The `OpportunisticRegionResolver` is hot, so let's avoid unnecessarily folding predicates. This will likey end up being a noop, so close this if it's perf neutral.
… r=<try> Folder experiment: Account for type flags in fold_predicate in OpportunisticVarResolver **NOTE:** This is one of a series of perf experiments that I've come up with while sick in bed. I'm assigning them to lqd b/c you're a good reviewer and you'll hopefully be awake when these experiments finish, lol. r? lqd Same as rust-lang#139288, but for the var resolver. I could've probably merged these into one, but I want to test these things in parallel. Close this if it ends up neutral.
|
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (3ab1cc6): comparison URL. Overall result: no relevant changes - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary 1.8%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 777.539s -> 776.292s (-0.16%) |
rustbot
removed
the
S-waiting-on-perf
NOTE: This is one of a series of perf experiments that I've come up with while sick in bed. I'm assigning them to lqd b/c you're a good reviewer and you'll hopefully be awake when these experiments finish, lol.
r? lqd
The
OpportunisticRegionResolveris hot, so let's avoid unnecessarily folding predicates. This will likey end up being a noop, so close this if it's perf neutral.