-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Folder experiment: Account for type flags in fold_predicate
in Canonicalizer
#139293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Folder experiment: Account for type flags in fold_predicate
in Canonicalizer
#139293
Conversation
Ok this is the last one. @bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
… r=<try> Folder experiment: Account for type flags in `fold_predicate` in `Canonicalizer` **NOTE:** This is one of a series of perf experiments that I've come up with while sick in bed. I'm assigning them to lqd b/c you're a good reviewer and you'll hopefully be awake when these experiments finish, lol. r? lqd The canonicalizer is used a lot in borrowck and in the eval-flavor of the trait solver. Let's avoid doing unnecessary work when folding predicates, which I would assume are a very important input to the canonicalizer as the main "type" of all goals and such.
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (1dc5c24): comparison URL. Overall result: ✅ improvements - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (primary 1.4%, secondary -1.3%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (secondary 3.0%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 777.539s -> 775.128s (-0.31%) |
Minor improvements at best, probably noise. |
NOTE: This is one of a series of perf experiments that I've come up with while sick in bed. I'm assigning them to lqd b/c you're a good reviewer and you'll hopefully be awake when these experiments finish, lol.
r? lqd
The canonicalizer is used a lot in borrowck and in the eval-flavor of the trait solver. Let's avoid doing unnecessary work when folding predicates, which I would assume are a very important input to the canonicalizer as the main "type" of all goals and such.