-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Rollup of 19 pull requests #139508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 19 pull requests #139508
Conversation
Fixes rust-lang#139082. Emits an error when `Self` is found in the projection bounds of a trait object. In type aliases, `Self` has no meaning, so `type A = &'static dyn B` where `trait B = Fn() -> Self` will expands to `type A = &'static Fn() -> Self` which is illegal, causing the region solver to bail out when hitting the uninferred Self. Bug: rust-lang#139082 Signed-off-by: xtex <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
we already track this info in the `definitions` field
It was supposed to be like this from the start, but I forgot to apply the `abs` operation, as I got sidetracked with how to actually compare floats...
Signed-off-by: onur-ozkan <[email protected]>
This should make it much easier to investigate the individual job changes.
Those that didn't previously preserved kind are now marked as not requiring annotations to keep the previous behavior. Also, do not lose diagnostics with an empty message.
This catches some silly notes emitted by rustc, which should ideally be fixed
…ocks" This reverts commit 51b51b5.
|
@bors r+ rollup=never p=4 |
@matthiaskrgr: Why did you close a larger rollup seemingly in favor of a rollup of less than half its size? |
Yes, i saved us from sinking a day or two of ci time into a rollup that is almost guaranteed to fail :) |
@matthias: That's not how rollups work. The purpose of a rollup is to test artifacts in parallel. Don't randomly close people's PRs to try to preempt your smaller rollups just because you think it should get merged first. |
@bors r+ rollup=never p=10 |
💡 This pull request was already approved, no need to approve it again.
|
If you want to test prs, you should use try-jobs , the way you don't block the queue for a day and and a half |
Making myself clear, it doesn't matter if this rollup fails to get merged. The purpose of a rollup is to make sure that we're always testing artifacts to push things out of the queue. If you do the math, we'd have to fail basically every rollup for us to really need to incentivize making small rollups, and there are 33 PRs in the queue, so it doesn't really warrant doing that right now. |
Where are you getting this number from? Testing a rollup takes like three hours. |
unfortunately, if you rollup 20 prs, and there are 3 bad ones which is quite likely, that will mean you won't push anything out of the queue for around 7 hours, and then you will have 45 waiting in the queue:( |
I think things are fine here :) And if this rollup fails, it'll just fall back to the next rollup, so no harm done. I think it's best not to micromanage other people's rollups without even leaving a comment. |
…errors Rollup of 19 pull requests Successful merges: - rust-lang#138676 (Implement overflow for infinite implied lifetime bounds) - rust-lang#139024 (Make error message for missing fields with `..` and without `..` more consistent) - rust-lang#139098 (Tell LLVM about impossible niche tags) - rust-lang#139124 (compiler: report error when trait object type param reference self) - rust-lang#139321 (Update to new rinja version (askama)) - rust-lang#139346 (Don't construct preds w escaping bound vars in `diagnostic_hir_wf_check`) - rust-lang#139386 (make it possible to use stage0 libtest on compiletest) - rust-lang#139421 (Fix trait upcasting to dyn type with no principal when there are projections) - rust-lang#139468 (Don't call `Span::with_parent` on the good path in `has_stashed_diagnostic`) - rust-lang#139476 (rm `RegionInferenceContext::var_infos`) - rust-lang#139481 (Add job summary links to post-merge report) - rust-lang#139485 (compiletest: Stricter parsing for diagnostic kinds) - rust-lang#139490 (Update some comment/docs related to "extern intrinsic" removal) - rust-lang#139491 (Update books) - rust-lang#139496 (Revert r-a changes of rust-lang#139455) - rust-lang#139500 (document panic behavior of Vec::resize and Vec::resize_with) - rust-lang#139501 (Fix stack overflow in exhaustiveness due to recursive HIR opaque hidden types) - rust-lang#139504 (add missing word in doc comment) - rust-lang#139507 (compiletest: Trim whitespace from environment variable names) r? `@ghost` `@rustbot` modify labels: rollup
The job Click to see the possible cause of the failure (guessed by this bot)
|
💔 Test failed - checks-actions |
Successful merges:
..
and without..
more consistent #139024 (Make error message for missing fields with..
and without..
more consistent)diagnostic_hir_wf_check
#139346 (Don't construct preds w escaping bound vars indiagnostic_hir_wf_check
)Span::with_parent
on the good path inhas_stashed_diagnostic
#139468 (Don't callSpan::with_parent
on the good path inhas_stashed_diagnostic
)RegionInferenceContext::var_infos
#139476 (rmRegionInferenceContext::var_infos
)extern "rust-intrinsic"
blocks #139455)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup