Rollup of 13 pull requests #139622
Merged
Rollup of 13 pull requests #139622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xizheyin <[email protected]>
Currently the code continues, using an empty path, but it doesn't need to.
`resolve_ident_in_lexical_scope` checks for an empty name. Why is this necessary? Because `parse_item_impl` can produce an `impl` block with an empty trait name in some cases. This is pretty gross and very non-obvious. This commit avoids the use of the empty trait name. In one case the trait name is instead pulled from `TyKind::ImplTrait`, which prevents the output for `tests/ui/impl-trait/extra-impl-in-trait-impl.rs` from changing. In the other case we just fail the parse and don't try to recover. I think losing error recovery in this obscure case is worth the code cleanup. This change affects `tests/ui/parser/impl-parsing.rs`, which is split in two, and the obsolete `..` syntax cases are removed (they are tested elsewhere).
Signed-off-by: xizheyin <[email protected]>
We should enable these to avoid misinterpreting uses of the extended syntax as code blocks. This happens in practice with multi-paragraph footnotes, as discovered in rust-lang#139064.
Inspired by some of the communication issues around the stabilization of `let`-chains, give more fine-grained information about the status of updating style for any new syntax. This does not change the process or blockers in any way; it only *documents* the current state in the tracking issue. For instance, in the case of `let`-chains, we would have checked the boxes for "Style team decision" and "(non-blocking) Formatting has been implemented", and not checked the box for the style guide. That would have then provided better supporting information for any decisions.
…pper-improvement, r=camelid Small code improvement in rustdoc hidden stripper This is a very minor code improvement following rust-lang#137534. It doesn't change anything about the performance issue. r? ```@notriddle```
…Gomez Clean up librustdoc::html::render to be better encapsulated Closes rust-lang#138567
…=oli-obk Suppress missing field error when autoderef bottoms out in infer I see this error repeatedly when doing refactorings, and it's pretty misleading b/c it's not the source of the error.
match ergonomics: replace `peel_off_references` with a recursive call This makes it imo quite a bit easier to follow how the binding mode gets calculated. cc ```@dianne```
compiletest: Trim whitespace from environment variable names When a test contains a directive like `//@ exec-env: FOO=bar`, compiletest currently includes that leading space in the name of the environment variable, so it is defined as ` FOO` instead of `FOO`. This is an annoying footgun that is pretty much never intended, especially since most other directives *do* trim whitespace. So let's get rid of it by trimming the environment variable name. Values remain untrimmed, since there could conceivably be a use-case for values with leading space, but perhaps we'll end up trimming values too in the future. Recently observed in rust-lang#138603 (comment). Fixes rust-lang#132990. Supersedes rust-lang#133148. --- try-job: test-various
…=RalfJung Remove some dead or leftover code related to rustc-intrinsic abi removal r? ```@RalfJung``` PR that removed the ABI: rust-lang#139455 tracking issue: rust-lang#132735
fix title of offset_of_enum feature tracking issue rust-lang#120141
…eyouxu emit a better error message for using the macro incorrectly fixing: EnzymeAD#185 I feel like it's not a perfect message either, so I'm open to suggestions. But at the end of the day users will need to read the docs anyway, and emitting multi-line errors each time this gets triggered can probably become annoying? r? ``@jieyouxu`` since you've reviewed my frontend work back in the days. Tracking: - rust-lang#124509
…mpiler-errors Don't use empty trait names Helps with rust-lang#137978. Details in individual commits. r? ```@davidtwco```
Temporarily leave the review rotation r? ghost
saethlin is back from vacation
rustdoc: Enable Markdown extensions when looking for doctests Fixes rust-lang#139064. We should enable these to avoid misinterpreting uses of the extended syntax as code blocks. This happens in practice with multi-paragraph footnotes, as discovered in rust-lang#139064.
…viscross Tracking issue template: fine-grained information on style update status Inspired by some of the communication issues around the stabilization of `let`-chains, give more fine-grained information about the status of updating style for any new syntax. This does not change the process or blockers in any way; it only *documents* the current state in the tracking issue. For instance, in the case of `let`-chains, we would have checked the boxes for "Style team decision" and "(non-blocking) Formatting has been implemented", and not checked the box for the style guide. That would have then provided better supporting information for any decisions.
rustbot
added
A-compiletest
|
@bors r+ rollup=never p=5 |
bors
added
S-waiting-on-bors
Merged
|
☀️ Test successful - checks-actions |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 7d7de5b (parent) -> 69b3959 (this PR) Test differencesShow 20 test diffsStage 1
Stage 2
Additionally, 8 doctest diffs were found. These are ignored, as they are noisy. Job group index
Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
📌 Perf builds for each rolled up PR:
previous master: 7d7de5bf3c In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
|
Finished benchmarking commit (69b3959): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (primary 2.5%, secondary 3.7%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 782.463s -> 782.988s (0.07%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
peel_off_referenceswith a recursive call #139449 (match ergonomics: replacepeel_off_referenceswith a recursive call)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup