Don't build `ParamEnv` and do trait solving in `ItemCtxt`s when lowering IATs #140247

BoxyUwU · 2025-04-24T10:15:25Z

Fixes #125879
This was due to updating inhabited predicate stuff which I had to do to make constructing ADTs with IATs in fields not ICE

Fixes #136678 (but no test added, I don't rly care about weird IAT edge cases under GCE)
Fixes #138131

Avoids doing "fully correct" candidate selection for IATs during hir ty lowering when in item signatures as it almost always leads to a query cycle from trying to build a ParamEnv. I replaced it with a use DeepRejectCtxt which should be able to handle this kind of conservative "could these types unify" while in a context where we don't want to do type equality.

This is a relatively simple scheme and should be forwards compatible with doing something more complex/powerful.

I'm not really sure how this interacts with #126651, though I'm also not really sure its super important to support projecting IATs from IAT self types given we don't even support T::Assoc::Other for trait-associated types so didn't give much thought to how this might fit in with that.

r? @compiler-errors
cc @fmease

rustbot · 2025-04-24T10:15:31Z

This PR changes a file inside tests/crashes. If a crash was fixed, please move into the corresponding ui subdir and add 'Fixes #' to the PR description to autoclose the issue upon merge.

HIR ty lowering was modified

cc @fmease

compiler/rustc_hir_analysis/src/collect.rs

bors · 2025-04-28T21:32:11Z

☔ The latest upstream changes (presumably #140388) made this pull request unmergeable. Please resolve the merge conflicts.

compiler-errors · 2025-05-22T09:49:10Z

@bors r+

bors · 2025-05-22T09:49:13Z

📌 Commit 34ce403 has been approved by compiler-errors

It is now in the queue for this repository.

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#135562 (Add ignore value suggestion in closure body) - rust-lang#139635 (Finalize repeat expr inference behaviour with inferred repeat counts) - rust-lang#139668 (Handle regions equivalent to 'static in non_local_bounds) - rust-lang#140218 (HIR ty lowering: Clean up & refactor the lowering of type-relative paths) - rust-lang#140435 (use uX::from instead of _ as uX in non - const contexts) - rust-lang#141130 (rustc_on_unimplemented cleanups) - rust-lang#141286 (Querify `coroutine_hidden_types`) Failed merges: - rust-lang#140247 (Don't build `ParamEnv` and do trait solving in `ItemCtxt`s when lowering IATs) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2025-05-23T01:02:00Z

☔ The latest upstream changes (presumably #141396) made this pull request unmergeable. Please resolve the merge conflicts.

BoxyUwU · 2025-05-23T14:28:28Z

I should probably update this to use DeepRejectCtxt and handle LTAs correctly like discussed at the all hands 🤔 I was just gonna do it in a followup PR but if I'm having to rebase and figure out new crashes tests then I may aswell just do it all now

compiler/rustc_hir_analysis/src/collect.rs

compiler/rustc_hir_analysis/src/hir_ty_lowering/mod.rs

tests/ui/associated-inherent-types/bound_vars_in_args.rs

tests/ui/associated-inherent-types/candidate-with-alias-2.rs

tests/ui/associated-inherent-types/candidate-with-alias.rs

tests/ui/associated-inherent-types/multiple-candidates-in-adt-field-2.rs

lcnr

nits, then r=me

lcnr · 2025-06-18T14:47:23Z

@bors r+ rollup

bors · 2025-06-18T14:47:25Z

📌 Commit e280d26 has been approved by lcnr

It is now in the queue for this repository.

Don't build `ParamEnv` and do trait solving in `ItemCtxt`s when lowering IATs Fixes rust-lang#108491 Fixes rust-lang#125879 This was due to updating inhabited predicate stuff which I had to do to make constructing ADTs with IATs in fields not ICE Fixes rust-lang#136678 (but no test added, I don't rly care about weird IAT edge cases under GCE) Fixes rust-lang#138131 Avoids doing "fully correct" candidate selection for IATs during hir ty lowering when in item signatures as it almost always leads to a query cycle from trying to build a `ParamEnv`. I replaced it with a use `DeepRejectCtxt` which should be able to handle this kind of conservative "could these types unify" while in a context where we don't want to do type equality. This is a relatively simple scheme and should be forwards compatible with doing something more complex/powerful. I'm not really sure how this interacts with rust-lang#126651, though I'm also not really sure its super important to support projecting IATs from IAT self types given we don't even support `T::Assoc::Other` for trait-associated types so didn't give much thought to how this might fit in with that. r? `@compiler-errors` cc `@fmease`

Kobzol · 2025-06-18T16:06:26Z

@bors r-

PR CI failed.

BoxyUwU · 2025-06-18T20:06:35Z

@bors r=lcnr

bors · 2025-06-18T20:06:38Z

📌 Commit 377d8fa has been approved by lcnr

It is now in the queue for this repository.

Rollup of 7 pull requests Successful merges: - #140247 (Don't build `ParamEnv` and do trait solving in `ItemCtxt`s when lowering IATs) - #142507 (use `#[align]` attribute for `fn_align`) - #142524 (Weekly `cargo update`) - #142606 (AsyncDrop trait without sync Drop generates an error) - #142639 (Add a missing colon at the end of the panic location details in location-detail-unwrap-multiline.rs) - #142654 (library: Increase timeout on mpmc test to reduce flakes) - #142692 (Assorted bootstrap cleanups (step 3)) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #140247 - BoxyUwU:iats_no_query_cycles, r=lcnr Don't build `ParamEnv` and do trait solving in `ItemCtxt`s when lowering IATs Fixes #108491 Fixes #125879 This was due to updating inhabited predicate stuff which I had to do to make constructing ADTs with IATs in fields not ICE Fixes #136678 (but no test added, I don't rly care about weird IAT edge cases under GCE) Fixes #138131 Avoids doing "fully correct" candidate selection for IATs during hir ty lowering when in item signatures as it almost always leads to a query cycle from trying to build a `ParamEnv`. I replaced it with a use `DeepRejectCtxt` which should be able to handle this kind of conservative "could these types unify" while in a context where we don't want to do type equality. This is a relatively simple scheme and should be forwards compatible with doing something more complex/powerful. I'm not really sure how this interacts with #126651, though I'm also not really sure its super important to support projecting IATs from IAT self types given we don't even support `T::Assoc::Other` for trait-associated types so didn't give much thought to how this might fit in with that. r? `@compiler-errors` cc `@fmease`

Rollup of 7 pull requests Successful merges: - rust-lang/rust#140247 (Don't build `ParamEnv` and do trait solving in `ItemCtxt`s when lowering IATs) - rust-lang/rust#142507 (use `#[align]` attribute for `fn_align`) - rust-lang/rust#142524 (Weekly `cargo update`) - rust-lang/rust#142606 (AsyncDrop trait without sync Drop generates an error) - rust-lang/rust#142639 (Add a missing colon at the end of the panic location details in location-detail-unwrap-multiline.rs) - rust-lang/rust#142654 (library: Increase timeout on mpmc test to reduce flakes) - rust-lang/rust#142692 (Assorted bootstrap cleanups (step 3)) r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned compiler-errors Apr 24, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 24, 2025

BoxyUwU commented Apr 24, 2025

View reviewed changes

compiler/rustc_hir_analysis/src/collect.rs Outdated Show resolved Hide resolved

compiler-errors reviewed Apr 24, 2025

View reviewed changes

compiler/rustc_hir_analysis/src/collect.rs Outdated Show resolved Hide resolved

BoxyUwU force-pushed the iats_no_query_cycles branch from 3361c7d to 34ce403 Compare April 29, 2025 15:06

fmease mentioned this pull request Apr 29, 2025

Tracking Issue for RFC 3591: useing a function from a trait #134691

Open

4 tasks

compiler-errors approved these changes May 22, 2025

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 22, 2025

matthiaskrgr mentioned this pull request May 22, 2025

Rollup of 7 pull requests #141396

Merged

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 23, 2025

BoxyUwU force-pushed the iats_no_query_cycles branch 2 times, most recently from aee1a22 to 701d3b8 Compare May 23, 2025 14:25

BoxyUwU force-pushed the iats_no_query_cycles branch from 701d3b8 to 276daf2 Compare May 23, 2025 15:16

BoxyUwU commented May 23, 2025

View reviewed changes

compiler/rustc_hir_analysis/src/collect.rs Outdated Show resolved Hide resolved

lcnr reviewed May 23, 2025

View reviewed changes

compiler/rustc_hir_analysis/src/collect.rs Outdated Show resolved Hide resolved

BoxyUwU force-pushed the iats_no_query_cycles branch from 276daf2 to 5867bb5 Compare May 23, 2025 16:22

BoxyUwU commented May 23, 2025

View reviewed changes

compiler/rustc_hir_analysis/src/collect.rs Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

BoxyUwU force-pushed the iats_no_query_cycles branch from 5867bb5 to 02b87a8 Compare May 23, 2025 18:06

BoxyUwU commented May 23, 2025

View reviewed changes

compiler/rustc_hir_analysis/src/hir_ty_lowering/mod.rs Show resolved Hide resolved

lcnr reviewed Jun 17, 2025

View reviewed changes

tests/ui/associated-inherent-types/bound_vars_in_args.rs Outdated Show resolved Hide resolved

lcnr reviewed Jun 17, 2025

View reviewed changes

tests/ui/associated-inherent-types/candidate-with-alias-2.rs Show resolved Hide resolved

lcnr reviewed Jun 17, 2025

View reviewed changes

tests/ui/associated-inherent-types/candidate-with-alias.rs Show resolved Hide resolved

lcnr reviewed Jun 17, 2025

View reviewed changes

tests/ui/associated-inherent-types/multiple-candidates-in-adt-field-2.rs Outdated Show resolved Hide resolved

lcnr reviewed Jun 17, 2025

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 18, 2025

This comment has been minimized.

Sign in to view

Kobzol mentioned this pull request Jun 18, 2025

Rollup of 12 pull requests #142679

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 18, 2025

Reviews

377d8fa

BoxyUwU force-pushed the iats_no_query_cycles branch from e280d26 to 377d8fa Compare June 18, 2025 16:51

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 18, 2025

tgross35 mentioned this pull request Jun 19, 2025

Rollup of 7 pull requests #142697

Merged

bors merged commit cff8e9a into rust-lang:master Jun 19, 2025
10 checks passed

github-project-automation bot moved this from In Progress to Done in Inherent Associated Types (IAT) Jun 19, 2025

rustbot added this to the 1.89.0 milestone Jun 19, 2025

matthiaskrgr mentioned this pull request Jun 19, 2025

ICE: .. was equal to .. during selection but now it is not #142717

Open

matthiaskrgr mentioned this pull request Jun 20, 2025

ICE: unelided lifetime in signature #142773

Open

Don't build ParamEnv and do trait solving in ItemCtxts when lowering IATs #140247

Don't build ParamEnv and do trait solving in ItemCtxts when lowering IATs #140247

Uh oh!

Conversation

BoxyUwU commented Apr 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Apr 24, 2025

Uh oh!

Uh oh!

Uh oh!

bors commented Apr 28, 2025

Uh oh!

compiler-errors commented May 22, 2025

Uh oh!

bors commented May 22, 2025

Uh oh!

bors commented May 23, 2025

Uh oh!

BoxyUwU commented May 23, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lcnr left a comment

Choose a reason for hiding this comment

Uh oh!

lcnr commented Jun 18, 2025

Uh oh!

bors commented Jun 18, 2025

Uh oh!

This comment has been minimized.

Kobzol commented Jun 18, 2025

Uh oh!

BoxyUwU commented Jun 18, 2025

Uh oh!

bors commented Jun 18, 2025

Uh oh!

Uh oh!

Uh oh!

Don't build `ParamEnv` and do trait solving in `ItemCtxt`s when lowering IATs #140247

Don't build `ParamEnv` and do trait solving in `ItemCtxt`s when lowering IATs #140247

BoxyUwU commented Apr 24, 2025 •

edited

Loading