Skip to content

ci: move dist-x86_64-linux job to codebuild #141501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2025

Conversation

marcoieni
Copy link
Member

Related to rust-lang/infra-team#188
This job was already in codebuild, but in #141388 we moved it back to GitHub Actions to do the rust-lang-ci migration easily.
This PR moves it back to codebuild. It also moves the try job.
r? @Kobzol

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels May 24, 2025
@marcoieni
Copy link
Member Author

@bors try

bors added a commit that referenced this pull request May 24, 2025
…r=<try>

ci: move dist-x86_64-linux job to codebuild
@bors
Copy link
Collaborator

bors commented May 24, 2025

⌛ Trying commit dc18763 with merge 9961326...

@bors
Copy link
Collaborator

bors commented May 24, 2025

💔 Test failed - checks-actions

@bors bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label May 24, 2025
@marcoieni
Copy link
Member Author

@bors try

@bors
Copy link
Collaborator

bors commented May 24, 2025

⌛ Trying commit dc18763 with merge 51e8053...

bors added a commit that referenced this pull request May 24, 2025
…r=<try>

ci: move dist-x86_64-linux job to codebuild
@Kobzol
Copy link
Contributor

Kobzol commented May 24, 2025

Did you configure the environment for both try and auto branches on Codebuild?

@bors
Copy link
Collaborator

bors commented May 24, 2025

☀️ Try build successful - checks-actions
Build commit: 51e8053 (51e80539c8286ac8c15a5d05294031d3dca32598)

@marcoieni
Copy link
Member Author

I didn't have to configure branches as far as I remember

@marcoieni marcoieni marked this pull request as ready for review May 24, 2025 17:23
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 24, 2025
@marcoieni
Copy link
Member Author

@rustbot ready

@Kobzol
Copy link
Contributor

Kobzol commented May 24, 2025

Ok, let's try.

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented May 24, 2025

📌 Commit dc18763 has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 24, 2025
bors added a commit that referenced this pull request May 26, 2025
…r=Kobzol

ci: move dist-x86_64-linux job to codebuild
@bors
Copy link
Collaborator

bors commented May 26, 2025

⌛ Testing commit dc18763 with merge d1ee190...

@marcoieni
Copy link
Member Author

I manually canceled this job because the runner wasn't starting
image

@bors
Copy link
Collaborator

bors commented May 26, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 26, 2025
@marcoieni
Copy link
Member Author

marcoieni commented May 26, 2025

maybe this was due to the github incident. 🤔

@bors
Copy link
Collaborator

bors commented May 26, 2025

📌 Commit 1e7c437 has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 26, 2025
@jieyouxu
Copy link
Member

@bors p=6 (ahead of rollups)

@bors
Copy link
Collaborator

bors commented May 26, 2025

⌛ Testing commit 1e7c437 with merge e2adb60...

bors added a commit that referenced this pull request May 26, 2025
…r=Kobzol

ci: move dist-x86_64-linux job to codebuild
@alex
Copy link
Member

alex commented May 26, 2025

The dist-x86_64-linux job doesn't appear to be starting

@marcoieni
Copy link
Member Author

yes, you are right, I canceled the workflow. I'll have a look tomorrow

@bors
Copy link
Collaborator

bors commented May 26, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 26, 2025
@marcoieni
Copy link
Member Author

rust-lang/simpleinfra#720 probably fixed the issue.
Jakub, can approve this PR at your name tomorrow morning if I don't see other 400s from the webhook dashboard?

@Kobzol
Copy link
Contributor

Kobzol commented May 27, 2025

Sure, feel free to r=me.

@marcoieni
Copy link
Member Author

I haven't seen that error anymore. Let's try again

@bors r+

@bors
Copy link
Collaborator

bors commented May 28, 2025

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
  • There's another pull request that is currently being tested, blocking this pull request: [do not merge] CI experiments #112049

@bors
Copy link
Collaborator

bors commented May 28, 2025

📌 Commit 1e7c437 has been approved by marcoieni

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 28, 2025
@marcoieni
Copy link
Member Author

@bors r=Kobzol

@bors
Copy link
Collaborator

bors commented May 28, 2025

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Collaborator

bors commented May 28, 2025

📌 Commit 1e7c437 has been approved by Kobzol

It is now in the queue for this repository.

@marcoieni
Copy link
Member Author

I forgot to r=Kobzol initially.

@bors
Copy link
Collaborator

bors commented May 28, 2025

⌛ Testing commit 1e7c437 with merge 77101fe...

@marcoieni
Copy link
Member Author

the job started 🥳
image

@bors
Copy link
Collaborator

bors commented May 28, 2025

☀️ Test successful - checks-actions
Approved by: Kobzol
Pushing 77101fe to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 28, 2025
@bors bors merged commit 77101fe into rust-lang:master May 28, 2025
8 checks passed
@rustbot rustbot added this to the 1.89.0 milestone May 28, 2025
Copy link

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing cb678b9 (parent) -> 77101fe (this PR)

Test differences

No test diffs found

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 77101febcc9662a076ff43887497cd5b30674d93 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-apple-various: 5980.3s -> 7273.4s (21.6%)
  2. x86_64-apple-1: 8585.4s -> 6886.6s (-19.8%)
  3. aarch64-gnu: 6702.0s -> 7927.2s (18.3%)
  4. aarch64-gnu-debug: 4098.8s -> 4784.3s (16.7%)
  5. x86_64-apple-2: 4171.1s -> 4791.8s (14.9%)
  6. dist-x86_64-apple: 8073.6s -> 8899.7s (10.2%)
  7. dist-x86_64-netbsd: 4802.8s -> 5243.4s (9.2%)
  8. dist-x86_64-linux: 5479.7s -> 4981.2s (-9.1%)
  9. aarch64-apple: 4579.1s -> 4964.7s (8.4%)
  10. dist-i586-gnu-i586-i686-musl: 5538.9s -> 5136.9s (-7.3%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (77101fe): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.2% [-0.6%, -0.1%] 6
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary 1.9%, secondary 3.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
6.1% [6.1%, 6.1%] 1
Regressions ❌
(secondary)
8.5% [8.5%, 8.5%] 1
Improvements ✅
(primary)
-2.2% [-2.2%, -2.2%] 1
Improvements ✅
(secondary)
-2.0% [-2.0%, -2.0%] 1
All ❌✅ (primary) 1.9% [-2.2%, 6.1%] 2

Cycles

Results (secondary -2.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.0% [-2.3%, -1.8%] 2
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 778.889s -> 777.676s (-0.16%)
Artifact size: 368.42 MiB -> 368.53 MiB (0.03%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants