Rollup of 11 pull requests #142133

GuillaumeGomez · 2025-06-06T21:53:21Z

Successful merges:

Reexport types from c_size_t in std #140418 (Reexport types from c_size_t in std)
unsafe keyword docs: emphasize that an unsafe fn in a trait does not get to choose its safety contract #141471 (unsafe keyword docs: emphasize that an unsafe fn in a trait does not get to choose its safety contract)
Reduce ast::ptr::P to a typedef of Box #141603 (Reduce ast::ptr::P to a typedef of Box)
Verbose suggestion to make param const #142043 (Verbose suggestion to make param const)
duduplicate more AST visitor methods #142086 (duduplicate more AST visitor methods)
Update InterpCx::project_field to take FieldIdx #142103 (Update InterpCx::project_field to take FieldIdx)
remove extraneous text #142105 (remove extraneous text)
fix typo #142112 (fix typo)
Reduce confusion of some drop order tests #142113 (Reduce confusion of some drop order tests)
Compute number of digits instead of relying on constant value for u128 display code #142114 (Compute number of digits instead of relying on constant value for u128 display code)
rustc_lexer: typo fix + small cleanups #142118 (rustc_lexer: typo fix + small cleanups)

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

These are unstably available in `core` and should be in `std` too, but are not currently reexported. Resolve this here.

These date back to 2014. I don't think they're needed any more.

It's barely used, and the places that use it are better if they don't.

A `Vec` is fine, the additional word (vector vs. boxed slice) doesn't matter here.

It's no longer used.

Keep the `P` constructor function for now, to minimize immediate churn. All the `into_inner` calls are removed, which is nice.

``` error[E0747]: type provided when a constant was expected --> $DIR/invalid-const-arguments.rs:10:19 | LL | impl<N> Foo for B<N> {} | ^ | help: consider changing this type parameter to a const parameter | LL - impl<N> Foo for B<N> {} LL + impl<const N: u8> Foo for B<N> {} | ```

As suggested by Ralf in 142005.

"Basic usage" implies there is an example that shows advanced usage

Co-authored-by: Ralf Jung <[email protected]>

…8 display code

In addition to adhering to normal Rust casing idioms, I ran `rustfmt`.

…get to choose its safety contract

…bilee Reexport types from `c_size_t` in `std` These are unstably available in `core` and should be in `std` too, but are not currently reexported. Resolve this here. Tracking issue: rust-lang#88345

…viscross unsafe keyword docs: emphasize that an unsafe fn in a trait does not get to choose its safety contract Inspired by discussion in rust-lang#139368. Cc `@hanna-kruppe`

Reduce `ast::ptr::P` to a typedef of `Box` As per the MCP at rust-lang/compiler-team#878. r? `@fee1-dead`

…ywiser Verbose suggestion to make param `const` ``` error[E0747]: type provided when a constant was expected --> $DIR/invalid-const-arguments.rs:10:19 | LL | impl<N> Foo for B<N> {} | ^ | help: consider changing this type parameter to a const parameter | LL - impl<N> Foo for B<N> {} LL + impl<const N: u8> Foo for B<N> {} | ``` Part of rust-lang#141973.

…p, r=oli-obk duduplicate more AST visitor methods r? oli-obk

…-obk Update `InterpCx::project_field` to take `FieldIdx` As suggested by Ralf in rust-lang#142005 (comment)

…ilee remove extraneous text

fix typo

…on, r=jieyouxu Reduce confusion of some drop order tests In addition to adhering to normal Rust casing idioms, I ran `rustfmt`. Closes rust-lang#141604 r? `@jieyouxu`

Compute number of digits instead of relying on constant value for u128 display code As discussed in https://github.com/rust-lang/rust/pull/142098/files#r2132084991, the code should reuse the same logic as the rest of file instead of using a constant value. r? `@tamird`

rustc_lexer: typo fix + small cleanups

GuillaumeGomez · 2025-06-06T21:53:34Z

@bors r+ p=5 rollup=never

bors · 2025-06-06T21:53:37Z

📌 Commit 22d53ad has been approved by GuillaumeGomez

It is now in the queue for this repository.

bors · 2025-06-07T00:21:03Z

⌛ Testing commit 22d53ad with merge 775e0c8...

bors · 2025-06-07T03:19:55Z

☀️ Test successful - checks-actions
Approved by: GuillaumeGomez
Pushing 775e0c8 to master...

github-actions · 2025-06-07T03:22:43Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 868bf2d (parent) -> 775e0c8 (this PR)

Test differences

Show 864 test diffs

864 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 775e0c8aeb8f63192854b27156f8b05a06b51814 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

x86_64-apple-2: 3655.8s -> 4817.4s (31.8%)
x86_64-apple-1: 6534.4s -> 8216.9s (25.7%)
mingw-check-1: 1614.7s -> 1922.6s (19.1%)
x86_64-rust-for-linux: 2531.7s -> 2944.7s (16.3%)
dist-x86_64-apple: 8274.4s -> 9316.2s (12.6%)
x86_64-gnu-llvm-19-1: 3224.4s -> 3522.4s (9.2%)
x86_64-gnu-debug: 5460.8s -> 5964.9s (9.2%)
i686-gnu-2: 5462.0s -> 5962.7s (9.2%)
x86_64-gnu-llvm-20-2: 5434.4s -> 5889.6s (8.4%)
i686-gnu-nopt-1: 7257.5s -> 7854.1s (8.2%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-06-07T03:23:05Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#140418	Reexport types from `c_size_t` in `std`	`8e717c5aaf0f3bba38b9798121e94ae1b2bf4d17` (link)
#141471	unsafe keyword docs: emphasize that an unsafe fn in a trait…	`636a6c289ec21f92c080aeac42d2130a48df374e` (link)
#141603	Reduce `ast::ptr::P` to a typedef of `Box`	`4c6f6479549402e21b57f02d8548ac588878f969` (link)
#142043	Verbose suggestion to make param `const`	`771b39b47657188be5100681e664ad6be220f8d8` (link)
#142086	duduplicate more AST visitor methods	`4846a434969011bac1675d5cc7069ed411d70267` (link)
#142103	Update `InterpCx::project_field` to take `FieldIdx`	`7e2ca660f9d06e3750229a03bdf74c8361aba661` (link)
#142105	remove extraneous text	`0c4095ee85ee57352efec94486314a0b4af70d1f` (link)
#142112	fix typo	`ded656c69df38b2786c7c6b225e394edafd2fc40` (link)
#142113	Reduce confusion of some drop order tests	`ee65e8741364322cefde961fecd45bb37a4d1c5e` (link)
#142114	Compute number of digits instead of relying on constant val…	`58b768fa7d96a97796ffa7f28b03d8ab20defe8c` (link)
#142118	rustc_lexer: typo fix + small cleanups	`23f1d0b78dc397b6566e479e13c94674acaaa284` (link)

previous master: 868bf2da31

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2025-06-07T04:49:00Z

Finished benchmarking commit (775e0c8): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.2%	[-0.2%, -0.2%]	4
Improvements ✅ (secondary)	-0.3%	[-0.4%, -0.2%]	8
All ❌✅ (primary)	-0.2%	[-0.2%, -0.2%]	4

Max RSS (memory usage)

Results (primary -2.6%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.6%	[-4.2%, -1.0%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.6%	[-4.2%, -1.0%]	2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 751.358s -> 752.833s (0.20%)
Artifact size: 372.51 MiB -> 372.46 MiB (-0.01%)

tgross35 and others added 29 commits April 28, 2025 19:57

Reexport types from c_size_t in std

8db68da

These are unstably available in `core` and should be in `std` too, but are not currently reexported. Resolve this here.

Remove 'static bounds on P.

a35675d

These date back to 2014. I don't think they're needed any more.

Remove P::map.

6973fa0

It's barely used, and the places that use it are better if they don't.

Remove the one use of P<[T]>.

0f285e3

A `Vec` is fine, the additional word (vector vs. boxed slice) doesn't matter here.

Remove support for P<[T]>.

6859750

It's no longer used.

Remove unused P stuff.

c42d1fc

Reduce P<T> to a typedef of Box<T>.

991c91f

Keep the `P` constructor function for now, to minimize immediate churn. All the `into_inner` calls are removed, which is nice.

use helper macro for flat_map vs visit_list, initial dedups

91b77e0

Update InterpCx::project_field to take FieldIdx

8bce225

As suggested by Ralf in 142005.

remove extraneous text

0ffff46

"Basic usage" implies there is an example that shows advanced usage

deduplicate more walk_* methods in AST visit

8a7262c

Update compiler/rustc_abi/src/layout/ty.rs

f9cf096

Co-authored-by: Ralf Jung <[email protected]>

fix typo

b285908

Compute number of digits instead of relying on constant value for u12…

28a2e1e

…8 display code

Reduce confusion of some drop order tests

8fc1bed

In addition to adhering to normal Rust casing idioms, I ran `rustfmt`.

rustc_lexer: typo fix + small cleanups

2a5225a

unsafe keyword docs: emphasize that an unsafe fn in a trait does not …

910a59d

…get to choose its safety contract

Rollup merge of rust-lang#140418 - tgross35:std-c-size_t, r=workingju…

3fee6cc

…bilee Reexport types from `c_size_t` in `std` These are unstably available in `core` and should be in `std` too, but are not currently reexported. Resolve this here. Tracking issue: rust-lang#88345

Rollup merge of rust-lang#141471 - RalfJung:unsafe-fn-in-trait, r=tra…

15d9b96

…viscross unsafe keyword docs: emphasize that an unsafe fn in a trait does not get to choose its safety contract Inspired by discussion in rust-lang#139368. Cc `@hanna-kruppe`

Rollup merge of rust-lang#141603 - nnethercote:reduce-P, r=fee1-dead

93ca0af

Reduce `ast::ptr::P` to a typedef of `Box` As per the MCP at rust-lang/compiler-team#878. r? `@fee1-dead`

Rollup merge of rust-lang#142086 - fee1-dead-contrib:ast-visitor-dedu…

2946ce2

…p, r=oli-obk duduplicate more AST visitor methods r? oli-obk

Rollup merge of rust-lang#142103 - scottmcm:fieldidx-in-interp, r=oli…

3a6f1b0

…-obk Update `InterpCx::project_field` to take `FieldIdx` As suggested by Ralf in rust-lang#142005 (comment)

Rollup merge of rust-lang#142105 - tshepang:basic-usage, r=workingjub…

b4b2d0e

…ilee remove extraneous text

Rollup merge of rust-lang#142112 - ada4a:patch-1, r=wesleywiser

c1e67ad

fix typo

Rollup merge of rust-lang#142113 - shepmaster:drop-order-test-confusi…

b6ace05

…on, r=jieyouxu Reduce confusion of some drop order tests In addition to adhering to normal Rust casing idioms, I ran `rustfmt`. Closes rust-lang#141604 r? `@jieyouxu`

Rollup merge of rust-lang#142118 - hkBst:lexer-patch1, r=oli-obk

22d53ad

rustc_lexer: typo fix + small cleanups

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 6, 2025

rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Jun 6, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 6, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 7, 2025

bors merged commit 775e0c8 into rust-lang:master Jun 7, 2025
11 checks passed

rustbot added this to the 1.89.0 milestone Jun 7, 2025

This was referenced Jun 7, 2025

Start using pattern types in libcore #136006

Open

Faster fmt::Display of 128-bit integers, without unsafe pointer #136594

Open

Implement int_format_into feature #142098

Open

GuillaumeGomez deleted the rollup-fvzdren branch June 7, 2025 10:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 11 pull requests #142133

Rollup of 11 pull requests #142133

Uh oh!

GuillaumeGomez commented Jun 6, 2025 •

edited by rustbot

Loading

Uh oh!

GuillaumeGomez commented Jun 6, 2025

Uh oh!

bors commented Jun 6, 2025

Uh oh!

bors commented Jun 7, 2025

Uh oh!

bors commented Jun 7, 2025

Uh oh!

Uh oh!

github-actions bot commented Jun 7, 2025

Uh oh!

rust-timer commented Jun 7, 2025

Uh oh!

rust-timer commented Jun 7, 2025

Uh oh!

Uh oh!

Rollup of 11 pull requests #142133

Rollup of 11 pull requests #142133

Uh oh!

Conversation

GuillaumeGomez commented Jun 6, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

GuillaumeGomez commented Jun 6, 2025

Uh oh!

bors commented Jun 6, 2025

Uh oh!

bors commented Jun 7, 2025

Uh oh!

bors commented Jun 7, 2025

Uh oh!

Uh oh!

github-actions bot commented Jun 7, 2025

Test differences

Job duration changes

Uh oh!

rust-timer commented Jun 7, 2025

Uh oh!

rust-timer commented Jun 7, 2025

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Uh oh!

GuillaumeGomez commented Jun 6, 2025 •

edited by rustbot

Loading