Port #[rustc_pub_transparent] to the new attribute system
#142600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-attributes
|
Some changes occurred in compiler/rustc_passes/src/check_attr.rs Some changes occurred in compiler/rustc_attr_data_structures Some changes occurred in compiler/rustc_attr_parsing |
|
☔ The latest upstream changes (presumably #138165) made this pull request unmergeable. Please resolve the merge conflicts. |
GrigorenkoPV
force-pushed
the
attributes/rustc_pub_transparent
branch
from
3a22b8c to
9e7300a
Compare
|
☔ The latest upstream changes (presumably #142697) made this pull request unmergeable. Please resolve the merge conflicts. |
GrigorenkoPV
force-pushed
the
attributes/rustc_pub_transparent
branch
from
9e7300a to
9e2493f
Compare
| @@ -158,6 +158,14 @@ impl<'tcx> CheckAttrVisitor<'tcx> { | |||
| Attribute::Parsed(AttributeKind::AsPtr(attr_span)) => { | |||
| self.check_applied_to_fn_or_method(hir_id, *attr_span, span, target) | |||
| } | |||
| &Attribute::Parsed(AttributeKind::PubTransparent(attr_span)) => { | |||
There was a problem hiding this comment.
this should get its own method (See my comment on #[may_dangle])
|
☔ The latest upstream changes (presumably #142770) made this pull request unmergeable. Please resolve the merge conflicts. |
GrigorenkoPV
force-pushed
the
attributes/rustc_pub_transparent
branch
from
9e2493f to
b9e3095
Compare
|
☔ The latest upstream changes (presumably #142794) made this pull request unmergeable. Please resolve the merge conflicts. |
GrigorenkoPV
force-pushed
the
attributes/rustc_pub_transparent
branch
from
b9e3095 to
71c6b25
Compare
|
@bors r+ rollup thanks @GrigorenkoPV ! |
bors
added
S-waiting-on-bors
|
welp, unfortunately seems to conflict with the other PRs in the current rollup, gotta rebase when it's merged :/ |
|
@bors r- |
bors
added
S-waiting-on-author
bors
added a commit
that referenced
this pull request
Jun 21, 2025
Rollup of 3 pull requests Successful merges: - #142539 (Port `#[may_dangle]` to the new attribute system) - #142690 (expand: Remove some unnecessary generic parameters) - #142698 (Improve diagnostics for `concat_bytes!` with C string literals) Failed merges: - #142600 (Port `#[rustc_pub_transparent]` to the new attribute system) - #142776 (All HIR attributes are outer) r? `@ghost` `@rustbot` modify labels: rollup
|
r=me after rebase |
|
☔ The latest upstream changes (presumably #142826) made this pull request unmergeable. Please resolve the merge conflicts. |
GrigorenkoPV
force-pushed
the
attributes/rustc_pub_transparent
branch
from
71c6b25 to
d86d3f3
Compare
|
@rustbot ready |
rustbot
removed
the
S-waiting-on-author
rustbot
added
the
S-waiting-on-review
|
@bors r+ |
bors
added
S-waiting-on-bors
jdonszelmann
added a commit
to jdonszelmann/rust
that referenced
this pull request
Jun 21, 2025
…transparent, r=jdonszelmann Port `#[rustc_pub_transparent]` to the new attribute system Very similar to rust-lang#142498. This is a part of rust-lang#131229, so r? `@jdonszelmann` --- For reference, the `#[rustc_pub_transparent]` attribute was created by me back in rust-lang#129487. As mentioned back in rust-lang#129487 (comment), this attribute does not check that it is applied to an ADT, because it checks that `#[repr(transparent)]` is also applied to the same item, which, in turn, should check for ADT.
bors
added a commit
that referenced
this pull request
Jun 21, 2025
Rollup of 6 pull requests Successful merges: - #140254 (Pass -Cpanic=abort for the panic_abort crate) - #142600 (Port `#[rustc_pub_transparent]` to the new attribute system) - #142617 (improve search graph docs, reset `encountered_overflow` between reruns) - #142641 (Generate symbols.o for proc-macros too) - #142776 (All HIR attributes are outer) - #142800 (integer docs: remove extraneous text) r? `@ghost` `@rustbot` modify labels: rollup
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Jun 22, 2025
…transparent, r=jdonszelmann Port `#[rustc_pub_transparent]` to the new attribute system Very similar to rust-lang#142498. This is a part of rust-lang#131229, so r? ``@jdonszelmann`` --- For reference, the `#[rustc_pub_transparent]` attribute was created by me back in rust-lang#129487. As mentioned back in rust-lang#129487 (comment), this attribute does not check that it is applied to an ADT, because it checks that `#[repr(transparent)]` is also applied to the same item, which, in turn, should check for ADT.
bors
added a commit
that referenced
this pull request
Jun 22, 2025
Rollup of 10 pull requests Successful merges: - #140254 (Pass -Cpanic=abort for the panic_abort crate) - #142594 (Add DesugaringKind::FormatLiteral) - #142600 (Port `#[rustc_pub_transparent]` to the new attribute system) - #142617 (improve search graph docs, reset `encountered_overflow` between reruns) - #142641 (Generate symbols.o for proc-macros too) - #142747 (rustdoc_json: conversion cleanups) - #142776 (All HIR attributes are outer) - #142800 (integer docs: remove extraneous text) - #142850 (remove asm_goto feature annotation, for it is now stabilized) - #142860 (Notify me on tidy changes) r? `@ghost` `@rustbot` modify labels: rollup
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Jun 22, 2025
…transparent, r=jdonszelmann Port `#[rustc_pub_transparent]` to the new attribute system Very similar to rust-lang#142498. This is a part of rust-lang#131229, so r? ```@jdonszelmann``` --- For reference, the `#[rustc_pub_transparent]` attribute was created by me back in rust-lang#129487. As mentioned back in rust-lang#129487 (comment), this attribute does not check that it is applied to an ADT, because it checks that `#[repr(transparent)]` is also applied to the same item, which, in turn, should check for ADT.
bors
added a commit
that referenced
this pull request
Jun 22, 2025
Rollup of 9 pull requests Successful merges: - #140254 (Pass -Cpanic=abort for the panic_abort crate) - #142600 (Port `#[rustc_pub_transparent]` to the new attribute system) - #142617 (improve search graph docs, reset `encountered_overflow` between reruns) - #142641 (Generate symbols.o for proc-macros too) - #142747 (rustdoc_json: conversion cleanups) - #142776 (All HIR attributes are outer) - #142800 (integer docs: remove extraneous text) - #142850 (remove asm_goto feature annotation, for it is now stabilized) - #142860 (Notify me on tidy changes) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
that referenced
this pull request
Jun 22, 2025
Rollup of 10 pull requests Successful merges: - #140254 (Pass -Cpanic=abort for the panic_abort crate) - #142600 (Port `#[rustc_pub_transparent]` to the new attribute system) - #142617 (improve search graph docs, reset `encountered_overflow` between reruns) - #142747 (rustdoc_json: conversion cleanups) - #142776 (All HIR attributes are outer) - #142800 (integer docs: remove extraneous text) - #142841 (Enable fmt-write-bloat for Windows) - #142845 (Enable textrel-on-minimal-lib for Windows) - #142850 (remove asm_goto feature annotation, for it is now stabilized) - #142860 (Notify me on tidy changes) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Jun 22, 2025
Rollup merge of #142600 - GrigorenkoPV:attributes/rustc_pub_transparent, r=jdonszelmann Port `#[rustc_pub_transparent]` to the new attribute system Very similar to #142498. This is a part of #131229, so r? ````@jdonszelmann```` --- For reference, the `#[rustc_pub_transparent]` attribute was created by me back in #129487. As mentioned back in #129487 (comment), this attribute does not check that it is applied to an ADT, because it checks that `#[repr(transparent)]` is also applied to the same item, which, in turn, should check for ADT.
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very similar to #142498.
This is a part of #131229, so
r? @jdonszelmann
For reference, the
#[rustc_pub_transparent]attribute was created by me back in #129487.As mentioned back in #129487 (comment), this attribute does not check that it is applied to an ADT, because it checks that
#[repr(transparent)]is also applied to the same item, which, in turn, should check for ADT.