Skip to content

Remove hello_world directory #144411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2025
Merged

Remove hello_world directory #144411

merged 1 commit into from
Jul 30, 2025

Conversation

Kivooeo
Copy link
Member

@Kivooeo Kivooeo commented Jul 24, 2025 •
edited by jieyouxu
Loading

Move tests/ui/hello_world/main.rs and retire the single-file tests/ui/hello_world/ directory.

Part of #133895.

r? @jieyouxu

@rustbot
Copy link
Collaborator

rustbot commented Jul 24, 2025

jieyouxu is currently at their maximum review capacity.
They may take a while to respond.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 24, 2025
@jieyouxu
Copy link
Member

When you do these kind of ui subdirectory changes, can you also make sure to update tests/ui/README.md?

@Kivooeo
Copy link
Member Author

Kivooeo commented Jul 24, 2025

Sure, one sec

@Kivooeo
Copy link
Member Author

Kivooeo commented Jul 24, 2025

I believe you've meant SUMMARY.md because there is no tests/ui/README.md

@jieyouxu
Copy link
Member

Er sorry, we'll rename it to README.md in #144340 as that's what usually other test dirs / subdirs use (and not to be confused with mdbook) following feedback.

For this PR yeah it'll be SUMMARY.md.

jieyouxu
jieyouxu reviewed Jul 24, 2025
View reviewed changes
@jieyouxu
Copy link
Member

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 24, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jul 24, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@Kivooeo
Copy link
Member Author

Kivooeo commented Jul 24, 2025

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 24, 2025
jieyouxu
jieyouxu approved these changes Jul 25, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it's a bit weird where to put it, warnings/ is fine for now.

@jieyouxu
Copy link
Member

This will merge conflict with #144340, so

@rustbot blocked (on #144340)

@rustbot rustbot added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 25, 2025
@jieyouxu
Copy link
Member

jieyouxu commented Jul 25, 2025 •
edited
Loading

btw meta suggestion: I edited the PR description to better reflect what this PR currently does, it's very helpful to update the PR title/description after changes since the initial version/approach :3

@bors
Copy link
Collaborator

bors commented Jul 25, 2025

☔ The latest upstream changes (presumably #144440) made this pull request unmergeable. Please resolve the merge conflicts.

@Kivooeo
Copy link
Member Author

Kivooeo commented Jul 25, 2025 •
edited
Loading

will fix this after #144151 (because of conflict)

@Kivooeo
Copy link
Member Author

Kivooeo commented Jul 29, 2025

@rustbot ready

@rustbot rustbot removed the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Jul 29, 2025
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 29, 2025
@jieyouxu
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 30, 2025

📌 Commit 01891d5 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 30, 2025
@Zalathar Zalathar mentioned this pull request Jul 30, 2025
Merged
bors added a commit that referenced this pull request Jul 30, 2025
@bors
Auto merge of #144673 - Zalathar:rollup-0kpeq3n, r=Zalathar
e5e79f8 
Rollup of 6 pull requests

Successful merges:

 - #144042 (Verify llvm-needs-components are not empty and match the --target value)
 - #144268 (Add method `find_ancestor_not_from_macro` and `find_ancestor_not_from_extern_macro` to supersede `find_oldest_ancestor_in_same_ctxt`)
 - #144411 (Remove `hello_world` directory)
 - #144662 (compiletest: Move directive names back into a separate file)
 - #144666 (Make sure to account for the right item universal regions in borrowck)
 - #144668 ([test][run-make] add needs-llvm-components)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 38e7615 into rust-lang:master Jul 30, 2025
10 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jul 30, 2025
rust-timer added a commit that referenced this pull request Jul 30, 2025
@rust-timer
Unrolled build for #144411
25b0fb8 
Rollup merge of #144411 - Kivooeo:remove-world, r=jieyouxu

Remove `hello_world` directory

Move `tests/ui/hello_world/main.rs` and retire the single-file `tests/ui/hello_world/` directory.

Part of #133895.

r? `@jieyouxu`
github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Jul 31, 2025
@bors
Auto merge of #144673 - Zalathar:rollup-0kpeq3n, r=Zalathar
0fabf33 
Rollup of 6 pull requests

Successful merges:

 - rust-lang/rust#144042 (Verify llvm-needs-components are not empty and match the --target value)
 - rust-lang/rust#144268 (Add method `find_ancestor_not_from_macro` and `find_ancestor_not_from_extern_macro` to supersede `find_oldest_ancestor_in_same_ctxt`)
 - rust-lang/rust#144411 (Remove `hello_world` directory)
 - rust-lang/rust#144662 (compiletest: Move directive names back into a separate file)
 - rust-lang/rust#144666 (Make sure to account for the right item universal regions in borrowck)
 - rust-lang/rust#144668 ([test][run-make] add needs-llvm-components)

r? `@ghost`
`@rustbot` modify labels: rollup
TheBlindArchitect pushed a commit to XSLabs/integration that referenced this pull request Aug 3, 2025
@copybara-github
[roll] Roll infra/recipes [rust] Update hello_world file location
a22c743 
We use a rust hello_world test program as part of PGO training,
and it was recently moved in
rust-lang/rust#144411, which breaks
toolchain builds when profiling is enabled.

Original-Bug: 435743671
Original-Reviewed-on: https://fuchsia-review.googlesource.com/c/infra/recipes/+/1336708
Original-Revision: f21213834663f3ae8f206ce379816c17ee6355b6
GitOrigin-RevId: bd6709bd37188547667a26e01a3c8461b69b4dad
Change-Id: I8c2d3c92f4e21bc414d5b67f88c7178d197e690d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.90.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Kivooeo @rustbot @jieyouxu @bors