Skip to content

Rehome 37 tests/ui/issues/ tests to other subdirectories under tests/ui/ #144983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Rehome 37 tests/ui/issues/ tests to other subdirectories under tests/ui/ #144983

wants to merge 1 commit into from
+132 −84

Conversation

Oneirical
Copy link
Contributor

Part of #133895

Methodology:

  1. Refer to the previously written tests/ui/SUMMARY.md
  2. Find an appropriate category for the test, using the original issue thread and the test contents.
  3. Add the issue URL at the bottom (not at the top, as that would mess up stderr line numbers)
  4. Rename the tests to make their purpose clearer

Inspired by the methodology that @Kivooeo was using.

r? @jieyouxu

@rustbot
Copy link
Collaborator

rustbot commented Aug 6, 2025

jieyouxu is currently at their maximum review capacity.
They may take a while to respond.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 6, 2025
@rustbot
Copy link
Collaborator

rustbot commented Aug 6, 2025

This PR modifies tests/ui/issues/. If this PR is adding new tests to tests/ui/issues/,
please refrain from doing so, and instead add it to more descriptive subdirectories.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jieyouxu jieyouxu added the S-no-work-capacity-tracking Status: Exempted from triagebot work capacity tracking. label Aug 7, 2025
@bors
Copy link
Collaborator

bors commented Aug 8, 2025

☔ The latest upstream changes (presumably #145077) made this pull request unmergeable. Please resolve the merge conflicts.

@Oneirical Oneirical force-pushed the uncountable-integer branch 2 times, most recently from bc5adb8 to e74b717 Compare August 8, 2025 19:38
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Oneirical
Copy link
Contributor Author

@rustbot author

@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 8, 2025
@rustbot
Copy link
Collaborator

rustbot commented Aug 8, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@rustbot rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Aug 8, 2025
@Oneirical Oneirical force-pushed the uncountable-integer branch from e74b717 to 7690357 Compare August 10, 2025 05:17
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Oneirical Oneirical force-pushed the uncountable-integer branch from 7690357 to 742cc39 Compare August 10, 2025 15:57
@Oneirical
Copy link
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 10, 2025
jieyouxu
jieyouxu requested changes Aug 12, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, a few minor issues.

tests/ui/binding/ref-in-function-parameter-patterns-8860.rs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: pattern/

tests/ui/binding/match-with-at-binding-8391.rs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: pattern/

tests/ui/binop/invalid-assignment-lhs-in-while-772182.fixed
@@ -1,3 +1,4 @@
// https://github.com/rust-lang/rust/issues/772182
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Problem: extra 2

tests/ui/binop/invalid-assignment-lhs-in-while-772182.rs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Problem: extra 2

tests/ui/const-generics/invalid-attributes-on-const-params-78957.rs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: attributes/

tests/ui/issues/methods-with-mut-trait-and-polymorphic-objects-issue-8401.rs
@@ -5,3 +5,5 @@
extern crate issue_8401;

pub fn main() {}

// https://github.com/rust-lang/rust/issues/8401
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: move to top?

tests/ui/issues/methods-with-mut-trait-and-polymorphic-objects-issue-8401.rs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: can you move this away from issues/?

tests/ui/modules/module-import-resolution-7663.rs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: resolve/

tests/ui/privacy/inaccessible-fields-pattern-matching-760771.rs
@@ -1,3 +1,4 @@
// https://github.com/rust-lang/rust/issues/760771
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Problem: 1 here and in test name

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu jieyouxu requested changes

Assignees

@jieyouxu jieyouxu

Labels
S-no-work-capacity-tracking Status: Exempted from triagebot work capacity tracking. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Oneirical @rustbot @rust-log-analyzer @bors @jieyouxu