Skip to content

Add new Tier-3 target: riscv64a23-unknown-linux-gnu #145076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add new Tier-3 target: riscv64a23-unknown-linux-gnu #145076

wants to merge 5 commits into from
+210 −1

Conversation

ZhongyaoChen
Copy link

@ZhongyaoChen ZhongyaoChen commented Aug 8, 2025 •
edited
Loading

MCP: Tier 3 target proposal: riscv64a23-unknown-linux-gnu

Changes:

  • add new target: riscv64a23-unknown-linux-gnu
  • add target page

@rustbot
Copy link
Collaborator

rustbot commented Aug 8, 2025

r? @jdno

rustbot has assigned @jdno.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Aug 8, 2025
@rustbot
Copy link
Collaborator

rustbot commented Aug 8, 2025

These commits modify compiler targets.
(See the Target Tier Policy.)

Some changes occurred in src/doc/rustc/src/platform-support

cc @Noratrieb

@rustbot

This comment has been minimized.

Sign in to view
@ZhongyaoChen ZhongyaoChen force-pushed the feature/add-tier3-riscv64a23-target branch from f77bc29 to 577b85a Compare August 8, 2025 03:41
zachs18
zachs18 reviewed Aug 8, 2025
View reviewed changes
@rust-log-analyzer

This comment has been minimized.

Sign in to view
jieyouxu
jieyouxu requested changes Aug 8, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tier 3 targets do not get built nor tested in rust-lang/rust CI, and by implication, no prebuilt artifacts will be distributed for Tier 3 targets.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Collaborator

bors commented Aug 8, 2025

☔ The latest upstream changes (presumably #145077) made this pull request unmergeable. Please resolve the merge conflicts.

@ZhongyaoChen ZhongyaoChen force-pushed the feature/add-tier3-riscv64a23-target branch from 64b98ad to 3ec3eea Compare August 11, 2025 08:21
@rustbot rustbot added the A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. label Aug 11, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@ZhongyaoChen ZhongyaoChen force-pushed the feature/add-tier3-riscv64a23-target branch from 3ec3eea to 1be21d3 Compare August 11, 2025 12:43
@rustbot
Copy link
Collaborator

rustbot commented Aug 11, 2025

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

This PR modifies tests/ui/issues/. If this PR is adding new tests to tests/ui/issues/,
please refrain from doing so, and instead add it to more descriptive subdirectories.

This PR changes how LLVM is built. Consider updating src/bootstrap/download-ci-llvm-stamp.

This PR modifies src/bootstrap/src/core/config.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

@rustbot rustbot added the T-clippy Relevant to the Clippy team. label Aug 11, 2025
@ZhongyaoChen ZhongyaoChen force-pushed the feature/add-tier3-riscv64a23-target branch from 1be21d3 to 87fd289 Compare August 11, 2025 13:10
@ZhongyaoChen ZhongyaoChen requested a review from jieyouxu August 11, 2025 14:59
@ZhongyaoChen
Copy link
Author

Ready for review. @zachs18 @Noratrieb @jieyouxu

@jchzhou
Copy link

jchzhou commented Aug 12, 2025

Some minor issue here: the target requirement listed in platform-support.md (kernel 4.20+, glibc 2.29) and platform-support/riscv64a23-unknown-linux-gnu.md (kernel 4.20+, glibc 2.19) does not align, and both of them are not quite sufficient for RVA23. At least the kernel should be 6.x from the last 2 or 3 years I think?

ref: https://lf-rise.atlassian.net/wiki/spaces/HOME/pages/8587962/RVA23+Profile

@ZhongyaoChen
Copy link
Author

Some minor issue here: the target requirement listed in platform-support.md (kernel 4.20+, glibc 2.29) and platform-support/riscv64a23-unknown-linux-gnu.md (kernel 4.20+, glibc 2.19) does not align, and both of them are not quite sufficient for RVA23. At least the kernel should be 6.x from the last 2 or 3 years I think?

ref: https://lf-rise.atlassian.net/wiki/spaces/HOME/pages/8587962/RVA23+Profile

  • For the minimum glibc version, riscv64gc also seems to have documentation issues. I’ll confirm the minimum version later.
  • I don’t think such a new kernel is needed, since I haven’t changed ABI or std.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu Awaiting requested review from jieyouxu

@Noratrieb Noratrieb Awaiting requested review from Noratrieb

@zachs18 zachs18 Awaiting requested review from zachs18

Assignees

@jdno jdno

Labels
A-CI Area: Our Github Actions CI A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@ZhongyaoChen @rustbot @rust-log-analyzer @bors @jchzhou @zachs18 @jieyouxu @Noratrieb @jdno