ci: add timeout to windows disk cleanup wait

[marcoieni]

Add timeout to the disk clean space operation introduced in #145311

As reported in #145311 (comment) the wait can be stuck.

[marcoieni]

@bors try jobs=msvc,mingw

[Kobzol]

You can r=me if CI is green.

[rustbot]

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[marcoieni]

r? Kobzol

[rust-bors]

☀️ Try build successful (CI)
Build commit: 853c6a1 (853c6a1261af39eff1a4ad20c276453fb89721be, parent: 425a9c0a0e365c0b8c6cfd00c2ded83a73bed9a0)

[Kobzol]

@bors r+

[bors]

📌 Commit 4f72482 has been approved by Kobzol

It is now in the queue for this repository.

[ChrisDenton]

Oh, looking at this I think an issue here may be the use of PIDs. After the process exits, the PID can be reused by new processes.

[Kobzol]

Maybe we could also store and check the process name?

[ChrisDenton]

Possibly. Though it's a shell script so that might not be too useful. Another option is to store and check the process start time. PID + start time will be unique.

A more invasive change would be to keep the cleanup script running until it's told to finish (or maybe killed). But this requires some way to communicate either when something is waiting or when it's done.

[ChrisDenton]

Since it seems like the issue is seriously affecting the queue, I'll bump the priority on this workaround in case it doesn't make the next rollup.

@bors p=6

[jhpratt]

Good idea. This isn't included in the 33-PR rollup, so anything that can help is a good idea.

[bors]

⌛ Testing commit 4f72482 with merge b96868f...

[bors]

☀️ Test successful - checks-actions
Approved by: Kobzol
Pushing b96868f to master...

[github-actions]

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 9eb4a26 (parent) -> b96868f (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard b96868fa2ef174b0a5aeb3bf041b3a5b517f11f8 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

1. x86_64-apple-2: 8369.3s -> 4877.4s (-41.7%)
2. x86_64-mingw-1: 12352.6s -> 9890.2s (-19.9%)
3. aarch64-apple: 6408.5s -> 5232.7s (-18.3%)
4. i686-msvc-1: 11528.9s -> 10171.7s (-11.8%)
5. x86_64-msvc-ext2: 7027.9s -> 6225.4s (-11.4%)
6. x86_64-msvc-1: 9955.7s -> 8872.4s (-10.9%)
7. x86_64-msvc-2: 7803.7s -> 6957.6s (-10.8%)
8. dist-apple-various: 5320.5s -> 4762.1s (-10.5%)
9. dist-arm-linux-gnueabi: 4852.6s -> 5331.5s (9.9%)
10. x86_64-apple-1: 9093.2s -> 8202.3s (-9.8%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

[rust-timer]

Finished benchmarking commit (b96868f): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	1.3%	[1.3%, 1.3%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-4.4%	[-4.4%, -4.4%]	1
Improvements ✅ (secondary)	-0.4%	[-0.4%, -0.4%]	1
All ❌✅ (primary)	-1.6%	[-4.4%, 1.3%]	2

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (primary -3.5%, secondary 4.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	4.6%	[4.6%, 4.6%]	1
Improvements ✅ (primary)	-3.5%	[-3.5%, -3.5%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-3.5%	[-3.5%, -3.5%]	1

Binary size

Results (primary -0.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.4%	[-0.4%, -0.4%]	3
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.4%	[-0.4%, -0.4%]	3

Bootstrap: 469.299s -> 470.04s (0.16%)
Artifact size: 377.68 MiB -> 377.69 MiB (0.00%)