Rollup of 10 pull requests #145844

Zalathar · 2025-08-25T09:52:25Z

Successful merges:

Dial down detail of B-tree description #135761 (Dial down detail of B-tree description)
Account for impossible bounds making seemingly unsatisfyable dyn-to-dyn casts #145620 (Account for impossible bounds making seemingly unsatisfyable dyn-to-dyn casts)
Fix attribute target checking for macro calls #145788 (Fix attribute target checking for macro calls)
bootstrap.py: Improve CPU detection on NetBSD #145794 (bootstrap.py: Improve CPU detection on NetBSD)
cg_llvm: Replace the llvm::Bool typedef with a proper newtype #145817 (cg_llvm: Replace the llvm::Bool typedef with a proper newtype)
raw-dylib-elf: set correct DT_VERDEFNUM #145820 (raw-dylib-elf: set correct DT_VERDEFNUM)
Update bitflags to 2.9.3. #145828 (Update bitflags to 2.9.3.)
Remove the lifetime from ExpTokenPair/SeqSep. #145830 (Remove the lifetime from ExpTokenPair/SeqSep.)
Remove outdated bug comments #145836 (Remove outdated bug comments)
rustc-dev-guide subtree update #145842 (rustc-dev-guide subtree update)

r? @ghost
@rustbot modify labels: rollup

Losslessly optimizes all of the PNG files in the repo. Done with: ``` oxipng -o max -a -s oxipng -o max --zopfli -a -s ```

add gpu device side instructions

Losslessly optimize PNG files

Update bootstrapping docs to account for new stage meanings

…yn casts

...and add adaptation of detection for some arm variants.

I thought tidy would be more allergic to 80-coloumn overflow, but so be it.

fixes 134088, though it is a shame to lose some of this wonderful detail.

Suggest using `@bors try jobs=...`

Signed-off-by: Jonathan Brouwer <[email protected]>

This avoids the need for `#![allow(non_upper_case_globals)]`.

Previously it indicated a single version, regardless of their count. Observed in: davidlattimore/wild#1041

The `bitflags!` macro in the latest release has slightly streamlined codegen. See bitflags/bitflags#458 for details.

`TokenKind` now impls `Copy`, so we can store it directly rather than a reference.

This updates the rust-version file to a1dbb44.

Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: a1dbb44 Filtered ref: c2339048a82c55166f9b9ee83fd618be252a6e23 This merge was created using https://github.com/rust-lang/josh-sync.

Removed comments related to a bug in Repeat variant.

Rustc pull update

Remove outdated bug comments The related issue rust-lang#74836 was closed. This PR may close rust-lang#145835. Details are in the issue rust-lang#145835.

rustc-dev-guide subtree update Subtree update of `rustc-dev-guide` to rust-lang/rustc-dev-guide@a03c1ef. Created using https://github.com/rust-lang/josh-sync. r? `@ghost`

Zalathar · 2025-08-25T09:52:48Z

@bors r+ rollup=never p=5

bors · 2025-08-25T09:52:50Z

📌 Commit 0119d16 has been approved by Zalathar

It is now in the queue for this repository.

Zalathar · 2025-08-25T09:53:53Z

@bors try jobs=test-various,dist-various-2,x86_64-gnu-llvm-19-3

Rollup of 10 pull requests try-job: test-various try-job: dist-various-2 try-job: x86_64-gnu-llvm-19-3

bors · 2025-08-25T10:31:36Z

⌛ Testing commit 0119d16 with merge b779120...

rust-bors · 2025-08-25T12:05:59Z

☀️ Try build successful (CI)
Build commit: cd56bed (cd56beda82422405929d2928af462e98b4a31434, parent: ee361e8fca1c30e13e7a31cc82b64c045339d3a8)

bors · 2025-08-25T13:49:26Z

☀️ Test successful - checks-actions
Approved by: Zalathar
Pushing b779120 to master...

github-actions · 2025-08-25T13:52:16Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing ee361e8 (parent) -> b779120 (this PR)

Test differences

Show 110 test diffs

Stage 1

[ui] tests/ui/attributes/attr-on-mac-call.rs: [missing] -> pass (J0)
[ui] tests/ui/coercion/fake-sized-ptr-cast.rs: [missing] -> pass (J0)

Stage 2

[ui] tests/ui/attributes/attr-on-mac-call.rs: [missing] -> pass (J1)
[ui] tests/ui/coercion/fake-sized-ptr-cast.rs: [missing] -> pass (J1)

Additionally, 106 doctest diffs were found. These are ignored, as they are noisy.

Job group index

J0: x86_64-gnu-llvm-19-3, x86_64-gnu-llvm-20-3
J1: aarch64-apple, aarch64-gnu, aarch64-gnu-llvm-19-1, aarch64-msvc-1, arm-android, armhf-gnu, dist-i586-gnu-i586-i686-musl, i686-gnu-1, i686-gnu-nopt-1, i686-msvc-1, test-various, x86_64-gnu, x86_64-gnu-llvm-19, x86_64-gnu-llvm-19-2, x86_64-gnu-llvm-20-2, x86_64-gnu-nopt, x86_64-gnu-stable, x86_64-mingw-1, x86_64-msvc-1

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard b779120cad2c93e53c0dfb7007c1214b2b275183 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-x86_64-apple: 8879.5s -> 7160.0s (-19.4%)
x86_64-gnu-llvm-19: 2862.2s -> 2446.7s (-14.5%)
dist-x86_64-msvc-alt: 10246.0s -> 9195.7s (-10.3%)
pr-check-2: 2216.0s -> 2393.0s (8.0%)
x86_64-gnu-tools: 3827.8s -> 3548.6s (-7.3%)
x86_64-gnu-llvm-19-1: 3582.4s -> 3356.9s (-6.3%)
i686-gnu-1: 8629.5s -> 8104.0s (-6.1%)
dist-apple-various: 5059.4s -> 4764.4s (-5.8%)
aarch64-gnu-debug: 4543.2s -> 4805.0s (5.8%)
armhf-gnu: 5114.9s -> 5406.3s (5.7%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-08-25T13:52:20Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#135761	Dial down detail of B-tree description	`7ef8afd3d5cef807a1e0013161cb317e2a7be9e8` (link)
#145620	Account for impossible bounds making seemingly unsatisfyabl…	`4819dbe26af018ad9c1dbf094532f45160768ee7` (link)
#145788	Fix attribute target checking for macro calls	`3f8fcd21d0bdb803f4d650f69b7628a8ee4bffbc` (link)
#145794	bootstrap.py: Improve CPU detection on NetBSD	`b0977d281393a60786ab8393c1b40216d2495a53` (link)
#145817	cg_llvm: Replace the `llvm::Bool` typedef with a proper new…	`54d49d0657a55d7cae31ddaa943a1a1cb6ea3742` (link)
#145820	raw-dylib-elf: set correct `DT_VERDEFNUM`	`e1df26626a881340afcb1511b7f5638dacd5ac4a` (link)
#145828	Update `bitflags` to 2.9.3.	`3380ca972750a12e008f5c1abcc4d0c9dfced3f3` (link)
#145830	Remove the lifetime from `ExpTokenPair`/`SeqSep`.	`f1e9d58bb4a1dbfde5d6819e9bfc3ba5e9d7a9d2` (link)
#145836	Remove outdated bug comments	`9a14c6f3ce33c0d9b2d1f7dcbc2359df8d85ee12` (link)
#145842	rustc-dev-guide subtree update	`5e1473d33d71b06fc8917d78975a36367c7ed69a` (link)

previous master: ee361e8fca

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2025-08-25T15:00:42Z

Finished benchmarking commit (b779120): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.8%	[0.8%, 0.8%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary 2.5%, secondary -2.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.5%	[2.5%, 2.5%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.2%	[-2.2%, -2.2%]	1
All ❌✅ (primary)	2.5%	[2.5%, 2.5%]	1

Cycles

Results (secondary 3.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.2%	[3.0%, 3.4%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 467.59s -> 467.387s (-0.04%)
Artifact size: 378.37 MiB -> 378.40 MiB (0.01%)

lolbinarycat and others added 30 commits August 11, 2025 13:34

Update bootstrapping docs to account for new stage meanings

f486a6f

see rust-lang#145253 for reference.

Update for changes to macro parser

0cf5b67

Losslessly optimize PNG files

5ca2b9e

Losslessly optimizes all of the PNG files in the repo. Done with: ``` oxipng -o max -a -s oxipng -o max --zopfli -a -s ```

add gpu device side instructions

88c42a2

Merge pull request rust-lang#2524 from rust-lang/offload-device

636e147

add gpu device side instructions

Merge pull request rust-lang#2549 from lumiscosity/optimize-images

b7b98ec

Losslessly optimize PNG files

Merge pull request rust-lang#2546 from lolbinarycat/patch-7

519854f

Update bootstrapping docs to account for new stage meanings

suggest using @bors try jobs=...

78c552d

Rewrite try jobs section a bit

c27f6e5

Account for impossible bounds making seemingly unsatisfyable dyn-to-d…

c957c4e

…yn casts

Nits

e0fb6eb

bootstrap.py: Improve CPU detection on NetBSD,

45bcbd9

...and add adaptation of detection for some arm variants.

bootstrap.py: follow up tidy output from CI.

3a2392b

I thought tidy would be more allergic to 80-coloumn overflow, but so be it.

Merge pull request rust-lang#2548 from joshtriplett/macro-parser

c12ab84

bootstrap.py: follow up more 'tidy' insistence (string quotes).

2f1b6d1

Dial down detail of B-tree description

3f339ab

fixes 134088, though it is a shame to lose some of this wonderful detail.

focus more on ordered aspect and restore old comments

bb7993f

Prevent confusion with insertion-ordered maps.

1b77387

Warn on macro calls for attributes that had this behaviour previously

3851e6c

Merge pull request rust-lang#2550 from WaffleLapkin/try-bors

06608ba

Suggest using `@bors try jobs=...`

Regression test for attributes on macro calls

fe81a79

Signed-off-by: Jonathan Brouwer <[email protected]>

Replace the llvm::Bool typedef with a proper newtype

455a67b

Rename llvm::Bool aliases to standard const case

b4e97e5

This avoids the need for `#![allow(non_upper_case_globals)]`.

raw-dylib-elf: set correct DT_VERDEFNUM

b1be775

Previously it indicated a single version, regardless of their count. Observed in: davidlattimore/wild#1041

Update bitflags to 2.9.3.

63b26c5

The `bitflags!` macro in the latest release has slightly streamlined codegen. See bitflags/bitflags#458 for details.

Remove the lifetime from ExpTokenPair/SeqSep.

a06c388

`TokenKind` now impls `Copy`, so we can store it directly rather than a reference.

Prepare for merging from rust-lang/rust

c4cd29b

This updates the rust-version file to a1dbb44.

Merge ref 'a1dbb443527b' from rust-lang/rust

721337b

Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: a1dbb44 Filtered ref: c2339048a82c55166f9b9ee83fd618be252a6e23 This merge was created using https://github.com/rust-lang/josh-sync.

Remove bug comments from Repeat variant

baff99c

Removed comments related to a bug in Repeat variant.

Merge pull request rust-lang#2551 from rust-lang/rustc-pull

d1d1fb3

Rustc pull update

Zalathar added 2 commits August 25, 2025 19:52

Rollup merge of rust-lang#145836 - minux-lee:issue-145835, r=RalfJung

a12516f

Remove outdated bug comments The related issue rust-lang#74836 was closed. This PR may close rust-lang#145835. Details are in the issue rust-lang#145835.

Rollup merge of rust-lang#145842 - tshepang:rdg-sync, r=jieyouxu

0119d16

rustc-dev-guide subtree update Subtree update of `rustc-dev-guide` to rust-lang/rustc-dev-guide@a03c1ef. Created using https://github.com/rust-lang/josh-sync. r? `@ghost`

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 25, 2025

This comment has been minimized.

Sign in to view

rust-bors bot added a commit that referenced this pull request Aug 25, 2025

Auto merge of #145844 - Zalathar:rollup-4kdll9t, r=<try>

cd56bed

Rollup of 10 pull requests try-job: test-various try-job: dist-various-2 try-job: x86_64-gnu-llvm-19-3

bors mentioned this pull request Aug 25, 2025

Support non-defining uses in HIR typeck #145711

Merged

bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 25, 2025

bors merged commit b779120 into rust-lang:master Aug 25, 2025
12 checks passed

rustbot added this to the 1.91.0 milestone Aug 25, 2025

Zalathar deleted the rollup-4kdll9t branch August 25, 2025 13:52

bors mentioned this pull request Aug 25, 2025

Forbid freely casting lifetime bounds of dyn-types #136776

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 10 pull requests #145844

Rollup of 10 pull requests #145844

Uh oh!

Zalathar commented Aug 25, 2025 •

edited by rustbot

Loading

Uh oh!

Zalathar commented Aug 25, 2025

Uh oh!

bors commented Aug 25, 2025

Uh oh!

Zalathar commented Aug 25, 2025

Uh oh!

This comment has been minimized.

bors commented Aug 25, 2025

Uh oh!

rust-bors bot commented Aug 25, 2025

Uh oh!

bors commented Aug 25, 2025

Uh oh!

Uh oh!

github-actions bot commented Aug 25, 2025

Stage 1

Stage 2

Uh oh!

rust-timer commented Aug 25, 2025

Uh oh!

rust-timer commented Aug 25, 2025

Uh oh!

Uh oh!

Rollup of 10 pull requests #145844

Rollup of 10 pull requests #145844

Uh oh!

Conversation

Zalathar commented Aug 25, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Zalathar commented Aug 25, 2025

Uh oh!

bors commented Aug 25, 2025

Uh oh!

Zalathar commented Aug 25, 2025

Uh oh!

This comment has been minimized.

bors commented Aug 25, 2025

Uh oh!

rust-bors bot commented Aug 25, 2025

Uh oh!

bors commented Aug 25, 2025

Uh oh!

Uh oh!

github-actions bot commented Aug 25, 2025

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Aug 25, 2025

Uh oh!

rust-timer commented Aug 25, 2025

Overall result: ❌ regressions - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Uh oh!

Zalathar commented Aug 25, 2025 •

edited by rustbot

Loading