Skip to content

Implement clamp_min and clamp_max #147786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Kyuuhachi wants to merge 1 commit into from
Closed

Implement clamp_min and clamp_max #147786

Kyuuhachi wants to merge 1 commit into from

Conversation

@Kyuuhachi
Copy link
Contributor

@Kyuuhachi Kyuuhachi commented Oct 16, 2025

Implements #147781.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 16, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 16, 2025

r? @joboet

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@Kyuuhachi Kyuuhachi mentioned this pull request Oct 16, 2025
Open
5 tasks
joboet
joboet requested changes Oct 21, 2025
View reviewed changes
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 21, 2025
@Kyuuhachi
Copy link
Contributor Author

Kyuuhachi commented Oct 22, 2025

Oops. Silly copypaste mistakes.

@Kyuuhachi
Copy link
Contributor Author

Kyuuhachi commented Oct 23, 2025

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 23, 2025
@joboet
Copy link
Member

joboet commented Oct 30, 2025

r=me after squashing commits

@bors delegate+

@bors
Copy link
Collaborator

bors commented Oct 30, 2025

✌️ @Kyuuhachi, you can now approve this pull request!

If @joboet told you to "r=me" after making some further change, please make that change, then do @bors r=@joboet

@Kyuuhachi
Add Ord::clamp_min and clamp_max
af5b798 
Add example clamping by length

Implement clamp_min/max on floats

Fix copypaste mistakes in tests
@rustbot
Copy link
Collaborator

rustbot commented Oct 31, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@Kyuuhachi
Copy link
Contributor Author

Kyuuhachi commented Oct 31, 2025

@bors r=@joboet

@bors
Copy link
Collaborator

bors commented Oct 31, 2025

📌 Commit af5b798 has been approved by joboet

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 31, 2025
Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 1, 2025
@Zalathar
Rollup merge of rust-lang#147786 - Kyuuhachi:clamp-min-max, r=joboet
f284588 
Implement clamp_min and clamp_max

Implements rust-lang#147781.
@Zalathar Zalathar mentioned this pull request Nov 1, 2025
Closed
Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 1, 2025
@Zalathar
Rollup merge of rust-lang#147786 - Kyuuhachi:clamp-min-max, r=joboet
48ee427 
Implement clamp_min and clamp_max

Implements rust-lang#147781.
@Zalathar Zalathar mentioned this pull request Nov 1, 2025
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 1, 2025
@matthiaskrgr
Rollup merge of rust-lang#147786 - Kyuuhachi:clamp-min-max, r=joboet
5effb6e 
Implement clamp_min and clamp_max

Implements rust-lang#147781.
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 1, 2025
Closed
@Zalathar
Copy link
Member

Zalathar commented Nov 1, 2025

Failed in rollup in test-various: #148354 (comment)

@bors r-

@bors bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Nov 1, 2025
@bors bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Nov 1, 2025
@matthiaskrgr
Copy link
Member

matthiaskrgr commented Nov 1, 2025

@bors r- #148354 (comment)

@bors
Copy link
Collaborator

bors commented Dec 1, 2025

☔ The latest upstream changes (presumably #149510) made this pull request unmergeable. Please resolve the merge conflicts.

@Kyuuhachi Kyuuhachi mentioned this pull request Dec 16, 2025
Open
@Kyuuhachi
Copy link
Contributor Author

Kyuuhachi commented Dec 16, 2025

Closing as superseded by #150075.

@Kyuuhachi Kyuuhachi closed this Dec 16, 2025
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joboet joboet joboet approved these changes

Assignees

@joboet joboet

Labels

T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Kyuuhachi @rustbot @joboet @bors @Zalathar @matthiaskrgr