tidy: Detect outdated workspaces in workspace list #149417

clubby789 · 2025-11-28T11:49:09Z

Detects the case in #149415 (will pass CI once that lands).

rustbot · 2025-11-28T11:49:12Z

The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging.

cc @davidtwco, @wesleywiser

rustbot · 2025-11-28T11:49:15Z

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Mark-Simulacrum

r=me presuming that check exists or we have an issue tracking adding it (or there's a good reason to not add it)

View changes since this review

Mark-Simulacrum · 2025-12-08T00:45:43Z

src/tools/tidy/src/deps.rs

+            if path == "." { root.to_path_buf() } else { t!(root.join(path).canonicalize()) };
+        let canonicalized_root_real = t!(metadata.workspace_root.canonicalize());
+        if canonicalized_root_real != canonicalized_root {
+            check.error(format!("{path} is part of another workspace, remove from `WORKSPACES` ({WORKSPACE_LOCATION})"));


We do have a check somewhere that we're covering all workspaces, right? Or is that missing?

There is no such check. And in fact we don't cover all workspaces. There are a bunch of workspaces that are neither used by x.py nor vendored. All workspaces that aren't vendored can't be linted by tidy without breaking offline builds.

Ack. Yeah, I guess that makes sense. Might be good to try to find a way to at least check those used by x.py, but not sure how we'd actually accomplish that in a useful way.

Mark-Simulacrum · 2025-12-10T03:23:33Z

@bors r+

bors · 2025-12-10T03:23:36Z

📌 Commit c906b2a has been approved by Mark-Simulacrum

It is now in the queue for this repository.

…Mark-Simulacrum tidy: Detect outdated workspaces in workspace list Detects the case in rust-lang#149415 (will pass CI once that lands).

Rollup of 12 pull requests Successful merges: - #147602 (Deduplicate higher-ranked lifetime capture errors in impl Trait) - #147725 (Remove -Zoom=panic) - #148294 (callconv: fix mips64 aggregate argument passing for C FFI) - #148491 ( Correctly provide suggestions when encountering `async fn` with a `dyn Trait` return type) - #149417 (tidy: Detect outdated workspaces in workspace list) - #149458 (Run clippy on cg_gcc in CI) - #149679 (Restrict spe_acc to PowerPC SPE targets) - #149781 (Don't suggest wrapping attr in unsafe if it may come from proc macro) - #149795 (Use `let`...`else` instead of `match foo { ... _ => return };` and `if let ... else return` in std) - #149816 (Make typo in field and name suggestions verbose) - #149824 (Add a regression test for issue 145748) - #149826 (compiletest: tidy up `adb_path`/`adb_test_dir` handling) r? `@ghost` `@rustbot` modify labels: rollup

matthiaskrgr · 2025-12-10T07:01:24Z

@bors r-
looks like this failed here
#149830 (comment)

rustbot · 2025-12-10T19:36:12Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

clubby789 · 2025-12-10T19:36:38Z

@bors try jobs=x86_64-msvc-2

tidy: Detect outdated workspaces in workspace list try-job: x86_64-msvc-2

rust-bors · 2025-12-10T19:49:07Z

💔 Test for a1d5de2 failed: CI. Failed jobs:

try - x86_64-msvc-2 (web logs, enhanced plaintext logs)

clubby789 · 2025-12-10T21:30:00Z

@bors try jobs=x86_64-msvc-2

tidy: Detect outdated workspaces in workspace list try-job: x86_64-msvc-2

clubby789 · 2025-12-10T21:42:04Z

Hmm, D:\a\rust\rust != \\?\D:\a\rust\rust (#42869)

rust-bors · 2025-12-10T21:44:32Z

💔 Test for 486433f failed: CI. Failed jobs:

try - x86_64-msvc-2 (web logs, enhanced plaintext logs)

clubby789 · 2025-12-10T21:45:56Z

@bors try jobs=x86_64-msvc-2

tidy: Detect outdated workspaces in workspace list try-job: x86_64-msvc-2

rust-bors · 2025-12-10T23:56:59Z

☀️ Try build successful (CI)
Build commit: f1b3570 (f1b357015140f0fecaf36128b35a247dcdba4ec2, parent: a9ac706b5f79e90d7255e3acc343fffba47cc5ef)

clubby789 · 2025-12-11T00:58:29Z

@rustbot ready

rustbot added A-tidy Area: The tidy tool S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 28, 2025

rustbot assigned Mark-Simulacrum Nov 28, 2025

rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Nov 28, 2025

This comment has been minimized.

Sign in to view

clubby789 force-pushed the stale-workspace-list branch from 7e4f2b3 to c906b2a Compare November 28, 2025 12:14

This comment has been minimized.

Sign in to view

clubby789 closed this Nov 30, 2025

rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 30, 2025

clubby789 reopened this Nov 30, 2025

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 30, 2025

Mark-Simulacrum reviewed Dec 8, 2025

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 10, 2025

Zalathar mentioned this pull request Dec 10, 2025

Rollup of 13 pull requests #149828

Closed

Zalathar mentioned this pull request Dec 10, 2025

Rollup of 12 pull requests #149830

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 10, 2025

clubby789 force-pushed the stale-workspace-list branch from c906b2a to 8143abc Compare December 10, 2025 19:36

rust-bors bot added a commit that referenced this pull request Dec 10, 2025

Auto merge of #149417 - clubby789:stale-workspace-list, r=<try>

a1d5de2

tidy: Detect outdated workspaces in workspace list try-job: x86_64-msvc-2

This comment has been minimized.

Sign in to view

clubby789 force-pushed the stale-workspace-list branch from 8143abc to 1d7d030 Compare December 10, 2025 21:29

This comment has been minimized.

Sign in to view

rust-bors bot added a commit that referenced this pull request Dec 10, 2025

Auto merge of #149417 - clubby789:stale-workspace-list, r=<try>

486433f

tidy: Detect outdated workspaces in workspace list try-job: x86_64-msvc-2

This comment has been minimized.

Sign in to view

tidy: Detect outdated workspaces in workspace list

4e51a8d

clubby789 force-pushed the stale-workspace-list branch from 1d7d030 to 4e51a8d Compare December 10, 2025 21:45

This comment has been minimized.

Sign in to view

rust-bors bot added a commit that referenced this pull request Dec 10, 2025

Auto merge of #149417 - clubby789:stale-workspace-list, r=<try>

f1b3570

tidy: Detect outdated workspaces in workspace list try-job: x86_64-msvc-2

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 11, 2025

Uh oh!

tidy: Detect outdated workspaces in workspace list #149417

Are you sure you want to change the base?

tidy: Detect outdated workspaces in workspace list #149417

Conversation

clubby789 commented Nov 28, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Nov 28, 2025

Uh oh!

rustbot commented Nov 28, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

Mark-Simulacrum left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Mark-Simulacrum Dec 8, 2025

Choose a reason for hiding this comment

Uh oh!

bjorn3 Dec 8, 2025

Choose a reason for hiding this comment

Uh oh!

Mark-Simulacrum Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

Mark-Simulacrum commented Dec 10, 2025

Uh oh!

bors commented Dec 10, 2025

Uh oh!

matthiaskrgr commented Dec 10, 2025

Uh oh!

rustbot commented Dec 10, 2025

Uh oh!

clubby789 commented Dec 10, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors bot commented Dec 10, 2025

Uh oh!

clubby789 commented Dec 10, 2025

Uh oh!

This comment has been minimized.

clubby789 commented Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

rust-bors bot commented Dec 10, 2025

Uh oh!

clubby789 commented Dec 10, 2025

Uh oh!

This comment has been minimized.

rust-bors bot commented Dec 10, 2025

Uh oh!

clubby789 commented Dec 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

clubby789 commented Nov 28, 2025 •

edited by rustbot

Loading

Mark-Simulacrum left a comment •

edited by rustbot

Loading

clubby789 commented Dec 10, 2025 •

edited

Loading