[PERF] How much does lowering the spans in AttrPath matter?

[JonathanBrouwer]

Not sure how correct this is, don't merge this.

[JonathanBrouwer]

@bors try @rust-timer queue

[rust-bors]

☀️ Try build successful (CI)
Build commit: d9eae17 (d9eae17767db0f7c6391226cad0d92eee5466f69, parent: 5bc345055b06dc096b01bc6d1e0cbe92d3cc630e)

[rust-timer]

Finished benchmarking commit (d9eae17): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.2%, 0.5%]	2
Regressions ❌ (secondary)	1.9%	[1.9%, 1.9%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.2%	[-0.2%, -0.2%]	3
All ❌✅ (primary)	0.3%	[0.2%, 0.5%]	2

Max RSS (memory usage)

Results (primary -1.5%, secondary 3.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.1%	[3.1%, 3.1%]	1
Improvements ✅ (primary)	-1.5%	[-1.5%, -1.5%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-1.5%	[-1.5%, -1.5%]	1

Cycles

Results (primary -2.6%, secondary -3.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.6%	[-2.6%, -2.6%]	1
Improvements ✅ (secondary)	-3.8%	[-3.8%, -3.8%]	1
All ❌✅ (primary)	-2.6%	[-2.6%, -2.6%]	1

Binary size

Results (primary -0.0%, secondary -0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.0%	[0.0%, 0.0%]	4
Improvements ✅ (primary)	-0.0%	[-0.0%, -0.0%]	6
Improvements ✅ (secondary)	-0.1%	[-0.1%, -0.1%]	4
All ❌✅ (primary)	-0.0%	[-0.0%, -0.0%]	6

Bootstrap: 473.701s -> 471.996s (-0.36%)
Artifact size: 389.02 MiB -> 389.02 MiB (-0.00%)

[JonathanBrouwer]

@bors try @rust-timer queue

[JonathanBrouwer]

@bors try cancel

[rust-bors]

Try build cancelled. Cancelled workflows:

• https://github.com/rust-lang/rust/actions/runs/20057460189

[JonathanBrouwer]

@bors try

[rust-bors]

☀️ Try build successful (CI)
Build commit: f3efcc9 (f3efcc98a6728b73780875235e1a77ae38c2c3ba, parent: 018d26972e523b8d28f9579056185a1713949dfd)

[rust-timer]

Finished benchmarking commit (f3efcc9): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.3%	[0.1%, 0.5%]	2
Improvements ✅ (primary)	-0.2%	[-0.3%, -0.1%]	7
Improvements ✅ (secondary)	-0.2%	[-0.5%, -0.1%]	24
All ❌✅ (primary)	-0.2%	[-0.3%, -0.1%]	7

Max RSS (memory usage)

Results (primary -2.3%, secondary -1.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.3%	[-3.5%, -0.6%]	3
Improvements ✅ (secondary)	-1.2%	[-1.2%, -1.2%]	1
All ❌✅ (primary)	-2.3%	[-3.5%, -0.6%]	3

Cycles

Results (primary 2.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.1%	[2.1%, 2.1%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.1%	[2.1%, 2.1%]	1

Binary size

Results (primary -0.1%, secondary -0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.1%	[-0.2%, -0.0%]	32
Improvements ✅ (secondary)	-0.0%	[-0.1%, -0.0%]	15
All ❌✅ (primary)	-0.1%	[-0.2%, -0.0%]	32

Bootstrap: 472.223s -> 472.69s (0.10%)
Artifact size: 389.03 MiB -> 389.01 MiB (-0.01%)

[bors]

☔ The latest upstream changes (presumably #149645) made this pull request unmergeable. Please resolve the merge conflicts.

[rust-log-analyzer]

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

tests/ui/should_impl_trait/method_list_2.rs (revision `edition2021`) ... ok
tests/ui/size_of_in_element_count/functions.rs ... ok

FAILED TEST: tests/ui/cognitive_complexity.rs
command: CLIPPY_CONF_DIR="tests" RUSTC_ICE="0" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/clippy-driver" "--error-format=json" "--emit=metadata" "-Aunused" "-Ainternal_features" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Dwarnings" "-Ldependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/release/deps" "--sysroot=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--test" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/ui_test/0/tests/ui" "tests/ui/cognitive_complexity.rs" "--extern" "futures=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/debug/deps/libfutures-56bbad2987f1a076.rlib" "--extern" "futures=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/debug/deps/libfutures-56bbad2987f1a076.rmeta" "--extern" "itertools=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/debug/deps/libitertools-49215d6c78da5485.rlib" "--extern" "itertools=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/debug/deps/libitertools-49215d6c78da5485.rmeta" "--extern" "libc=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/debug/deps/liblibc-9fd0632ab0adaa16.rlib" "--extern" "libc=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/debug/deps/liblibc-9fd0632ab0adaa16.rmeta" "--extern" "parking_lot=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/debug/deps/libparking_lot-cc8a335fe9146be3.rlib" "--extern" "parking_lot=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/debug/deps/libparking_lot-cc8a335fe9146be3.rmeta" "--extern" "quote=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/debug/deps/libquote-aa12901b2adae6fc.rlib" "--extern" "quote=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/debug/deps/libquote-aa12901b2adae6fc.rmeta" "--extern" "regex=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/debug/deps/libregex-6ecd666cd642c024.rlib" "--extern" "regex=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/debug/deps/libregex-6ecd666cd642c024.rmeta" "--extern" "serde=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/debug/deps/libserde-6629799eafe4f0d4.rlib" "--extern" "serde=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/debug/deps/libserde-6629799eafe4f0d4.rmeta" "--extern" "syn=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/debug/deps/libsyn-b0c36228d90d575f.rlib" "--extern" "syn=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/debug/deps/libsyn-b0c36228d90d575f.rmeta" "--extern" "tokio=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/debug/deps/libtokio-6ddc89563990f085.rlib" "--extern" "tokio=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/debug/deps/libtokio-6ddc89563990f085.rmeta" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/debug/deps" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/debug/deps" "--edition" "2024"

error: actual output differed from expected
Execute `./x test src/tools/clippy --bless` to update `tests/ui/cognitive_complexity.stderr` to the actual output
--- tests/ui/cognitive_complexity.stderr
+++ <stderr output>
---

error: the function has a cognitive complexity of (7/1)
##[error]  --> tests/ui/cognitive_complexity.rs:98:4
   |
LL | fn kaboom() {
   |    ^^^^^^
   |
   = help: you could split it up into multiple smaller functions

error: the function has a cognitive complexity of (2/1)
---

error: the function has a cognitive complexity of (2/1)
##[error]  --> tests/ui/cognitive_complexity.rs:262:4
   |
LL | fn barrrr() {
   |    ^^^^^^
   |
   = help: you could split it up into multiple smaller functions

error: the function has a cognitive complexity of (3/1)
##[error]  --> tests/ui/cognitive_complexity.rs:274:4
   |
LL | fn barrrr2() {
   |    ^^^^^^^
   |
   = help: you could split it up into multiple smaller functions

error: the function has a cognitive complexity of (2/1)
---

error: the function has a cognitive complexity of (2/1)
##[error]  --> tests/ui/cognitive_complexity.rs:337:4
   |
LL | fn void(void: Void) {
   |    ^^^^
   |
   = help: you could split it up into multiple smaller functions

error: the function has a cognitive complexity of (8/1)
---

error: the function has a cognitive complexity of (2/1)
##[error]  --> tests/ui/cognitive_complexity.rs:413:13
   |
LL |     let x = |a: i32, b: i32| -> i32 {
   |             ^^^^^^^^^^^^^^^^
   |
   = help: you could split it up into multiple smaller functions

error: the function has a cognitive complexity of (2/1)
---

error: the function has a cognitive complexity of (7/1)
##[error]  --> tests/ui/cognitive_complexity.rs:98:4
   |
LL | fn kaboom() {
   |    ^^^^^^
   |
   = help: you could split it up into multiple smaller functions

error: the function has a cognitive complexity of (2/1)
---

error: the function has a cognitive complexity of (2/1)
##[error]  --> tests/ui/cognitive_complexity.rs:262:4
   |
LL | fn barrrr() {
   |    ^^^^^^
   |
   = help: you could split it up into multiple smaller functions

error: the function has a cognitive complexity of (3/1)
##[error]  --> tests/ui/cognitive_complexity.rs:274:4
   |
LL | fn barrrr2() {
   |    ^^^^^^^
   |
   = help: you could split it up into multiple smaller functions

error: the function has a cognitive complexity of (2/1)
---

error: the function has a cognitive complexity of (2/1)
##[error]  --> tests/ui/cognitive_complexity.rs:337:4
   |
LL | fn void(void: Void) {
   |    ^^^^
   |
   = help: you could split it up into multiple smaller functions

error: the function has a cognitive complexity of (8/1)
---

error: the function has a cognitive complexity of (2/1)
##[error]  --> tests/ui/cognitive_complexity.rs:413:13
   |
LL |     let x = |a: i32, b: i32| -> i32 {
   |             ^^^^^^^^^^^^^^^^
   |
   = help: you could split it up into multiple smaller functions

error: the function has a cognitive complexity of (2/1)