Skip to content

rustc_codegen_llvm: update alignment for double on AIX#149880

Merged
bors merged 1 commit intorust-lang:mainfrom
durin42:llvm-22-ppc-aix-layout
Jan 6, 2026
Merged

rustc_codegen_llvm: update alignment for double on AIX#149880
bors merged 1 commit intorust-lang:mainfrom
durin42:llvm-22-ppc-aix-layout

Conversation

@durin42
Copy link
Contributor

@durin42 durin42 commented Dec 11, 2025

This was recently fixed upstream in LLVM, so we update our default layout to match.

@rustbot label: +llvm-main

@rustbot
Copy link
Collaborator

rustbot commented Dec 11, 2025

These commits modify compiler targets.
(See the Target Tier Policy.)

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 11, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 11, 2025

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) label Dec 11, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@durin42 durin42 force-pushed the llvm-22-ppc-aix-layout branch from cd5658e to 2968372 Compare December 11, 2025 15:48
nikic
nikic reviewed Dec 15, 2025
View reviewed changes
davidtwco
davidtwco approved these changes Dec 19, 2025
View reviewed changes
Copy link
Member

@davidtwco davidtwco left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me after @nikic's comment is resolved

View changes since this review

@durin42 durin42 force-pushed the llvm-22-ppc-aix-layout branch from 2968372 to 80c2382 Compare January 5, 2026 19:08
@rustbot
Copy link
Collaborator

rustbot commented Jan 5, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@durin42
rustc_codegen_llvm: update alignment for double on AIX
accfc34 
This was recently fixed upstream in LLVM, so we update our default
layout to match.

@rustbot label: +llvm-main
@durin42 durin42 force-pushed the llvm-22-ppc-aix-layout branch from 80c2382 to accfc34 Compare January 5, 2026 19:09
@nikic
Copy link
Contributor

nikic commented Jan 5, 2026

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jan 5, 2026

📌 Commit accfc34 has been approved by nikic

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 5, 2026
Zalathar added a commit to Zalathar/rust that referenced this pull request Jan 6, 2026
@Zalathar
Rollup merge of rust-lang#149880 - durin42:llvm-22-ppc-aix-layout, r=…
ae1729b 
…nikic

rustc_codegen_llvm: update alignment for double on AIX

This was recently fixed upstream in LLVM, so we update our default layout to match.

`@rustbot` label: +llvm-main
@Zalathar Zalathar mentioned this pull request Jan 6, 2026
Closed
bors added a commit that referenced this pull request Jan 6, 2026
@bors
Auto merge of #150718 - Zalathar:rollup-x9dqkhk, r=Zalathar
612515a 
Rollup of 8 pull requests

Successful merges:

 - #144113 (Impls and impl items inherit `dead_code` lint level of the corresponding traits and trait items)
 - #149880 (rustc_codegen_llvm: update alignment for double on AIX)
 - #150668 (Unix implementation for stdio set/take/replace)
 - #150670 (THIR pattern building: Move all `thir::Pat` creation into `rustc_mir_build::thir::pattern`)
 - #150695 (MGCA: pretty printing for struct expressions and tuple calls )
 - #150698 (Improve comment clarity in candidate_may_shadow)
 - #150706 (Update wasm-component-ld)
 - #150710 (Update libc dependency of std)

r? `@ghost`
`@rustbot` modify labels: rollup
Zalathar added a commit to Zalathar/rust that referenced this pull request Jan 6, 2026
@Zalathar
Rollup merge of rust-lang#149880 - durin42:llvm-22-ppc-aix-layout, r=…
f5562b6 
…nikic

rustc_codegen_llvm: update alignment for double on AIX

This was recently fixed upstream in LLVM, so we update our default layout to match.

``@rustbot`` label: +llvm-main
@Zalathar Zalathar mentioned this pull request Jan 6, 2026
Closed
bors added a commit that referenced this pull request Jan 6, 2026
@bors
Auto merge of #150719 - Zalathar:rollup-k1dqcwc, r=Zalathar
94a6a42 
Rollup of 8 pull requests

Successful merges:

 - #144113 (Impls and impl items inherit `dead_code` lint level of the corresponding traits and trait items)
 - #149880 (rustc_codegen_llvm: update alignment for double on AIX)
 - #150412 (use PIDFD_GET_INFO ioctl when available)
 - #150668 (Unix implementation for stdio set/take/replace)
 - #150670 (THIR pattern building: Move all `thir::Pat` creation into `rustc_mir_build::thir::pattern`)
 - #150695 (MGCA: pretty printing for struct expressions and tuple calls )
 - #150698 (Improve comment clarity in candidate_may_shadow)
 - #150706 (Update wasm-component-ld)

r? `@ghost`
`@rustbot` modify labels: rollup
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jan 6, 2026
@JonathanBrouwer
Rollup merge of rust-lang#149880 - durin42:llvm-22-ppc-aix-layout, r=…
8d97991 
…nikic

rustc_codegen_llvm: update alignment for double on AIX

This was recently fixed upstream in LLVM, so we update our default layout to match.

```@rustbot``` label: +llvm-main
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jan 6, 2026
Closed
bors added a commit that referenced this pull request Jan 6, 2026
@bors
Auto merge of #150724 - JonathanBrouwer:rollup-7d2zq9o, r=JonathanBro…
c4862bc 
…uwer

Rollup of 11 pull requests

Successful merges:

 - #144113 (Impls and impl items inherit `dead_code` lint level of the corresponding traits and trait items)
 - #148339 (naked functions: emit `.private_extern` on macos)
 - #149880 (rustc_codegen_llvm: update alignment for double on AIX)
 - #150122 (Refactor function names of `rustc_ast_lowering`)
 - #150412 (use PIDFD_GET_INFO ioctl when available)
 - #150670 (THIR pattern building: Move all `thir::Pat` creation into `rustc_mir_build::thir::pattern`)
 - #150695 (MGCA: pretty printing for struct expressions and tuple calls )
 - #150698 (Improve comment clarity in candidate_may_shadow)
 - #150706 (Update wasm-component-ld)
 - #150707 (Fix ICE when transmute Assume field is invalid)
 - #150708 (Enable merge queue in new bors)

r? `@ghost`
`@rustbot` modify labels: rollup
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jan 6, 2026
Merged
bors added a commit that referenced this pull request Jan 6, 2026
@bors
Auto merge of #150724 - JonathanBrouwer:rollup-7d2zq9o, r=
46fb1e6 
Rollup of 11 pull requests

Successful merges:

 - #144113 (Impls and impl items inherit `dead_code` lint level of the corresponding traits and trait items)
 - #148339 (naked functions: emit `.private_extern` on macos)
 - #149880 (rustc_codegen_llvm: update alignment for double on AIX)
 - #150122 (Refactor function names of `rustc_ast_lowering`)
 - #150412 (use PIDFD_GET_INFO ioctl when available)
 - #150670 (THIR pattern building: Move all `thir::Pat` creation into `rustc_mir_build::thir::pattern`)
 - #150695 (MGCA: pretty printing for struct expressions and tuple calls )
 - #150698 (Improve comment clarity in candidate_may_shadow)
 - #150706 (Update wasm-component-ld)
 - #150707 (Fix ICE when transmute Assume field is invalid)
 - #150708 (Enable merge queue in new bors)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Jan 6, 2026
@bors
Auto merge of #150726 - JonathanBrouwer:rollup-yseerwy, r=JonathanBro…
4d73a00 
…uwer

Rollup of 10 pull requests

Successful merges:

 - #144113 (Impls and impl items inherit `dead_code` lint level of the corresponding traits and trait items)
 - #149880 (rustc_codegen_llvm: update alignment for double on AIX)
 - #150122 (Refactor function names of `rustc_ast_lowering`)
 - #150412 (use PIDFD_GET_INFO ioctl when available)
 - #150670 (THIR pattern building: Move all `thir::Pat` creation into `rustc_mir_build::thir::pattern`)
 - #150695 (MGCA: pretty printing for struct expressions and tuple calls )
 - #150698 (Improve comment clarity in candidate_may_shadow)
 - #150706 (Update wasm-component-ld)
 - #150707 (Fix ICE when transmute Assume field is invalid)
 - #150708 (Enable merge queue in new bors)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit dea8b8b into rust-lang:main Jan 6, 2026
11 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Jan 6, 2026
rust-timer added a commit that referenced this pull request Jan 6, 2026
@rust-timer
Unrolled build for #149880
e58cda2 
Rollup merge of #149880 - durin42:llvm-22-ppc-aix-layout, r=nikic

rustc_codegen_llvm: update alignment for double on AIX

This was recently fixed upstream in LLVM, so we update our default layout to match.

````@rustbot```` label: +llvm-main
@workingjubilee workingjubilee mentioned this pull request Jan 25, 2026
Open
@github-actions github-actions bot mentioned this pull request Jan 27, 2026
Draft
@RalfJung RalfJung mentioned this pull request Jan 31, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nikic nikic nikic left review comments

@davidtwco davidtwco davidtwco approved these changes

Assignees

@davidtwco davidtwco

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.94.0

Development

Successfully merging this pull request may close these issues.

6 participants

@durin42 @rustbot @rust-log-analyzer @nikic @bors @davidtwco