UnixStream/UnixListener on Windows #150428
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rustbot
added
O-windows
This comment has been minimized.
This comment has been minimized.
Member
|
r? libs |
Collaborator
|
No reviewers could be found from initial request |
Contributor
Author
|
@dtolnay Could you check this pr too? |
Mark-Simulacrum
requested changes
Dec 29, 2025
rustbot
added
S-waiting-on-author
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
5 tasks
Contributor
Author
|
@rustbot ready |
rustbot
added
S-waiting-on-review
Member
|
Let's try to re-roll again r? libs |
Mark-Simulacrum
requested changes
Jan 4, 2026
| use crate::{fmt, io, mem}; | ||
|
|
||
| #[cfg(not(doc))] | ||
| pub fn sockaddr_un(path: &Path) -> io::Result<(SOCKADDR_UN, usize)> { |
Member
There was a problem hiding this comment.
Reading https://devblogs.microsoft.com/commandline/af_unix-comes-to-windows/, it looks to me like abstract and unnamed sockets should both be supported by Windows as well. Presumably the implementation should as such more closely mirror library/std/src/os/unix/net/addr.rs?
That would also fix the problem in fmt::Debug, where you bail if it's not a path socket incorrectly; it would make more sense for me if it used the same strategy as the unix impl.
Contributor
Author
There was a problem hiding this comment.
Maybe abstract sockets not support by Windows. Set first byte of sun_path to zero cause code: 10022 when connect
Member
There was a problem hiding this comment.
Can you add an unresolved question to the tracking issue about that? It doesn't seem expected to me given:
The second category is the ‘abstract’ socket address where the first character in ‘sun_path’ is a null byte. Windows implementation of AF_UNIX socket can also accept abstract addresses. The one difference noteworthy here is that the Windows unix socket implementation currently does not support the autobind feature whereby an abstract address is auto-generated by the implementation on behalf of the user.
Maybe something is wrong with our setup or the blog post is stale...
Contributor
Author
There was a problem hiding this comment.
@Mark-Simulacrum seems like microsoft not impl full AF_UNIX yet. I will add this ref to tracking issue.
I suggest specifying in the documentation that only AF_UNIX SOCK_STREAM with TRUE paths is supported
rustbot
added
S-waiting-on-author
Contributor
Author
|
@rustbot ready |
rustbot
added
S-waiting-on-review
Member
|
r=me with commits squashed. |
Member
|
Actually, I think new bors can just do that... @bors squash r+ |
Contributor
|
Unknown argument "r+". Did you mean to use |
Member
|
@bors squash |
* af_unix on Windows * fmt
Contributor
|
🔨 2 commits were squashed into e515fae. |
rust-bors
bot
force-pushed
the
win-af-unix-2
branch
from
a8633be to
e515fae
Compare
Collaborator
|
Member
|
@bors r+ |
Contributor
rust-bors
bot
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 25, 2026
…acrum UnixStream/UnixListener on Windows Hi, I re impl this. Hope you test it. Document build and tests are successful on my Arch Linux.
Member
|
Failed in rollup: #151656 (comment) |
rust-bors
bot
added
S-waiting-on-author
Contributor
|
Commit e515fae has been unapproved. |
This comment has been minimized.
This comment has been minimized.
rust-bors bot
pushed a commit
that referenced
this pull request
Jan 26, 2026
UnixStream/UnixListener on Windows try-job: aarch64-msvc-1
Contributor
|
💔 Test for eaab0f6 failed: CI. Failed job:
|
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I re impl this. Hope you test it.
Document build and tests are successful on my Arch Linux.