Change bors build finished job to publish toolstate#150772
Change bors build finished job to publish toolstate#150772rust-bors[bot] merged 1 commit intorust-lang:mainfrom
bors build finished job to publish toolstate#150772Conversation
|
@bors try |
This comment has been minimized.
This comment has been minimized.
Change `bors build finished` job to `publish toolstate`
|
@bors r+ rollup=never |
|
☔ The latest upstream changes (presumably #151087) made this pull request unmergeable. Please resolve the merge conflicts. This pull request was unapproved. |
ca204cc to
0c57e8c
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
Rebased. @bors r=jieyouxu |
This comment has been minimized.
This comment has been minimized.
Change `bors build finished` job to `publish toolstate` Due to recent advancements in merge queue bot technology, we no longer need this job. We still use a simpler job to publish the toolstate on `auto` builds though. Should be merged once we get rid of homu.
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
💔 Test for 83aebb0 failed: CI. Failed job:
|
|
Uhm, that's bad, the rollup (#151129) just failed on the same thing. Is this test flaky? |
|
Possibly. If #151139 also fails, then I'd suggest closing the tree. |
|
I'll head to bed for the night, I'll leave that to someone else :) |
|
@bors retry (unrelated flaky test) |
Revert "avoid phi node for pointers flowing into Vec appends #130998" This reverts PR #130998 because the added test seems to be flaky / non-deterministic, and has been failing in unrelated PRs during merge CI: - #151129 (comment) - #150772 (comment) - #150925 (comment) See also [#t-infra > Tree ops](https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/Tree.20ops/with/568111767). > [!NOTE] > > This is a "fallback" PR in case the FileCheck failure isn't obvious (i.e. fix-forward). This PR reverts #130998 wholesale in case the failure is genuine and indicative of a bug in the actual implementation change.
Revert "avoid phi node for pointers flowing into Vec appends rust-lang#130998" This reverts PR rust-lang#130998 because the added test seems to be flaky / non-deterministic, and has been failing in unrelated PRs during merge CI: - rust-lang#151129 (comment) - rust-lang#150772 (comment) - rust-lang#150925 (comment) - rust-lang#151145 (comment) See also [#t-infra > Tree ops](https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/Tree.20ops/with/568111767). > [!NOTE] > > This is a "fallback" PR in case the FileCheck failure isn't obvious (i.e. fix-forward). This PR reverts rust-lang#130998 wholesale in case the failure is genuine and indicative of a bug in the actual implementation change.
Rollup merge of #151150 - revert-vec-append, r=Zalathar Revert "avoid phi node for pointers flowing into Vec appends #130998" This reverts PR #130998 because the added test seems to be flaky / non-deterministic, and has been failing in unrelated PRs during merge CI: - #151129 (comment) - #150772 (comment) - #150925 (comment) - #151145 (comment) See also [#t-infra > Tree ops](https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/Tree.20ops/with/568111767). > [!NOTE] > > This is a "fallback" PR in case the FileCheck failure isn't obvious (i.e. fix-forward). This PR reverts #130998 wholesale in case the failure is genuine and indicative of a bug in the actual implementation change.
This comment has been minimized.
This comment has been minimized.
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing c9af9c1 (parent) -> a6acf0f (this PR) Test differencesShow 3 test diffs3 doctest diffs were found. These are ignored, as they are noisy. Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard a6acf0f07f0ed1c12e26dc0db3b9bf1d0504a0bb --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (a6acf0f): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResults (primary 2.5%, secondary -1.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 473.67s -> 473.873s (0.04%) |
Due to recent advancements in merge queue bot technology, we no longer need this job. We still use a simpler job to publish the toolstate on
autobuilds though.Should be merged once we get rid of homu.