-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
TypeId implements_trait #151236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
TypeId implements_trait #151236
Conversation
|
Some changes occurred to the intrinsics. Make sure the CTFE / Miri interpreter cc @rust-lang/miri, @RalfJung, @oli-obk, @lcnr The reflection data structures are tied exactly to the implementation cc @oli-obk Some changes occurred to the CTFE machinery |
|
r? @chenyukang rustbot has assigned @chenyukang. Use |
|
Also, because this pull request is pretty much just copying and pasting from |
This comment has been minimized.
This comment has been minimized.
Sure , This way it's easier to maintain. |
|
Some changes occurred to the CTFE / Miri interpreter cc @rust-lang/miri |
This comment was marked as outdated.
This comment was marked as outdated.
This comment has been minimized.
This comment has been minimized.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
f603826 to
2f97f63
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Is there some way we could support #144361 in userland with this? |
That is a fun idea. Having some way of getting from a |
|
I know I need to update the 32 bit dump, but I'm not sure how. |
|
You can cross compile tests to a 32 bit target. For me "i686-unknown-linux-gnu" works |
This comment has been minimized.
This comment has been minimized.
0dbd632 to
d6a43ab
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
Some changes occurred in compiler/rustc_attr_parsing cc @jdonszelmann, @JonathanBrouwer Some changes occurred in need_type_info.rs cc @lcnr HIR ty lowering was modified cc @fmease
cc @rust-lang/wg-const-eval
cc @Amanieu, @folkertdev, @sayantn Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt Some changes occurred in compiler/rustc_passes/src/check_attr.rs cc @jdonszelmann, @JonathanBrouwer Portable SIMD is developed in its own repository. If possible, consider making this change to rust-lang/portable-simd instead. cc @calebzulawski, @programmerjake This PR changes rustc_public cc @oli-obk, @celinval, @ouz-a, @makai410 The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes. cc @BoxyUwU, @jieyouxu, @Kobzol, @tshepang
cc @davidtwco, @TaKO8Ki, @JonathanBrouwer Some changes occurred in compiler/rustc_hir/src/attrs cc @jdonszelmann, @JonathanBrouwer Some changes occurred to constck cc @fee1-dead Some changes occurred in exhaustiveness checking cc @Nadrieril
cc @tgross35 changes to the core type system cc @lcnr |
|
Oh goodness, by loading the backup, it thinks I've changed every file in rust. |
|
Perhaps I should abandon this pull request... |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
See https://rustc-dev-guide.rust-lang.org/git.html#rebasing for some help with rebasing. |
|
Anyone can feel free to try to recover this pull request. |
|
Yeah, probably best to start over. Next time, if you need to rebase over assuming that |
This is for #146922.
It allows checking if a
TypeIdimplements a trait.(I've never used git from the terminal before, so that was a fun challenge. I hope I did everything correctly.)
(I haven't added any tests yet, I'll do that soon.)
(Zulip.)