Add new unstable attribute: #[export_visibility = ...].#151431
Open
anforowicz wants to merge 3 commits intorust-lang:mainfrom
Open
Add new unstable attribute: #[export_visibility = ...].#151431anforowicz wants to merge 3 commits intorust-lang:mainfrom
#[export_visibility = ...].#151431anforowicz wants to merge 3 commits intorust-lang:mainfrom
Conversation
Collaborator
|
Some changes occurred in compiler/rustc_hir/src/attrs cc @jdonszelmann, @JonathanBrouwer Some changes occurred in compiler/rustc_passes/src/check_attr.rs cc @jdonszelmann, @JonathanBrouwer Some changes occurred in compiler/rustc_attr_parsing |
rustbot
added
A-attributes
rustbot
added
the
T-compiler
Collaborator
|
r? @chenyukang rustbot has assigned @chenyukang. Use |
Member
|
i had a quick look, mostly looks good, but i'd like to maybe @JonathanBrouwer take a look on this as well, i may overlooked something r? JonathanBrouwer |
Contributor
|
Would like to take a look, will do so tomorrow :) |
This comment has been minimized.
This comment has been minimized.
JonathanBrouwer
requested changes
Jan 21, 2026
rustbot
added
S-waiting-on-author
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
3 tasks
tgross35
reviewed
Jan 22, 2026
tgross35
reviewed
Jan 22, 2026
anforowicz
force-pushed
the
export-visibility
branch
from
2043b51 to
8dc8f60
Compare
This comment has been minimized.
This comment has been minimized.
anforowicz
force-pushed
the
export-visibility
branch
from
8dc8f60 to
6ccbf57
Compare
anforowicz
force-pushed
the
export-visibility
branch
3 times, most recently
from
88ddd87 to
a741ebc
Compare
tgross35
reviewed
Jan 27, 2026
anforowicz
force-pushed
the
export-visibility
branch
from
a741ebc to
aa26225
Compare
This comment has been minimized.
This comment has been minimized.
anforowicz
force-pushed
the
export-visibility
branch
from
8a51a4b to
6441282
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
|
Reopened to retrigger CI |
This comment has been minimized.
This comment has been minimized.
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 6, 2026
Add new unstable attribute: `#[export_visibility = ...]`. try-job: x86_64-msvc-1 try-job: i686-msvc-1 try-job: x86_64-mingw-1 try-job: test-various try-job: armhf-gnu try-job: aarch64-apple try-job: x86_64-gnu-llvm-20-3
This comment has been minimized.
This comment has been minimized.
rust-bors
bot
added
S-waiting-on-author
Contributor
|
💔 Test for ae11d92 failed: CI. Failed job:
|
Contributor
Author
This seems to be caused by this PR - I'll have to take a look: |
Contributor
|
Looks like the failure was on wasm32-wasip1. Testing locally that should support dylibs, at least rustc doesn't complain, but it emits with a If you could add a commit doing that then we can run the try job, though @jieyouxu should probably double check. |
Contributor
|
Indeed it seems like non-emscripten non-wali wasm should be using rust/library/std/src/sys/env_consts.rs Lines 370 to 379 in c58d9f9 |
Collaborator
|
The run-make-support library was changed cc @jieyouxu |
anforowicz
force-pushed
the
export-visibility
branch
from
3b58dc9 to
ea1d9d1
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Contributor
Author
Ack. Done. I also had to enable the And I also had to tweak test expectations in the new rmake test - it seems that Wasm symbols are always non-exported even without |
Contributor
|
@bors try jobs=test-various
I think this might just be how wasm object files are reported, but I'm not sure. @alexcrichton is the target maintainer and would probably know best what the behavior for wasm should be here. |
This comment has been minimized.
This comment has been minimized.
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 18, 2026
Add new unstable attribute: `#[export_visibility = ...]`. try-job: test-various
Contributor
|
💔 Test for 814edc7 failed: CI. Failed job:
|
This comment has been minimized.
This comment has been minimized.
Member
|
|
Contributor
Author
Thanks! I think you are referring to gimli-rs/object#471. I think for this PR we have 2 options:
Any feedback? |
Member
Not quite. That is for wasm relocatable object files. The issue in this PR is that also for linked wasm modules exports aren't listed. |
Contributor
Author
|
I can repro the test failures from #151431 (comment) by running I can fix I don't know how to fix Maybe I should consider adding |
Contributor
Author
Hmmm... actually, I guess I can define a no-op panic handler. But this still makes the test fail when targeting The test probably needs to skip/ignore this target architecture, but I am not quite sure how to accomplish this (after skimming through https://rustc-dev-guide.rust-lang.org/tests/directives.html?highlight=%40ignore#controlling-when-tests-are-run)... :-/ |
Contributor
Author
FWIW |
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Member
|
For wasm what I'd recommend, assuming you're ok with it, is to indeed skip this test on wasm. I think it'd be best to discuss the wasm-specific parts in a follow-up issue perhaps which tracks the wasm testing for this and what would be necessary for that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is an implementation of the RFC tracked in #151425