Add new unstable attribute: #[export_visibility = ...].#151431
Open
anforowicz wants to merge 1 commit intorust-lang:mainfrom
Open
Add new unstable attribute: #[export_visibility = ...].#151431anforowicz wants to merge 1 commit intorust-lang:mainfrom
#[export_visibility = ...].#151431anforowicz wants to merge 1 commit intorust-lang:mainfrom
Conversation
Collaborator
|
Some changes occurred in compiler/rustc_hir/src/attrs cc @jdonszelmann, @JonathanBrouwer Some changes occurred in compiler/rustc_passes/src/check_attr.rs cc @jdonszelmann, @JonathanBrouwer Some changes occurred in compiler/rustc_attr_parsing |
rustbot
added
A-attributes
rustbot
added
the
T-compiler
Collaborator
|
r? @chenyukang rustbot has assigned @chenyukang. Use |
Member
|
i had a quick look, mostly looks good, but i'd like to maybe @JonathanBrouwer take a look on this as well, i may overlooked something r? JonathanBrouwer |
Contributor
|
Would like to take a look, will do so tomorrow :) |
This comment has been minimized.
This comment has been minimized.
JonathanBrouwer
requested changes
Jan 21, 2026
rustbot
added
S-waiting-on-author
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
3 tasks
tgross35
reviewed
Jan 22, 2026
tgross35
reviewed
Jan 22, 2026
anforowicz
force-pushed
the
export-visibility
branch
from
2043b51 to
8dc8f60
Compare
This comment has been minimized.
This comment has been minimized.
anforowicz
force-pushed
the
export-visibility
branch
from
8dc8f60 to
6ccbf57
Compare
anforowicz
force-pushed
the
export-visibility
branch
3 times, most recently
from
88ddd87 to
a741ebc
Compare
tgross35
reviewed
Jan 27, 2026
anforowicz
force-pushed
the
export-visibility
branch
from
a741ebc to
aa26225
Compare
This comment has been minimized.
This comment has been minimized.
anforowicz
force-pushed
the
export-visibility
branch
from
8a51a4b to
6441282
Compare
This comment has been minimized.
This comment has been minimized.
rust-bors
bot
added
S-waiting-on-bors
Contributor
Author
Thanks for chiming in. It's quite possible that we are experiencing the same issue. OTOH, when running |
Contributor
|
Actually @bors rollup=iffy |
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Feb 5, 2026
…nathanBrouwer Add new unstable attribute: `#[export_visibility = ...]`. This PR is an implementation of the RFC tracked in rust-lang#151425
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 5, 2026
Rollup of 15 pull requests Successful merges: - #151431 (Add new unstable attribute: `#[export_visibility = ...]`.) - #146900 (Add avr_target_feature) - #152033 (Rename trait `DepNodeParams` to `DepNodeKey`) - #152142 (Convert to inline diagnostics in `rustc_hir_typeck`) - #152020 (Remove dummy loads on offload codegen) - #152023 (Some `rustc_query_system` cleanups) - #152068 (Convert to inline diagnostics in `rustc_resolve`) - #152081 (Port depgraph testing attributes to parser) - #152090 (Port reexport_test_harness_main to attr parser) - #152105 (Convert to inline diagnostics in `rustc_ast_lowering`) - #152108 (Convert to inline diagnostics in `rustc_expand`) - #152114 (Convert to inline diagnostics in `rustc_mir_transform`) - #152115 (Convert to inline diagnostics in `rustc_metadata`) - #152116 (Remove rustdoc GUI flaky test) - #152128 (Adopt matches-logical-or-141497.rs to LLVM HEAD) Failed merges: - #152070 (Convert to inline diagnostics in `rustc_pattern_analysis`) - #152106 (Convert to inline diagnostics in `rustc_ast_passes`) - #152109 (Convert to inline diagnostics in `rustc_errors`) - #152117 (Convert to inline diagnostics in `rustc_trait_selection`) - #152118 (Convert to inline diagnostics in `rustc_codegen_ssa`) - #152119 (Convert to inline diagnostics in `rustc_middle`) - #152126 (Convert to inline diagnostics in `rustc_mir_build`) - #152131 (Port rustc_no_implicit_bounds attribute to parser.)
Member
|
Failed in rollup in @bors r- |
rust-bors
bot
added
S-waiting-on-author
Contributor
This comment has been minimized.
This comment has been minimized.
tgross35
reviewed
Feb 5, 2026
anforowicz
force-pushed
the
export-visibility
branch
from
a4aff4b to
9e65da3
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Contributor
Author
|
The failure in the |
Member
yes, all PR failed for this CI error. |
rustbot
added
S-waiting-on-review
Contributor
|
Reopened to retrigger CI |
This comment has been minimized.
This comment has been minimized.
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 6, 2026
Add new unstable attribute: `#[export_visibility = ...]`. try-job: x86_64-msvc-1 try-job: i686-msvc-1 try-job: x86_64-mingw-1 try-job: test-various try-job: armhf-gnu try-job: aarch64-apple try-job: x86_64-gnu-llvm-20-3
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
rust-bors
bot
added
S-waiting-on-author
Contributor
|
💔 Test for ae11d92 failed: CI. Failed job:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is an implementation of the RFC tracked in #151425